Received: by 2002:a05:7412:8598:b0:f9:33c2:5753 with SMTP id n24csp567243rdh; Tue, 19 Dec 2023 07:15:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IEI2BpV2nY16oVYnjpBZ2er7pMA44HoiVbBkSBsbSwV6eugAwpRJArIZxY/qc5YGOM4qqTC X-Received: by 2002:a17:906:51c2:b0:a23:2726:4317 with SMTP id v2-20020a17090651c200b00a2327264317mr2662100ejk.107.1702998915492; Tue, 19 Dec 2023 07:15:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702998915; cv=none; d=google.com; s=arc-20160816; b=KCCXdeXm/6Di2VydD2K0nkuVd24UWBVUhDeDCjizyVBkAT9k9cK9Hu9isnJttFOJTI wwQnfF+xp7i2jJlQKLxvW/Ae5t3vJYcT+9Hs4flgoirWp8E/cugSlVPK/0q97v6R4MoI /tUxrGpsFRRu2R7v95tpylmYmIk9j4C2IDem/5rZLbQ65vAJ1rT7NSLf1QXC/yh9mDEx dlKfub4VBfQ4kSbMBHPGgdWrTK7CrCHtsjPv7CTL8qYMJ6deClNGRneT/NOOh8G21PNc VyvNM/darwjepxoQm5ClYRY0uw2/vucl2qZtP9l/lJBpeDWDLBpkWrzeP9R7roY/NYNt hmjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature:dkim-signature :dkim-signature; bh=7e5XCCyINAJ+NzY1e0bqdj0ZqmCV70DZ2zp5UsU/L/o=; fh=b6yhFtjXbDH9q2nLf1f2AIiwImmmE8eXiLau1bVo+TM=; b=F3cB0mPyaUQWpVBs+aSNa1jBA5WdzU7uieb6AAnzJxUXW3CdqPcaGniQkYO/EjZnN9 vREGXoTJQqmQ0U2R5tXH3beiotX8kYrpO4+6zlEgBIceSmasUN3sV47M8ilL/Nje0Zwt mRER2JTpt/W0uX8M3jWxhKetebpdb+vkNM3QnIBlldRp7zUducQQlOvDXMjpo731skaH lFpnoQTlmzyFLKigp4gb+qr3FEHSPQIEbb7aC8Mr6Vr91bZF0DRcF7d+2ttgexmjNZc0 oi2Zuhmc4o5Olbq+6V+DpfEhuVpAIfTZUVRMP2nLt1oiZfP06ovZZpZJZuhVtPpLJCMk 7qOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=XccugP6V; dkim=neutral (no key) header.i=@suse.de; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=XccugP6V; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=548TD8AN; spf=pass (google.com: domain of linux-kernel+bounces-5469-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5469-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a21-20020a170906469500b00a2331cf051asi2719167ejr.95.2023.12.19.07.15.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 07:15:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-5469-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=XccugP6V; dkim=neutral (no key) header.i=@suse.de; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=XccugP6V; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=548TD8AN; spf=pass (google.com: domain of linux-kernel+bounces-5469-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5469-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 41F0A1F22554 for ; Tue, 19 Dec 2023 15:15:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ADD7F1CA82; Tue, 19 Dec 2023 15:15:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="XccugP6V"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="548TD8AN"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="XccugP6V"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="548TD8AN" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43B801C69D for ; Tue, 19 Dec 2023 15:15:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4AF4E1F7C9; Tue, 19 Dec 2023 15:15:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702998902; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7e5XCCyINAJ+NzY1e0bqdj0ZqmCV70DZ2zp5UsU/L/o=; b=XccugP6V9mOSqAF3XMjc+FNyX8RyzRFKXkiS9xTrx3Kk3dsKooTXU1QtJyn2fsn9yNn6x/ HY7gu1MzDv/mNjDyNSepFtSpZjyT53Q0kSB3Yw5og6bzY7uS1SfZxsmOl4UmBgwv1XKpkk Ors64/EJkLoNClSQR+pIf4V2IsJOheA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702998902; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7e5XCCyINAJ+NzY1e0bqdj0ZqmCV70DZ2zp5UsU/L/o=; b=548TD8ANtNA0cf5N0kK6iobtEySQVB71WWm72LLAHrEeJs7oaNoruMJp/y99lWtmEnxe27 8LOM8Cdn9GNVpjCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702998902; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7e5XCCyINAJ+NzY1e0bqdj0ZqmCV70DZ2zp5UsU/L/o=; b=XccugP6V9mOSqAF3XMjc+FNyX8RyzRFKXkiS9xTrx3Kk3dsKooTXU1QtJyn2fsn9yNn6x/ HY7gu1MzDv/mNjDyNSepFtSpZjyT53Q0kSB3Yw5og6bzY7uS1SfZxsmOl4UmBgwv1XKpkk Ors64/EJkLoNClSQR+pIf4V2IsJOheA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702998902; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7e5XCCyINAJ+NzY1e0bqdj0ZqmCV70DZ2zp5UsU/L/o=; b=548TD8ANtNA0cf5N0kK6iobtEySQVB71WWm72LLAHrEeJs7oaNoruMJp/y99lWtmEnxe27 8LOM8Cdn9GNVpjCA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 36DF013B9B; Tue, 19 Dec 2023 15:15:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id 9vLjC3azgWUyfgAAn2gu4w (envelope-from ); Tue, 19 Dec 2023 15:15:02 +0000 Date: Tue, 19 Dec 2023 16:15:01 +0100 From: Daniel Wagner To: Hannes Reinecke Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Sagi Grimberg , Keith Busch , James Smart Subject: Re: [PATCH v3 01/16] nvmet: report ioccsz and iorcsz for disc ctrl Message-ID: References: <20231218153105.12717-1-dwagner@suse.de> <20231218153105.12717-2-dwagner@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Level: Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -7.79 X-Spamd-Result: default: False [-7.79 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_SEVEN(0.00)[7]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-2.99)[99.96%] X-Spam-Flag: NO On Tue, Dec 19, 2023 at 08:24:58AM +0100, Hannes Reinecke wrote: > > + * Disable in-capsule data for Metadata capable controllers. > > + */ > > + cmd_capsule_size = sizeof(struct nvme_command); > > + if (!ctrl->pi_support) > > + cmd_capsule_size += req->port->inline_data_size; > > + id->ioccsz = cpu_to_le32(cmd_capsule_size / 16); > > Why the division by 16? The unit size is 16 bytes: I/O Queue Command Capsule Supported Size (IOCCSZ): This field defines the maximum I/O command capsule size in 16 byte units.