Received: by 2002:a05:7412:8598:b0:f9:33c2:5753 with SMTP id n24csp573621rdh; Tue, 19 Dec 2023 07:24:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IFJZdEA6UjydRYJ3VrzxgY6eG2FpB7t/BOrNkurwTVO8N+qbgNW2LXsyaHYJdH5aZ6HGAtS X-Received: by 2002:a17:903:286:b0:1d3:bda3:4aa7 with SMTP id j6-20020a170903028600b001d3bda34aa7mr2641437plr.33.1702999441007; Tue, 19 Dec 2023 07:24:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702999440; cv=none; d=google.com; s=arc-20160816; b=AVBYF8sIeelgJaVCnBODMWWJm0M3urb5S5NRGjdwqHAQ2PAp3EeV3k3tQJStodLl2I mB4WuCyd88I8HbgR2gA3fMX4GK7/1iKD/+aAV8bnoH5XZiIqPHk9dnHzJHnTFsCHnKnA OXfDvcsfH3VsA3gUWlhuHFQACTo7JphLDDxTpfD0Yk+TBRVnzO668xctcEF9xP4njCu3 Jg1d2Bpm8eIkSgLOFh2uTU0N4mzNs+neBerUOzwRB/xM0X3R5sN6dgL4qT3V9h5vr5p0 GtoQ6O3WKiklLNlEnEGhd8SAhCl0cZCC+A90aYHjRFGd3hMRGJvpCV3icK58CNgPofV7 2BYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=f0UOZ8VrL/oouNYdqSXbbgETnT3D/EQ3t1zUq6Qh2Js=; fh=EhARjyCT01NQ/D0ELhYA/5A1bs7/0cdynFJYP8UiCA8=; b=MaLwGDDaDAb6nRiXvCwOTqLroLSoCaet1OgOZcCLCGWITLkkWXPT1LEgvGA3ShgTx6 wtfkAos3Cs9AYWKSMgC/277gOat1+oMif1AGEGtBX4dos0/6SWTQmps0ZdZQtLQEKfWC fhPxVUC6Gz/CcUPiuc8BRXkbYLdvfakBKLDcgKQnS3Gzd8oijmQ+Ths9QBG8JGZ3Wxgp scLnB5JmcNCfkROHJ2aDDF+06Df5nCbchUUU6k+MsiW0lLV/j7EI5Ch6jSchFXBDvCC0 XXpj1+X73N7TDudlGbLwCLDdzTa3qxKrnZqWUaARrBvLu3nZlLQIB5aT+Fjhrv3R/Aya ckIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=UivCMGxT; spf=pass (google.com: domain of linux-kernel+bounces-5478-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5478-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id s12-20020a170902ea0c00b001d34dd65eeasi2752801plg.528.2023.12.19.07.24.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 07:24:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-5478-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=UivCMGxT; spf=pass (google.com: domain of linux-kernel+bounces-5478-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5478-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 83FCF282568 for ; Tue, 19 Dec 2023 15:24:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 599191D540; Tue, 19 Dec 2023 15:23:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="UivCMGxT" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 460BD1D148 for ; Tue, 19 Dec 2023 15:23:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1d38e51cab3so9870705ad.1 for ; Tue, 19 Dec 2023 07:23:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1702999410; x=1703604210; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f0UOZ8VrL/oouNYdqSXbbgETnT3D/EQ3t1zUq6Qh2Js=; b=UivCMGxTSx94MzV0UFNQSLKrR34mNVFNCUFcH29GipSktwPh9zpXEAeVPKwgr3pQdv GS3lRlmEJvqn8c+y+zkk8dDB6wYqpGk+kv/14QNdAkujw/le+r5sQOXO5O3GFGS4xGF4 JPp6xDMDYGC78EDA4iIs5UvZRmKuV3lhDHBGLQ0XHF939YQCWYNDZphgnkCMcSjosUzm 1XGUE+WXgncC8grl7cATyNMolA/rYnYhqTYH0ZPgmSVdSNTybqgw97tLiLZhoDRFUuzI I9lUHgUIJQ6XJUpZOOGfaiCGkp3F0iYLDrLhGaUa/bw5dbQ4vZzCyxiblh1kfIw3WEcj ExsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702999410; x=1703604210; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f0UOZ8VrL/oouNYdqSXbbgETnT3D/EQ3t1zUq6Qh2Js=; b=hAkf3kjTlRKMLO14QDY6j7ER0ufA4iZ1UwoIoh4ed2kXRiJUH12wS4nBaql4TQA6l/ YFuWGciDcNB5syrhiI/wdXv2f4GB4wBoPf7G4tPKHZgBm3r+oI29UhfJWfoJDrKydb+F gItMyQ5OYazpN0rqYss7lShN1sqDgcfL3XTW15zIBzWk2TZcMIMsKgud4jiCbyMKq14U W5D1dGBcRg4ObD7ipCqdwtknW7L51FO2h0xiGiSS+9ZOqdHW/O/0grA0t0OUqK4hwfy3 hg7dFMOeJMd9hiENbsPur57S7dLTSVSk0RAj3flsqgjmxOLV9FinceK+23mD6+OmwCfj Zzug== X-Gm-Message-State: AOJu0YwjDZEuxpbIuaAX0UrAL5DgJnCaRcRPG+8V9OGsAruKrFldKy5a dfBut9pVruW5SuMtDWm1hvUAHPgcxrdH0lTWz5EO3A== X-Received: by 2002:a17:902:b18d:b0:1d0:80db:a841 with SMTP id s13-20020a170902b18d00b001d080dba841mr35939110plr.3.1702999410070; Tue, 19 Dec 2023 07:23:30 -0800 (PST) Received: from [127.0.0.1] ([198.8.77.194]) by smtp.gmail.com with ESMTPSA id jw20-20020a170903279400b001d36df58ba2sm9877965plb.308.2023.12.19.07.23.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 07:23:29 -0800 (PST) From: Jens Axboe To: penguin-kernel@i-love.sakura.ne.jp, linan666@huaweicloud.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com, houtao1@huawei.com, yangerkun@huawei.com In-Reply-To: <20231219075942.840255-1-linan666@huaweicloud.com> References: <20231219075942.840255-1-linan666@huaweicloud.com> Subject: Re: [PATCH] block: add check of 'minors' and 'first_minor' in device_add_disk() Message-Id: <170299940902.460104.1563250346911093809.b4-ty@kernel.dk> Date: Tue, 19 Dec 2023 08:23:29 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-7edf1 On Tue, 19 Dec 2023 15:59:42 +0800, linan666@huaweicloud.com wrote: > 'first_minor' represents the starting minor number of disks, and > 'minors' represents the number of partitions in the device. Neither > of them can be greater than MINORMASK + 1. > > Commit e338924bd05d ("block: check minor range in device_add_disk()") > only added the check of 'first_minor + minors'. However, their sum might > be less than MINORMASK but their values are wrong. Complete the checks now. > > [...] Applied, thanks! [1/1] block: add check of 'minors' and 'first_minor' in device_add_disk() commit: 4c434392c4777881d01beada6701eff8c76b43fe Best regards, -- Jens Axboe