Received-SPF: pass (google.com: domain of linux-kernel+bounces-5467-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <5bdfefe3-238a-48d3-b8a4-cee4fb6b0951@kontron.de>
Date: Tue, 19 Dec 2023 16:14:15 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 00/14] arm64: dts: imx8mm-kontron: DT updates
Content-Language: en-US, de-DE
To: Shawn Guo <shawnguo@kernel.org>, Frieder Schrempf <frieder@fris.de>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 Sascha Hauer <s.hauer@pengutronix.de>,
 Alexander Stein <alexander.stein@ew.tq-group.com>,
 Fabio Estevam <festevam@gmail.com>,
 Gregor Herburger <gregor.herburger@ew.tq-group.com>,
 Krzysztof Kozlowski <krzk@kernel.org>,
 Marcel Ziswiler <marcel.ziswiler@toradex.com>, Marek Vasut <marex@denx.de>,
 NXP Linux Team <linux-imx@nxp.com>,
 Pengutronix Kernel Team <kernel@pengutronix.de>,
 Philippe Schenker <philippe.schenker@toradex.com>,
 Tim Harvey <tharvey@gateworks.com>
References: <20231206144201.46911-1-frieder@fris.de>
 <20231213093134.GN270430@dragon>
From: Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <20231213093134.GN270430@dragon>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UVErQ3cwR2hjektiNmExSUk4MDVUWXFkN2FiYnpDZ1RCQTYrTVpNMTlPblc3?=
 =?utf-8?B?U3ptNGlPekx6M0RpZXd5T09XZmdGNHBEQ0puSEIraHB4NnRQUGxidzFUejM3?=
 =?utf-8?B?dmFZV3JyaFZVWlEwRW5QY1dpeDVScEZGMEt0L3NPTG93SnIvR2VBWFgzekNW?=
 =?utf-8?B?emJGakNXS3BKdytTM0hRaGlHa3V3SUtvK0Z4VmpzY3QrcVJFZ2xnTyt3L05J?=
 =?utf-8?B?TmowNGZSQmxvSlZvNEw1ZXg4UTVvQ1hXdkdIUGhIY1Z1bXNYQm5VcloyN3k2?=
 =?utf-8?B?NjgvZG8rUnU3eEFZOE9aSVRUckJaWnd6QXREcGNEaW1yaHo2N0REQVgrVVFv?=
 =?utf-8?B?VGJtcG1zN1BUQUFVZ2NHc3BOOGIyWDdOaWVJbmg0OXNaMVJiNkMxYnZHNFhF?=
 =?utf-8?B?ZU9kMHpFMDhnb1Y5MTNITzRjd2E1TVNoQVJUdjN3VDNVejdxMVNVRzJreGpK?=
 =?utf-8?B?WW1hdnF4ODhXM0VJblEwUEFSdHM0N1J5RXVON1BMZjBJVTIramJteGpHMG5s?=
 =?utf-8?B?bFd2VzZmVldTeVVhZncrV0pGUkhJT1k0YXFCRFA5bUtiei9BOWhhdEMxZGdD?=
 =?utf-8?B?S3VhWStKanc2WCt3TlVINEZoQkx0cldDNnFyZExjTUNvK2R2eDgxNU9KU0x6?=
 =?utf-8?B?T0E3Y2djQ01MTlBSZ0xxclppVk1sQUxraDU5dGVQRzUxR2FxT1dwdlFlbTJC?=
 =?utf-8?B?cTEvYXpDTHU3Qkd4WU5ZaCsvZEpwbGFRUzZ3ZytzZ2ZlMkc3RkY1UkUvZUgy?=
 =?utf-8?B?S0wwU0d0ZWIxMnJqNE5BSXFYaTByNjVhKy9pNzMvVWxXdlVvZkxobmVmcngw?=
 =?utf-8?B?cnhyTVRISlpWMWdmVXBXZDFyM2E1eUlxRXZxcXlLdVJNc1hhTDZaMXJObTVr?=
 =?utf-8?B?enU1eTNPcEJBQWhzYzlKanhvRUlMdFlIQXdJeUgrR1BjeFJjbms1M3kzTWVv?=
 =?utf-8?B?TTJ4R0t6OWsyTW1DNHpDTmdJaEpIM0tmUWJjeEV4bTBRQTlNNkw0NnMxM0NJ?=
 =?utf-8?B?bi9RSWZUbjFTMDNDbVRNdEJ6eWZia3RCTU9OMnlTVEZ6TFpNbDhpNDBBRHhI?=
 =?utf-8?B?OVBzZ1hlRHNXRThURU5QTXhiQjM0RjN3NGFGNzdkcFZUdWJDbGZ0UUxYU3NN?=
 =?utf-8?B?VHlabDA5UFU1SDRsajhCK3lGVS8rTjFiNGFBZVE5NlBZaWR3WXNPZDJnZ29R?=
 =?utf-8?B?YXp0MTFrYmZVVVFsUDU1NFJRQ2dxWjcyMHZ6UzZiVU02YnUxTm1QZnhieTlH?=
 =?utf-8?B?KzNaUGpybXZPbTNrMExUNGJOR3JPZE93b2V1a0xxZWtEMGVqNkFyMHhNUDla?=
 =?utf-8?B?TUt0UFBhL0R6WmJXR3BwbXhJZjExYUxiZ1VCZDROa3YwMDhNN1lDZ1dmM1c0?=
 =?utf-8?B?ZFlVTG5Zai80bWY1aXZPVVdZSjRzUll4bXZ5cURITnhUR3BaS0ZiMVROVGVH?=
 =?utf-8?B?c1E0NFREbDY3TFExcDh3ck1jN0RkUXNwM2ZHWGcwUndsUEI2MWlqRDlyKzBp?=
 =?utf-8?B?VTVkRCtoNzM2SFhNY0w4Y0VWV3J6WWNYQVBlWWlhajBEK1FjRjdpQ09QVnlC?=
 =?utf-8?B?bVc4R3hsc3daSnBlN1hIbFRwcFVrNm94WHlTYWd1SWpDVVk1d0VTaDRHR2c0?=
 =?utf-8?B?ZXhDeEtBM2lDc3Nodk10ZW5Rc0FXV04wMGVXMkdldzhhYnVzSmhnSWRnMndG?=
 =?utf-8?B?c04xVmc1ZlNNZ2JVWlhNNkhXeXNxd0Y1T0h2elE3MXgvU2xWWklpRGZkSDAy?=
 =?utf-8?B?Uk9QMUY5RldsTTVRMFZIcTUra2hFbGRYRmVyNGY4QlErSllaUWtDWXB6Mitv?=
 =?utf-8?B?STY1Z3lCeFVtSWFNcDF2WXJaUU10bWd2TEtKOVZkQXV4dWwxRzZVbzk0THIv?=
 =?utf-8?B?V3A5M1JJK0lZanlFcUF5RjFQREw0THZubldRMUdLV000KzFHYUJhczBhaVVl?=
 =?utf-8?B?SG9nMXBHQzVnb25CQlVwaWxNVkJRMEpDMDRyb2MvL0ZQc2ltSXRSbHdQaWpI?=
 =?utf-8?B?dmlpdnFESTJnd0EwQXpnU1lwMG1LN1YrZjNHU2RRck5PNDBsdnNseklMd3pa?=
 =?utf-8?B?dWQvOHBaa2JROTVycHRmVVY5RlhGWFIxM0w2Z1B5aWlNZkFVVVpBSDM5QXNw?=
 =?utf-8?B?N0NtbHUvWlFzY0NsUjRBdW9HUmgzNXA3N0pBbmZnUklZeFhNQysxaGdUVWwv?=
 =?utf-8?B?Qnc9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 33072cd4-ecec-4007-f37f-08dc00a52b75
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 15:14:18.0003
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aUKQw1MxiVTQe0iKSEYTgE2s44+s2s9nlGHb4C3JQNEEQk9uJkj3zSKdp/wAQIMBwJTbWyhSAeorummJc6eWDXpiQyszbzMEYxdqRLL+Ndo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3643

On 13.12.23 10:31, Shawn Guo wrote:
> On Wed, Dec 06, 2023 at 03:41:03PM +0100, Frieder Schrempf wrote:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> ...
>>  arch/arm64/boot/dts/freescale/Makefile        |   4 +
>>  .../dts/freescale/imx8mm-kontron-bl-osm-s.dts | 295 +++------
>>  .../boot/dts/freescale/imx8mm-kontron-bl.dts  | 198 +++++-
>>  .../boot/dts/freescale/imx8mm-kontron-dl.dtso | 201 +++++++
>>  .../dts/freescale/imx8mm-kontron-osm-s.dtsi   | 567 +++++++++++++++++-
>>  .../boot/dts/freescale/imx8mm-kontron-sl.dtsi |   4 +-
>>  6 files changed, 1035 insertions(+), 234 deletions(-)
>>  create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtso
> 
> A couple of things:
> 
> - I have to use 'git am -3' apply some of the patches.  Could you rebase
>   the series on imx/dt64 branch?

Ok, sure!

> 
> - There are a few DTC warnings that need to be addressed.
> 
> ../arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts:235.34-238.7: Warning (graph_endpoint): /soc@0/bus@30800000/i2c@30a40000/bridge@2c/ports/port@0/endpoint: graph connection to node '/soc@0/bus@32c00000/dsi@32e10000/ports/port@1/endpoint' is not bidirectional

I'm not aware of a proper solution for this warning. The thing is that
there is a DSI switch on the board that is able to route the DSI output
of the SoC to one of two bridges (HDMI or LVDS).

On the driver side there is no representation of the switch. Therefore
the result is a three-way connection for the graph ports which is
reported by the binding check, but works fine as we only enable one of
the target port nodes at a time and use GPIO hogs to select the switch path.

Rob, Krzystztof: Would it be acceptable to ignore this until there is a
way to represent this in the DT? Are there alternative solutions? Is
there anything to model a graph link switch?

> arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtbo: Warning (graph_port): /fragment@3: graph port node name should be 'port'
> ../arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtso:61.17-63.3: Warning (graph_endpoint): /fragment@3/__overlay__: graph endpoint node name should be 'endpoint'

For these warnings it seems like I could work around them by creating
two separate port nodes in the board DT and then only enable the proper
one in the overlay.