Received-SPF: pass (google.com: domain of linux-kernel+bounces-5489-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <6d7d0b33-6c9e-4941-af5f-678137d2a00e@web.de>
Date: Tue, 19 Dec 2023 16:32:48 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: [PATCH 1/3] kobject: Add a jump label in kobject_uevent_env()
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
To: kernel-janitors@vger.kernel.org, Andrew Morton
 <akpm@linux-foundation.org>, Greg Kroah-Hartman
 <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rafael@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, cocci@inria.fr
References: <e0543d9d-a02a-4c9c-b341-36771cfb5353@web.de>
In-Reply-To: <e0543d9d-a02a-4c9c-b341-36771cfb5353@web.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:hcQw/9bQR1o=;HL5Pf2hLEmDWinV+zatF7bP3R1l
 +kQw8rd9Ep4QCKYhup2nx2GEs6mb4obohDmH05Ff7ymBibhqU75K/r1lDdPKwVTaap+GgE7fa
 ahM3XHFEN19jDllEy0YPbts01U571bzGRy+KUVH0/j07X8YPmKXATQdx0xkNsFgFu/oSajBZ9
 bUBBxJzIlwt28c+qKdhBZFyiuggTu136gxqiFxutDLJu0OXwJ4vp0p+CBgVMQ+cTXHY2QfD1K
 hOsxTGIV7vP6C+hzdjzCEZWcVV1dM2jUcxjFWnY/hChFlQkAFOYH4aQo42zt9IQU7ODWHAzo3
 C9wrGnoskFEHPlPNM/n6Z0jtPxze2pyFEdFHajNvKCZqaaYUL7I7wKaSzpBsrbaNBapRVXv4D
 0XMBurnDW1b/QHYH3rxtnIDnBaozZIoCcjGTeiEn9Eh22DL4h0M6sVJGVeL+oDIAAGKxv8bz/
 KAzNT0Ff0LTZkFyt1JM82B7JotEeNNxZMLVVn5PwVWAbv9qwRecwYDRbDYMdsWERe3OOYlYTF
 2Hy8CKPTtG2U4bbxPM2d0Fa5pl7FjmjjYg62ss7mIriXM6t+Y+ABM0Qjaxm/4VQowKJnTvXSF
 anDFUWazBxqP28/kFUWDl0de3tr9FJ5//nd3f0jcEu6S5Qd0XjHXgCZLb2j0U6JjNl0oNtbZa
 ZCrrlWFpJ/VwPQrdk9qYKP/RBD/+hWF9UDOYo7xVbNsi3ksjyyyegMUr0oJJlH8msgy9gCkC6
 fbkJl+z7MQh6aVk+Cp+7KTIPH44BlvoZVWHkzVgbyyIBY1ioaZfly2BsuZwIuwu377GOT7fvN
 YSxxZRsj/hCoCfUT1jYoPFhPOWtYcXWTmnxSR1yPdorA3rWvWROnMyhJTWp8hbYSJOfVWGrff
 zMsIlecFJw0T1ATQMzmvVwcMBUmWSuxicVTLpK1Faj3W9jWpAnUrqL98Pu5d78Jj4eSBklaGU
 N3qjuQ==

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 19 Dec 2023 14:16:35 +0100

Use another label so that a call of the function =E2=80=9Ckfree=E2=80=9D c=
an be avoided
after a failed call of the function =E2=80=9Ckobject_get_path=E2=80=9D.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
=2D--
 lib/kobject_uevent.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
index fb9a2f06dd1e..811e579ed89d 100644
=2D-- a/lib/kobject_uevent.c
+++ b/lib/kobject_uevent.c
@@ -529,7 +529,7 @@ int kobject_uevent_env(struct kobject *kobj, enum kobj=
ect_action action,
 	devpath =3D kobject_get_path(kobj, GFP_KERNEL);
 	if (!devpath) {
 		retval =3D -ENOENT;
-		goto exit;
+		goto free_env;
 	}

 	/* default keys */
@@ -623,6 +623,7 @@ int kobject_uevent_env(struct kobject *kobj, enum kobj=
ect_action action,

 exit:
 	kfree(devpath);
+free_env:
 	kfree(env);
 	return retval;
 }
=2D-
2.43.0