Received-SPF: pass (google.com: domain of linux-kernel+bounces-5494-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <62be89bb-1ae1-4bf6-9f9e-b6eb68e6504d@siemens.com>
Date: Tue, 19 Dec 2023 16:37:42 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/4] dts: iot2050: Support IOT2050-SM variant
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
 Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Bao Cheng Su <baocheng.su@siemens.com>,
 Chao Zeng <chao.zeng@siemens.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 devicetree@vger.kernel.org, Li Hua Qian <huaqian.li@siemens.com>
References: <cover.1702917360.git.jan.kiszka@siemens.com>
 <11e0b0c8b828254567a8ff89820c067cacad2150.1702917360.git.jan.kiszka@siemens.com>
 <8b3daa3c-dbf8-4286-b04e-011cd9b0efa5@linaro.org>
 <4c31adc5-3fc5-47bc-9766-6d3d1eeddb65@siemens.com>
 <fbb29d81-9ea0-4468-ad47-f6668c2be277@linaro.org>
 <de3f4778-51d6-48ab-9d4d-451f2ba01a3c@siemens.com>
 <3d2662be-3a55-4390-bd2a-cfa5cc53510f@linaro.org>
 <ef5a6cf0-4350-483d-a1e9-ce8b0ef71280@siemens.com>
 <ce6b002b-f2a6-4056-bf81-53a6c948b946@linaro.org>
From: Jan Kiszka <jan.kiszka@siemens.com>
In-Reply-To: <ce6b002b-f2a6-4056-bf81-53a6c948b946@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OTRJa3FGT2tSaU4yRi91QitieVFCWWRueVB5S01uVHJOOHRBWnFaS0FRRzRt?=
 =?utf-8?B?SEo3N0pWMkM0NXhsWGJXYTBaRFJ4NWlqN29JaHh1WWpVR3AzRU5kTGdWZVNI?=
 =?utf-8?B?a3A4RVRQUm9pYkZ5RDAveGNHcUo1L3BsMldvRTN4ZDBrak5KL0o4dDJKMU1q?=
 =?utf-8?B?QUFLc2t4T2VQRGlKVVZSUUJ6SnVNcEkwVCt1eG1ZQmJOdzJaWTlaU1pJbUJW?=
 =?utf-8?B?aWdRM3p0UUZVcVRvMlhDVW4yU1k1aXRwZXk1UWxyd2FlK2pNQzYzajdZbGFR?=
 =?utf-8?B?YlY1Q2Fmdy9tN2x5Rk1FOUMzakQ3cm5RR0RLcDFQUSswcFRwOFJHaDV0ZS8v?=
 =?utf-8?B?citYc3lhUFhOek5sbnNXR1M4ZDVpUVF3aGZ0WHl3NlNJckpCbWdselFtZVJE?=
 =?utf-8?B?T3BRK1BxOWxIWFlWeHc2YXFoUytXVmQxbnZ2dlFMTkhISEVSUFk3T0w4ZHhl?=
 =?utf-8?B?cm9HVFdvT2twWEZJOVIvUktrVmFYRWFZRmZMdkh3QXJrLzRtNTBNUW1vRWI3?=
 =?utf-8?B?RWNpNFNqVWhzODZDMEU5dTRESXV6TzVFWXJweFdHRVZLd2h4WWpVazlRb2JM?=
 =?utf-8?B?U0FQeHNxTUVJVjdCZGVOY0s4R1ZlVy9sVXZmWklSRDY5NEpEeDlWUlpyNW1h?=
 =?utf-8?B?TXNHNW5vTkFaVzJ4OWhkeDRuUDVkZGFRWFZMYlNIbjc1Q0tENWw4T3lZR1dT?=
 =?utf-8?B?SWcvQmtkcERPeXM0dHpscXh1U2c4bk4vc3dSRXlSakVkaUVRazdCc2ZsL1A4?=
 =?utf-8?B?dDBpa2ZrWXc1L2JVU2tmU3JVUFRBaENxaFdiMnpBNXhJOXNwbVpKTUZFdnlB?=
 =?utf-8?B?ekpkbW1hZmVGRnJNaldxNWFYVXliamZEdmVPTWJBVUtUdlh0UWtMMHlKamd5?=
 =?utf-8?B?MjVaYzdualFYOHpXNXpaTjB1cTFpY1o3WjZ1NHNya0d3NVc3RmhORHgwVnJ2?=
 =?utf-8?B?U2kvOXpMQ2IvdHZza0psNzBoSld1KzE4N0pNTlM2dzJMRVFJR3pSRkhvV3Yw?=
 =?utf-8?B?WU5hZ3BiNlFubGVRMnkvMFpWM3dGR2RTSWVWSE5TVlgrWG1CYU5lelRYeEdp?=
 =?utf-8?B?alEyblgwNm80WkVKWGxRdlVPMlZjUUtNRUZwSElWc0piTmhySEVRVjd3dkJ5?=
 =?utf-8?B?TlBkNHluR0dNWVE0bWl1aE1rUjNINzk0Y00zUWhwVTM0SnMyWmtOeDdYNjFO?=
 =?utf-8?B?b01xZGtrM0NpK29mQ0ZERHRRR3FGVFZqWUQyVVE5aStPWStnQ3FoL09Zc21G?=
 =?utf-8?B?OVVIdFBOOEJ0YTAxSGx3WVVIRER1bzQzcTkyOGlVMnQyU1BiTS9xVkV2a1N1?=
 =?utf-8?B?V3R0aldHM0M0YktFTisvbkJoV0N2b3pIUi83U0NERGxaeHR5YjhPemRHYnJo?=
 =?utf-8?B?U05tdHd3VlEvTHFlaHZ2L0xONEpkVzV4Wm53bWZoYldhaVc0VnlZQnkzTHUz?=
 =?utf-8?B?eENlV0x0RmNraTcvQWoxWHEycXMySzVNTGZ5WjdWcllXZUVia1U1UnE1TmdJ?=
 =?utf-8?B?cStwWE9wTUdvaDlMSFlUUXIwdmhDb0tIUFpsSlVNTkRxYjFqd0dXYUFOUzlk?=
 =?utf-8?B?THVQVVhvclhWdEt4aDhINFFtN0ZaWlI1VDhuS2tsQ3hRazNENVJBc3h1aUxm?=
 =?utf-8?B?ZnlmUktHR3RjNlZacWd4aDFZNnNBMEJxN01tbDZISkxVOFJMYW1RNEIvbmp5?=
 =?utf-8?B?bXVNeHBPbDJwVDFmeWNYb1NjNGZ2NkY1c3BvYVp1Skk2Tmlqa0M4aEM5Z0xC?=
 =?utf-8?B?cEswV3pQTjE0anZFSDVUQmFTRUVLKzA4QjB6RDRzdDlrSVdDSHJzYnZzMEIr?=
 =?utf-8?B?bHJMU0grUUdSLzkxTkg3MTF1YVJyM0ZhT3RjU1VNeUFvQnpHZzlodWMvMHlk?=
 =?utf-8?B?RnREQ1BVZEFITWZiZ215OFJrcGppNnd1YzlnaU43WjNidVJpRWMrd2dLbGNU?=
 =?utf-8?B?UlBYSTE5WjM5Z1gwMWNFRmZXdEVPOXdkQjlmRTRZejI3WXhBNEgwMUlpWkJG?=
 =?utf-8?B?Q3JoMFlzVjlyd1dQY2hNaVBFS3pMTnZYTkJTbmlKdFFZRUY0dEEvZVJaRFNU?=
 =?utf-8?B?M2FLcWtCcXQ1Mkk0MERSSkIweHlIRXJzR0VTU0hyNjFUek1aSmNWZUcwaGl1?=
 =?utf-8?B?ZUZCQUpUanNhWVB1Z20zTzlkVmpJOGJ4aXJlUld4d1BpU0E4Z0xmVFEzem9D?=
 =?utf-8?B?VlE9PQ==?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 140f9c48-a0e1-479b-afc6-08dc00a874b1
X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 15:37:49.4361
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UHdIh3K8BwCs+xZsnpVi5zvqB2/YRnFvVoevDwHQxTO57PBhwsOPbEF9BdmQwh421grI8Ww51v4BfcesOBERnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR10MB8187

On 19.12.23 10:58, Krzysztof Kozlowski wrote:
> On 19/12/2023 10:54, Jan Kiszka wrote:
>>>>> You mean label. Why node names became the ABI? Which interface exposes them?
>>>>
>>>> root@iot2050-debian:~# ls -l /sys/class/leds/
>>>> total 0
>>>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 mmc0:: -> ../../devices/platform/bus@100000/4fa0000.mmc/leds/mmc0::
>>>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 mmc1:: -> ../../devices/platform/bus@100000/4f80000.mmc/leds/mmc1::
>>>> lrwxrwxrwx 1 root root 0 Dec 14 21:12 status-led-green -> ../../devices/platform/leds/leds/status-led-green
>>>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 status-led-red -> ../../devices/platform/leds/leds/status-led-red
>>>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 user-led1-green -> ../../devices/platform/leds/leds/user-led1-green
>>>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 user-led1-red -> ../../devices/platform/leds/leds/user-led1-red
>>>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 user-led2-green -> ../../devices/platform/leds/leds/user-led2-green
>>>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 user-led2-red -> ../../devices/platform/leds/leds/user-led2-red
>>>
>>> I replied too fast previous and did not include answer here:
>>>
>>> You have label for that... Somehow all these nodes are half-baked,
>>> without all the expected properties and now you call node name as ABI.
>>> The node name is not the ABI.
>>
>> Well, existing userspace uses those names, and adding the properties
>> would break that interface. Now, does Linux do that?
> 
> I don't think you understood the concept. There is no change for
> userspace. Same interface, same names. No ABI break.

I do understand the impact very well:
open("/sys/class/leds/user-led1-red") has to work for all the variants,
consistently and backward-compatible for userspace.

> 
> Anyway, changing them is not part of this patchset since these are not
> new nodes.

Fine, then we can leave the LED topic aside for now.

I will look into the other comments.

Jan

-- 
Siemens AG, Technology
Linux Expert Center