Received-SPF: pass (google.com: domain of linux-kernel+bounces-5506-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 19 Dec 2023 15:43:07 +0000
From: Conor Dooley <conor@kernel.org>
To: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
Cc: krzysztof.kozlowski@linaro.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	leyfoon.tan@starfivetech.com, linux-kernel@vger.kernel.org,
	linux-watchdog@vger.kernel.org, linux@roeck-us.net,
	robh+dt@kernel.org, samin.guo@starfivetech.com,
	wim@linux-watchdog.org, xingyu.wu@starfivetech.com
Subject: Re: [PATCH v4 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add
 compatible for JH8100
Message-ID: <20231219-hankering-console-7de049490dab@spud>
References: <1d7f9cbe-9ca1-4ccb-b90f-6e474c0740ad@linaro.org>
 <20231218153738.1054393-1-jisheng.teoh@starfivetech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="lh67mthVTQWcRrez"
Content-Disposition: inline
In-Reply-To: <20231218153738.1054393-1-jisheng.teoh@starfivetech.com>


--lh67mthVTQWcRrez
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 18, 2023 at 11:37:38PM +0800, Ji Sheng Teoh wrote:
> On Mon, 18 Dec 2023 15:41:37 +0100
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>=20
> > On 18/12/2023 15:27, Ji Sheng Teoh wrote:
> > >>
> > >> I have real doubts that you ever tested your entire solution with
> > >> this binding. Where is the DTS?
> > >> =20
> > >=20
> > > Currently, the DTS is still in internal and yet to upstream as it
> > > depends on [1]. =20
> >=20
> > Yeah, so you send untested code which cannot work or pass tests.  If
> > you do not test your code, we need to be able to at least verify it,
> > so send your DTS. Otherwise I cannot trust that this works at all.
> >
> Will submit it with DTS once things have cleared up.
> Thanks for the comment.=20

[1] is not going to applied for a while since the SoC doesn't actually
exist yet and is pre-tapeout on an FPGA. I would just send the dts patch
adding the watchdog alongside the series, or else you'll be waiting for
quite a while. Or even link to the node on github or whatever.

--lh67mthVTQWcRrez
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZYG6CwAKCRB4tDGHoIJi
0v//AP9ptXXWLaTpbN1hfhivvCOkAxz9G8QvhBald6lq3UuxxAEA3Vzl0QyXQqLJ
JBFmGXsq8799LeODq0XILF9lAsnwRgw=
=esPB
-----END PGP SIGNATURE-----

--lh67mthVTQWcRrez--