Received: by 2002:ac8:5349:0:b0:427:7d78:cd45 with SMTP id d9csp275971qto; Tue, 19 Dec 2023 07:58:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IEky4+yt2OF4qoVe3HhV9WadZZgcRC3tipMVPrVnyPm7sp3ppXZNpR3Fb1DBz/npR3650mm X-Received: by 2002:a05:6a20:6311:b0:18f:354f:58c2 with SMTP id h17-20020a056a20631100b0018f354f58c2mr1169571pzf.44.1703001492024; Tue, 19 Dec 2023 07:58:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703001492; cv=none; d=google.com; s=arc-20160816; b=KVaS3EMQYIlzL/HGPbIP/89c+9nUG92gk6d1cfTeO/r4buTGn1YN6hJfxuXcD0SewW 13GxMlQi/XxQqiTlUu1QWZ++HpCttzPzYbKwPhjPJ4XBZKsnjS3IvZaYEXGhoMErH6xG 3uyawcpMekRtRIDoE6SwxL2HdbwMSHGk1Rrwy/CnCXJ9/0a0LAPpbSoBSIEga7zKaEHd ms2H36AnFkXg85AcemOCh96PnHXE/oTKBrAxLqTdyMEO5pBP9+f/bM13dUXeb5zxq7ee kGG63JysIaF2qewNlgpVvHXVqJUxLNrO6/5nXUIyCJ5RbuZqwf52JrXZAt16ojfOARQ2 7H7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=tBpqWuxs1yCz983VuRpsBO762+PIqvAH6Pn4+BMpnf4=; fh=7MCHCt0Ygnf6QIrWwYKZsorAyLMfo7PmaZBvA3rENS8=; b=h0eVVabIQ270oAOOkxH/4pjBDhnkB/bxO+K1oU0ELU+HoqalS8GwRhg3NkIO04GtKy zi9xW46XkX34cWCdUDGgccnh+S22IHlNKeRznKoP63R4/TzzRLNn7XLauduconyX+tsv DI9MZpXTVyNPk3Y12S7RWfkAXoIz3SNtuvJIZ/WYFjiwfyNePRVnk3fR7IQ2KSIjEmCa 3kjIqvWmSJPKBt7O1CNXTNaNAw6sWPn4S8aOU7abN14MMssj8FpiW5xQuwWv4mKWd/ym eWgUhAXoOmziCvxMY0XPp9MUqmQpX6a6jXFYm9BxOq+p6r4nIqHEAGFM4pwXbwHNH8yL L1Xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=OWu2ERDW; spf=pass (google.com: domain of linux-kernel+bounces-5527-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5527-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id r29-20020a638f5d000000b005be3c62f45fsi530709pgn.638.2023.12.19.07.58.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 07:58:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-5527-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=OWu2ERDW; spf=pass (google.com: domain of linux-kernel+bounces-5527-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5527-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C3C22286DC5 for ; Tue, 19 Dec 2023 15:58:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C3E111D130; Tue, 19 Dec 2023 15:58:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="OWu2ERDW" X-Original-To: linux-kernel@vger.kernel.org Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 173A41D539; Tue, 19 Dec 2023 15:58:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=tBpqWuxs1yCz983VuRpsBO762+PIqvAH6Pn4+BMpnf4=; b=OWu2ERDWnREFZXruavgwOGbIvw LYCd5bWU8fxh58t1y945bqSa5gF5dj53Hs0LDemkFrCtkp+h98mlxYV4QGqbza0KZhBbcP+yHpqq5 0BwJ7jntI84KGjp2jQWr+d+u7gzRV7AdyeO3YiwJEyA9hrDY71JsqSKUw4sSQCGNWuTk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rFcTe-003LOK-PW; Tue, 19 Dec 2023 16:57:50 +0100 Date: Tue, 19 Dec 2023 16:57:50 +0100 From: Andrew Lunn To: Stefan Eichenberger Cc: Dimitri Fedrau , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY Message-ID: <5d545a9b-feda-4908-8f74-9218806451c1@lunn.ch> References: <20231215213102.35994-1-dima.fedrau@gmail.com> <74d4b8f9-700e-45bc-af59-95a40a777b00@lunn.ch> <20231216221151.GA143483@debian> <28cc73bf-ed6d-49d8-b80b-4fbf5fa0442f@lunn.ch> <20231217111538.GA3591@debian> <20231218090932.GA4319@debian> <20231219081117.GA3479@debian> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > I am not sure that it will be accepted by the maintainers if you use a > lot of registers that are not documented. Sometimes there is no choice, there is no documentation except the vendor crap driver which we try to clean up as much as possible, but we still end up with lots of magic numbers. Andrew