Received-SPF: pass (google.com: domain of linux-kernel+bounces-5538-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 19 Dec 2023 17:07:56 +0100
From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	avadhut.naik@amd.com, tony.luck@intel.com, john.allen@amd.com,
	william.roche@oracle.com, muralidhara.mk@amd.com
Subject: Re: [PATCH v4 1/3] RAS: Introduce AMD Address Translation Library
Message-ID: <20231219160756.GSZYG/3LbgTPT30Zwc@fat_crate.local>
References: <20231218190406.27479-1-yazen.ghannam@amd.com>
 <20231218190406.27479-2-yazen.ghannam@amd.com>
 <42c6ed78-75bd-4b4b-8b59-e0562d4968aa@wanadoo.fr>
 <2f114c41-5dbb-4019-b0f1-046509521d44@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2f114c41-5dbb-4019-b0f1-046509521d44@amd.com>

On Mon, Dec 18, 2023 at 04:53:24PM -0500, Yazen Ghannam wrote:
> Yep, good points. Thanks for your feedback!

Diff ontop in case you have to resend. Folding it locally.

Thanks Christophe.

---
diff --git a/drivers/ras/amd/atl/map.c b/drivers/ras/amd/atl/map.c
index 8145b7bb2b40..d160662f534f 100644
--- a/drivers/ras/amd/atl/map.c
+++ b/drivers/ras/amd/atl/map.c
@@ -650,7 +650,7 @@ static void dump_address_map(struct dram_addr_map *map)
 
 int get_address_map(struct addr_ctx *ctx)
 {
-	int ret = 0;
+	int ret;
 
 	ret = get_address_map_common(ctx);
 	if (ret)
diff --git a/drivers/ras/amd/atl/system.c b/drivers/ras/amd/atl/system.c
index 37ad203bb93e..3b6b5a5ddaab 100644
--- a/drivers/ras/amd/atl/system.c
+++ b/drivers/ras/amd/atl/system.c
@@ -225,8 +225,6 @@ static void get_num_maps(void)
 		df_cfg.num_coh_st_maps	= 2;
 		break;
 	case DF4:
-		df_cfg.num_coh_st_maps	= 4;
-		break;
 	case DF4p5:
 		df_cfg.num_coh_st_maps	= 4;
 		break;

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette