Received: by 2002:a05:7412:d008:b0:f9:6acb:47ec with SMTP id bd8csp39473rdb; Tue, 19 Dec 2023 08:48:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IEMlEg9helXLFrXFb6/wzEhoggqe8WVs3Ipkr2T87J2iUh/JoZ3swoi6q+CcrZg3rgmK9lX X-Received: by 2002:a05:620a:2556:b0:77f:8d2b:b627 with SMTP id s22-20020a05620a255600b0077f8d2bb627mr12803145qko.51.1703004535083; Tue, 19 Dec 2023 08:48:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703004535; cv=none; d=google.com; s=arc-20160816; b=iDWg4BMgKmabhEVOmZKPd4a9mtbXTC/Argp0/4v39YgqLkxF9hC7dw7Vbg4b/QYyRd F8Wv0ryNPA0drAClP33INw925v9OE4kZRu6YUvIQfWdUIOmjJegTG2VIGrKSYBgIBVx8 71xU9rrYBsp8MfmmsTXzT1qQkYan0ule3KzT5fScHqGHByC/Lq/oY97ULQsxgHOOHlL8 ThPN/J9eYVmNHJ8xnDIiEb6dfRCVNpTG7xW1kKPbnQ56G0F96DcRB6flB0fBM9z4C59r E1Osb08EuVpKvj6kPCuBZVvBtgsgGNTHMsE+kG/aKGT/oir3NfHXdbxCOKBETRR9sIvf WV5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:references:in-reply-to :user-agent:subject:to:from:date:dkim-signature; bh=EOCD7Shlg2KFEVb25pFCb4aRILZyHRKFnKAAS7R3DdM=; fh=p7yH2Sn30mxl4cG8EvyfEMe3ja0NsrUEDrRO/PzQjJo=; b=nICEs8kyGLzn3W0iYDl2+FYXO2h0cdUbOrVDih+TT7qEnfvnPNacz3fRfhb2roTlaq ovDeoRyd9ReL/iiKsO1Mb+AIbebWSdlOmgarUeQLwBAfU8DADRK8+4ItpaBJqR/0mU4z rgDN+B0H77c8tCaCL/HOjUulMoX4y1gMrsWhxYT6rQutq3Msuaj9Fs3SPdIm5jpxC2MX 6iHtLn2nrl3T1WOdRkBN7l24L6TCHtwt0fvr5C13dwiitu2Sp36YVCdcdvl9LNta2wtF DRrS8t3zL1osydxQiZwF9Hopn+56xFxuMvK093UQ6I7/kYMiSHFtJTFMqnPAgoLsPZty R+eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=YUvsQkVW; spf=pass (google.com: domain of linux-kernel+bounces-5595-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5595-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id qf4-20020a05620a660400b0077d7b05742fsi28789957qkn.33.2023.12.19.08.48.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 08:48:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-5595-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=YUvsQkVW; spf=pass (google.com: domain of linux-kernel+bounces-5595-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5595-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CA06C1C24A6F for ; Tue, 19 Dec 2023 16:48:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A5C7B210F9; Tue, 19 Dec 2023 16:47:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="YUvsQkVW" X-Original-To: linux-kernel@vger.kernel.org Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59A9720311; Tue, 19 Dec 2023 16:47:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=desiato.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:Message-ID:References:In-Reply-To:Subject:To:From:Date:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=EOCD7Shlg2KFEVb25pFCb4aRILZyHRKFnKAAS7R3DdM=; b=YUvsQkVW2VCdKuroGCXVzxdaZl 21cJwKUkRqR63J8X6RhppnFmHFYn/C+Ft6YRoCxEcn+6ppHrR3CZNwX1ckQ6d5waZWUQt8lUHekdl k4EHJm9LeGidlILKwvWHic/XLw9Rt6+6LbqTg8B4bh3R/XzdVBDtuDi8fAqm+DcTZv/OdcNwe3yOR u8J+z1elCamCtlwvEeeNWuZmqf//VckZq5qTwj3oEFxI4eRBWamhceUWzcuHCoabS+sEShd9hi1gl m9b4+q/EzV8aocjU7AbZl2aBbeKHX4Xs1ZeK0SFn5EPpFbWU0EPrAq3Z+mLEfmdmYnvA6J61TeG/F 5KG8Obfg==; Received: from [2001:8b0:10b:5:20dd:b45a:6fd4:1db5] (helo=[IPv6:::1]) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rFdEv-00DXFG-1F; Tue, 19 Dec 2023 16:46:41 +0000 Date: Tue, 19 Dec 2023 16:46:40 +0000 From: David Woodhouse To: Paul Durrant , Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Shuah Khan , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v11 16/19] KVM: xen: split up kvm_xen_set_evtchn_fast() User-Agent: K-9 Mail for Android In-Reply-To: <20231219161109.1318-17-paul@xen.org> References: <20231219161109.1318-1-paul@xen.org> <20231219161109.1318-17-paul@xen.org> Message-ID: <5B3EDE03-67F4-4BA2-89AA-F882DB6DE702@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html On 19 December 2023 16:11:06 GMT, Paul Durrant wrote: >From: Paul Durrant > >The implementation of kvm_xen_set_evtchn_fast() is a rather lengthy piece >of code that performs two operations: updating of the shared_info >evtchn_pending mask, and updating of the vcpu_info evtchn_pending_sel >mask=2E Introduce a separate function to perform each of those operations= and >re-work kvm_xen_set_evtchn_fast() to use them=2E > >No functional change intended=2E > >Signed-off-by: Paul Durrant Would still like to see the xen_shinfo_test use an evtchn port# which trig= gers the bug in the precious version=2E