Received-SPF: pass (google.com: domain of linux-kernel+bounces-5598-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 19 Dec 2023 17:47:44 +0100
From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
CC: <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Randy Dunlap <rdunlap@infradead.org>, "Tony
 Nguyen" <anthony.l.nguyen@intel.com>, =?iso-8859-1?Q?Bj=F6rn_T=F6pel?=
	<bjorn@kernel.org>, Magnus Karlsson <magnus.karlsson@intel.com>, "Jonathan
 Lemon" <jonathan.lemon@gmail.com>, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, "Paolo
 Abeni" <pabeni@redhat.com>, Alexei Starovoitov <ast@kernel.org>, "Daniel
 Borkmann" <daniel@iogearbox.net>, Jesper Dangaard Brouer <hawk@kernel.org>,
	John Fastabend <john.fastabend@gmail.com>, Larysa Zaremba
	<larysa.zaremba@intel.com>
Subject: Re: [PATCH net-next] xsk: make struct xsk_cb_desc available outside
 CONFIG_XDP_SOCKETS
Message-ID: <ZYHJMM6pjwD0UbqW@boxer>
References: <20231219110205.1289506-1-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231219110205.1289506-1-vladimir.oltean@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9Exq5+Ri8OOoAixdyKDFW1jYx0ouXWqqCxJ+tvyaHOMfbqNb49ygsLdeb7Gw?=
 =?us-ascii?Q?hc0B1p32L/y46SW4Fv3mq4mEf2D9q9sofbU8heRnAL6OCpq+Zlr69jVSqEJM?=
 =?us-ascii?Q?E0233nB5YlxyzhssSvfGlhJBvbD85H8xpQ2KJmidWJVxtUWfvL6ki3HCczWA?=
 =?us-ascii?Q?xHFG0Us/oBHpDPeQjOf05y+C6Rr7qIFGViBXQ61TVik8u6l9ooTQl++tbhF1?=
 =?us-ascii?Q?EI2bKpO3zMZLcRl7JfPUPR/bR1gpRzzSlnXWPYwTxMHROhRG0qWjNnvcuHIH?=
 =?us-ascii?Q?O7gYb0iAdGyi3aU5tfVc5TKbp3UlsIrZUFC3hOmWXr4VVHNylhSpS1QZobjD?=
 =?us-ascii?Q?g3g+1EtU2cc+hp8s/57nkE+sWKLkbqbag3r6x9zO4GKqHutaR0+G9JFPo/C7?=
 =?us-ascii?Q?MiWb4EKTbkqdLvSbZEnNUYBHwQgcVLYS+FoU5Oh0KiG3oE1CRsj3VC+8k8jo?=
 =?us-ascii?Q?ulRyoWoDXfaVLqR7H+NnQKD1XyRSxdtG4C7q8xT8WBf8BZH1VPUSRW9CZJE1?=
 =?us-ascii?Q?Y+fdowWzqiXM5by4gn8MkNcFSrYZUe5Fg/oFzmkrxnezlwQX7Joqx1wm5Was?=
 =?us-ascii?Q?fBdNcRz8aXHCwOOwIa083o3XFBwJlXbebA5FWeouqwT5ljurdYfQewqGbxnB?=
 =?us-ascii?Q?+3OMTqCiR19V0UU9IBa6iAJC9g9AsTlZqaDItsELqIzEk/at34RwoOwuMkaO?=
 =?us-ascii?Q?ETNctuKH0EMm6LRn4S4Tz/j/JLOievVxqZlUAqBB7cYugktSMWR1PK9tA+eC?=
 =?us-ascii?Q?yBD5D5/D3q1GHuBm2FzWugugxEixCZj+HeokOFUH52MP79nt+20Gp67IG/cP?=
 =?us-ascii?Q?YjIzDtZxOv7PCYTaQrn2zA33c5/6Yqb1/b5JZVhEGg0XtKfxdKZxfyjZtc9L?=
 =?us-ascii?Q?U2ekt++qw/JnkoI8cgK1xuhqX9I3Y3aOyAXkZplXARqjZ7KgdXUvWZwjGgvq?=
 =?us-ascii?Q?mcEoMgtRZFz2fzKRQhj5JsttaXiCOTMI/sZdPkUQgkA0y1ooZaXSDiEBEuKI?=
 =?us-ascii?Q?LGc3J6kacfIs7Ugb+1yrkWGyMn3KtfGN2F7xKyT87U3papoUUYiGCxOQX6tI?=
 =?us-ascii?Q?BAAx5yVnUb2MBagPKNSoSY+WaighDprymSEti1zozjuZZDfXKHYdhRCIj5U0?=
 =?us-ascii?Q?f6QUACkeP8kwNPLe8AIYq/hRvU06ovnruYYTFfwhxqTpVJ7fs7Uve208RW/+?=
 =?us-ascii?Q?/9SnCJvs6A/VmM9pZAHUG4eAxu8LigUrQeJ9aQPGg0H25qEekYENL+h0g2x5?=
 =?us-ascii?Q?C/PKZ13iWMienmH+eoMr7iLveli/834eYLTh/7pueLLXsJ9e232KSfWR2F+Z?=
 =?us-ascii?Q?v3qGjvrcTq0Z2eK0yd3O4tZgs/hQKIwTYp7xHWRopmm5AsbuXK+jswuIIz8g?=
 =?us-ascii?Q?BuxzUo9Lk5797q2DTpzTr/U7dJ7DvX5YZczYeaodbxdvBSIny3mvLZ+lJaRc?=
 =?us-ascii?Q?ZFo3zpaYt4oeztIaA1tG6gmXGRCEENcq+hqJfmBFbpwHHBOcSzj5ExIK9NPC?=
 =?us-ascii?Q?COj0VpTUXSXSuDUADKbv8Fgd+YeK/L7XJZATgGDfMumDWflOmN3sVHP0XQpL?=
 =?us-ascii?Q?vV3Kpuhc1KVUIhATI1AvFTCaZyQVZMLe990nsTGXUB4sv+yZlF2ziBzNaxUS?=
 =?us-ascii?Q?EA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 73ecb61c-548b-45e5-4dc5-08dc00b23caa
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 16:47:50.2818
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mrfPNmGbqqeu8CnT5yQ5AGMXo+d7/c3ViMBudqf5uSE1USZw8orSgFyyCNthztUBPaTDfo0k0bM2lETZbNPeWPaqxg7ZEFuz4uAtdexwtOs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8556
X-OriginatorOrg: intel.com

On Tue, Dec 19, 2023 at 01:02:05PM +0200, Vladimir Oltean wrote:
> The ice driver fails to build when CONFIG_XDP_SOCKETS is disabled.
> 
> drivers/net/ethernet/intel/ice/ice_base.c:533:21: error:
> variable has incomplete type 'struct xsk_cb_desc'
>         struct xsk_cb_desc desc = {};
>                            ^
> include/net/xsk_buff_pool.h:15:8: note:
> forward declaration of 'struct xsk_cb_desc'
> struct xsk_cb_desc;
>        ^
> 
> Fixes: d68d707dcbbf ("ice: Support XDP hints in AF_XDP ZC mode")
> Closes: https://lore.kernel.org/netdev/8b76dad3-8847-475b-aa17-613c9c978f7a@infradead.org/
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

Thanks Vladimir for acting upon this. Later on let us think about moving
this definition to xdp_sock.h maybe.

> ---
> Posting to net-next since this tree is broken at this stage, not only
> bpf-next.
> 
>  include/net/xdp_sock_drv.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/net/xdp_sock_drv.h b/include/net/xdp_sock_drv.h
> index b62bb8525a5f..526c1e7f505e 100644
> --- a/include/net/xdp_sock_drv.h
> +++ b/include/net/xdp_sock_drv.h
> @@ -12,14 +12,14 @@
>  #define XDP_UMEM_MIN_CHUNK_SHIFT 11
>  #define XDP_UMEM_MIN_CHUNK_SIZE (1 << XDP_UMEM_MIN_CHUNK_SHIFT)
>  
> -#ifdef CONFIG_XDP_SOCKETS
> -
>  struct xsk_cb_desc {
>  	void *src;
>  	u8 off;
>  	u8 bytes;
>  };
>  
> +#ifdef CONFIG_XDP_SOCKETS
> +
>  void xsk_tx_completed(struct xsk_buff_pool *pool, u32 nb_entries);
>  bool xsk_tx_peek_desc(struct xsk_buff_pool *pool, struct xdp_desc *desc);
>  u32 xsk_tx_peek_release_desc_batch(struct xsk_buff_pool *pool, u32 max);
> -- 
> 2.34.1
>