Received: by 2002:a05:7412:d008:b0:f9:6acb:47ec with SMTP id bd8csp66734rdb; Tue, 19 Dec 2023 09:28:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IHPPDaMf90C5mjud34evopdsvouW1Ts+Bgp3aBTQfyINjQe/XBYN8IxOVJr8zud5pf2TJBH X-Received: by 2002:a05:6808:2e8e:b0:3b9:ee90:4214 with SMTP id gt14-20020a0568082e8e00b003b9ee904214mr29244057oib.18.1703006915860; Tue, 19 Dec 2023 09:28:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703006915; cv=none; d=google.com; s=arc-20160816; b=W92r572x1JL+3NUvmALClXloSamNPCViQYnAH6M3pKUOlalOGFUPIs4bBRlYBWWvZC VRNnG30y/YLTb1RdVKNxUmycGTkfrdiPQVyoZGTikxA60sG5MW0jw/bqnMm5yC4FImP2 wd+1L8tHXGjX21jZ26T0oVE+mkhHxHsSn6GuRw7+QihmBqTSB/+s7LYfUkNBKIg65lpi 4wVUCx0KWNA5uiGB6FbKf5pTkXrttL33++QcglshYp941IVKh4anxNi+oY2rRUNbYG7p vN8cEUAMLNjZTt5FNc1C0TigqfbAzTiWxGupJKrmNZEk+zKGq3yx/87Lld3Tphn6eQcS X2Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=O4sWRWv5Pqq9STyzLneJg/h1bo9/XAz+sdxrFzOSieA=; fh=MwIgkKhNjxVX8WBtM/MPwCUSflpy00Z0rgHUdrYEp9I=; b=Ews5pSeDAWzGoBPggEWQzPq73Xx/t+L4RNj7gS/+HMio6M2QZhaEFYMsKTSdlsZ8WD GGxmJxwymZePU1DRjPhTM7KuuFQoZmwAmf8DbqYzzwvODaMP6hn2zHKYDQ19Z99VvUmx wHTUCqYGFb5ef+6JycApDLhc1DuHKMG8VOytX06FDUpVVRw8q8kCitxhQ58blvstx4l8 iDnzNtOKsGPpxbzbu1nybEeFJJGj5owXpoFhK9SLBk+NQUjYMh2CKKiXcu4VuuhLXRKx yytr4BfVDkguX3432ihhWXdUc5x/s+16Jn4/ExZmw5DD/Ub62MTm3hCtBI9vuc+cBvt6 0KxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OJKVGSni; spf=pass (google.com: domain of linux-kernel+bounces-5692-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5692-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id w8-20020a67e248000000b0046487fa4ab1si4544818vse.247.2023.12.19.09.28.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 09:28:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-5692-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OJKVGSni; spf=pass (google.com: domain of linux-kernel+bounces-5692-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5692-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7B99A1C20AB1 for ; Tue, 19 Dec 2023 17:28:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3BA4A1F93F; Tue, 19 Dec 2023 17:28:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OJKVGSni" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FD8E225D9; Tue, 19 Dec 2023 17:28:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B44BC433C8; Tue, 19 Dec 2023 17:28:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703006900; bh=LwFlemhDXsQTCT6yty5YjRZREbcZauYYlCKVORoaexg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OJKVGSniX51TQl0CIvTUnJe/j7dUF0DOmBUMiVvIKXuZWEHvY4rnDXDaku6eJpaPg q0sXvdfTOqEBBvmTC1957UCiN7MGiyL+qCpvUw8HdU8jwfd7x4NIg9qpmFp7cKaSq2 eHlfr4+C7EFFKTU37Jlv4aR3a9E1m9QyiatiLhD2iPEcOAUb7BxaTs6RF6FXzEk79i YorgjIi+9O1HRbyPalfibn+3HXqnZ6RF17bF+WvqcFu2PfcG3GhDB9dQWOIzDKxLUf Ga1a47sNG9diJWJkCzmeI4CDM1H6kyXaaN2e9X7kmYr8DoX6qN3nXZRw4mfjw/XbuH vuV/PszECjttQ== Date: Tue, 19 Dec 2023 11:28:17 -0600 From: Bjorn Andersson To: Konrad Dybcio Cc: Georgi Djakov , Abel Vesa , Michael Turquette , Stephen Boyd , Taniya Das , Jagadeesh Kona , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sai Prakash Ranjan , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 01/12] interconnect: qcom: sm8550: Remove bogus per-RSC BCMs and nodes Message-ID: <27rpxy5s5zo62o5waihq7phd67pn3hezag4xmpb3stc6x4r4bo@jysfz46pzkag> References: <20231218-topic-8550_fixes-v1-0-ce1272d77540@linaro.org> <20231218-topic-8550_fixes-v1-1-ce1272d77540@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231218-topic-8550_fixes-v1-1-ce1272d77540@linaro.org> On Mon, Dec 18, 2023 at 05:02:02PM +0100, Konrad Dybcio wrote: > The downstream kernel has infrastructure for passing votes from different > interconnect nodes onto different RPMh RSCs. This neither implemented, not > is going to be implemented upstream (in favor of a different solution > using ICC tags through the same node). > > Unfortunately, as it happens, meaningless (in the upstream context) parts > of the vendor driver were copied, ending up causing havoc - since all > "per-RSC" (in quotes because they all point to the main APPS one) BCMs > defined within the driver overwrite the value in RPMh on every > aggregation. > > To both avoid keeping bogus code around and possibly introducing > impossible-to-track-down bugs (busses shutting down for no reason), get > rid of the duplicated BCMs and their associated ICC nodes. > > Fixes: e6f0d6a30f73 ("interconnect: qcom: Add SM8550 interconnect provider driver") > Signed-off-by: Konrad Dybcio Reviewed-by: Bjorn Andersson Regards, Bjorn