Received-SPF: pass (google.com: domain of linux-kernel+bounces-5752-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Feedback-ID: i84614614:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1350-g1d0a93a8fb-fm-20231218.001-g1d0a93a8
Precedence: bulk
MIME-Version: 1.0
Message-Id: <79e0cb77-ea6a-427f-af5e-c1762049ac89@app.fastmail.com>
In-Reply-To: <20231219142508.86265-1-jefflexu@linux.alibaba.com>
References: <20231219142508.86265-1-jefflexu@linux.alibaba.com>
Date: Tue, 19 Dec 2023 09:56:12 -0800
From: "Stefan Roesch" <shr@devkernel.io>
To: "Jingbo Xu" <jefflexu@linux.alibaba.com>,
 "Andrew Morton" <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
 joseph.qi@linux.alibaba.com, linux-fsdevel@vger.kernel.org,
 linux-block@vger.kernel.org, willy@infradead.org
Subject: Re: [PATCH v3 0/2] mm: fix arithmetic for bdi min_ratio and max_ratio
Content-Type: text/plain

It would be good if the cover letter describes what this fixes.

On Tue, Dec 19, 2023, at 6:25 AM, Jingbo Xu wrote:
> changes since v2:
> - patch 2: drop div64_u64(), instead write it out mathematically
>   (Matthew Wilcox)
>
> changes since v1:
> - split the previous v1 patch into two separate patches with
>   corresponding "Fixes" tag (Andrew Morton)
> - patch 2: remove "UL" suffix for the "100" constant
>
> v1: 
> https://lore.kernel.org/all/20231218031640.77983-1-jefflexu@linux.alibaba.com/
> v2: 
> https://lore.kernel.org/all/20231219024246.65654-1-jefflexu@linux.alibaba.com/
>
> Jingbo Xu (2):
>   mm: fix arithmetic for bdi min_ratio
>   mm: fix arithmetic for max_prop_frac when setting max_ratio
>
>  mm/page-writeback.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> -- 
> 2.19.1.6.gb485710b