Received-SPF: pass (google.com: domain of linux-kernel+bounces-5813-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Ertman, David M" <david.m.ertman@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: "rafael@kernel.org" <rafael@kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "Weiny, Ira" <ira.weiny@intel.com>, "William
 Breathitt Gray" <william.gray@linaro.org>, David Hildenbrand
	<david@redhat.com>, Oscar Salvador <osalvador@suse.de>, Kevin Hilman
	<khilman@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, "Brown, Len"
	<len.brown@intel.com>
Subject: RE: [PATCH] driver core: mark remaining local bus_type variables as
 const
Thread-Topic: [PATCH] driver core: mark remaining local bus_type variables as
 const
Thread-Index: AQHaMpEHnG+TLmy1q0aP6ABzV9Z91bCw5b+QgAADIoCAAAREcA==
Date: Tue, 19 Dec 2023 18:32:31 +0000
Message-ID: <MW5PR11MB5811C5C0624C8414FB43F241DD97A@MW5PR11MB5811.namprd11.prod.outlook.com>
References: <2023121908-paver-follow-cc21@gregkh>
 <MW5PR11MB5811AB2DDE57E309A329F5BEDD97A@MW5PR11MB5811.namprd11.prod.outlook.com>
 <2023121943-slather-collide-f61c@gregkh>
In-Reply-To: <2023121943-slather-collide-f61c@gregkh>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DPcyR3E8ZsygeUGn5WglNTszxX/fYMfXS1Gz5PeeflljjVQNoCEfRoqHpKE6?=
 =?us-ascii?Q?iNtHUxb3fWCnDEF6UBCObsDDhd/4hW7MUvL54TVaG3+lziz04ZpHnGgKxkOy?=
 =?us-ascii?Q?DWYvL2ZYn0I+4XxMAMJEjhJsTRQw0K4bauJNbeZz40ACGlRaw9Vksz0g/P46?=
 =?us-ascii?Q?8JMkbQpEspMeArwoWDgHFR5pDeOeQXHXuXZQjS/zSxG9Q6Umfah3+T6FG2R9?=
 =?us-ascii?Q?BQvW7sXDaGdPKxFv/do15yx3S6WoqU5SVTZF9c37vfrz5sTdX9NxmBKd3V8d?=
 =?us-ascii?Q?UW3yOPwsnHKIyA97JAIXfDA0MMySA+Ry8UfcsJUKpmvuEuswj5tyWam3eTmD?=
 =?us-ascii?Q?EXXEUpYFR/we8CGwMh/yS+bCD0Km+PLQLev6xBpkVQ7EbDBXDN61EZe+D/3m?=
 =?us-ascii?Q?fgJBteqaE74FWD24cqDBkpHWHXvIVR+rRJ+bRj6zWAEQddaqrKQcatiQ+6VU?=
 =?us-ascii?Q?TVc85PU/yb5KQee2zt6cCmFoooGKxJTkdH1Q153LD1zDbDYlSipD1KVZ09Vw?=
 =?us-ascii?Q?E0zmkxCCF33k5v+7apPqm4KopAaZxuqLBWh6hPgYM6oy5hhljTFYxUMKh76D?=
 =?us-ascii?Q?KLWvNf4j+zOjtcYAx6/LMZaW9i3ES1s4WYjHn0J7f1trpRkQsgx7QF079sYE?=
 =?us-ascii?Q?kHkzB5OjdZa6E0+PQTRdPX7ystpRFDTm/a7r32V5BZSuiheXNF2Z60h1AWiL?=
 =?us-ascii?Q?Jo7GmUUJCG1s9sZ9DOD2zcuR1yHIDDC/UD2+eh+VTpLOc2JfoLOQC+HdaW6M?=
 =?us-ascii?Q?5QsZssy1KMpT+FzT3ZKAH4DbCkKXg/vcYhLg8bZkcQziwcojF9o6DlQzpETB?=
 =?us-ascii?Q?GtxHtsksjrqATy246ICvMFvmz6Z+/TYKUexj4z+FunirJcI7SRkIeiaVNAnF?=
 =?us-ascii?Q?df+/nfPdx6b2Fj0DVsjvZiYgk12wqP2kIJY1MV8qNtpLTk1zJt9Fiqr58JIP?=
 =?us-ascii?Q?03dlum3pJ4H9FoH/H3kqxjGkerQVvO6QHCToAADjkMeMERuOnzsAMWCwdV2z?=
 =?us-ascii?Q?d16WYxNhe3hzReC7g9VzJs1lk6g+RJq/DfS3truy/IsgSYC+L4y8ep9h4ZpD?=
 =?us-ascii?Q?sITqJgrwDMGyrFcu9OTtyR5qH1eYINAMyjmAK7Ux9nz2X0UcdB//hQn/4f/d?=
 =?us-ascii?Q?Zb25eFtHqFuXld4U69Mn7+m88HICJ6nTB51zaNRrHIsOMGdektaxro3XTSpa?=
 =?us-ascii?Q?TLQO9/Wbhz+tSYN1ZbXDmEyUrhdDoLv3vO89Ql3PrCUwud9JtI4Uc675pomu?=
 =?us-ascii?Q?OVMKUtulgW3SBoeHOmpuayl2J3tx9hIhzZfMd7vSTWdGKsoY9WH99z6uUIF2?=
 =?us-ascii?Q?RDMBHjU9W0/gnB4cSnWzyUsjuLfZtNaqCPDgOrV+cNsgwKkvHO7pO3myCmUc?=
 =?us-ascii?Q?iHUwX5T4u/3Wekgz+rhBw3hxJ3fszChJxlZZeI7/WlbNd6zY3IZFWCE3OqBV?=
 =?us-ascii?Q?fcWV+i0XGF3Zdzbc8HAuTbDkN5R3dW9K5fwoaE5HG+gm82+D7c9nz3EUbrqV?=
 =?us-ascii?Q?LRWZJaESAAZIE75G7F0eNKUzr74btVjLoHpw7FyZLoQGDg30SldbE8Yjf2MK?=
 =?us-ascii?Q?UuJWhycgCG/BzEJH9Sx9A/JfV2ISMVn+sQU3ih5T?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5811.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce77579c-5297-4ac3-d38d-08dc00c0dcad
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2023 18:32:31.5246
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bqekp38dT7sKLUSb1xJD9kCaTfuvaAdU5brbTlfSGXi0fbFSJKiAAgFkECFzJayP35pADJKp85YP9fwZkQ4zm25IluG0o0ZyAMgJLXGag1I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR11MB8409
X-OriginatorOrg: intel.com

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Sent: Tuesday, December 19, 2023 10:13 AM
> To: Ertman, David M <david.m.ertman@intel.com>
> Cc: rafael@kernel.org; linux-kernel@vger.kernel.org; Weiny, Ira
> <ira.weiny@intel.com>; William Breathitt Gray <william.gray@linaro.org>;
> David Hildenbrand <david@redhat.com>; Oscar Salvador
> <osalvador@suse.de>; Kevin Hilman <khilman@kernel.org>; Ulf Hansson
> <ulf.hansson@linaro.org>; Brown, Len <len.brown@intel.com>
> Subject: Re: [PATCH] driver core: mark remaining local bus_type variables=
 as
> const
>=20
> On Tue, Dec 19, 2023 at 06:02:33PM +0000, Ertman, David M wrote:
> > > -----Original Message-----
> > > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Sent: Tuesday, December 19, 2023 7:35 AM
> > > To: rafael@kernel.org; linux-kernel@vger.kernel.org
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Ertman, David
> M
> > > <david.m.ertman@intel.com>; Weiny, Ira <ira.weiny@intel.com>;
> William
> > > Breathitt Gray <william.gray@linaro.org>; David Hildenbrand
> > > <david@redhat.com>; Oscar Salvador <osalvador@suse.de>; Kevin
> Hilman
> > > <khilman@kernel.org>; Ulf Hansson <ulf.hansson@linaro.org>; Brown,
> Len
> > > <len.brown@intel.com>
> > > Subject: [PATCH] driver core: mark remaining local bus_type variables=
 as
> > > const
> > >
> > > Now that the driver core can properly handle constant struct bus_type=
,
> > > change the local driver core bus_type variables to be a constant
> > > structure as well, placing them into read-only memory which can not b=
e
> > > modified at runtime.
> > >
> > > Cc: Dave Ertman <david.m.ertman@intel.com>
> > > Cc: Ira Weiny <ira.weiny@intel.com>
> > > Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> > > Cc: William Breathitt Gray <william.gray@linaro.org>
> > > Cc: David Hildenbrand <david@redhat.com>
> > > Cc: Oscar Salvador <osalvador@suse.de>
> > > Cc: Kevin Hilman <khilman@kernel.org>
> > > Cc: Ulf Hansson <ulf.hansson@linaro.org>
> > > Cc: Len Brown <len.brown@intel.com>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > ---
> > >  drivers/base/auxiliary.c    | 2 +-
> > >  drivers/base/isa.c          | 2 +-
> > >  drivers/base/memory.c       | 2 +-
> > >  drivers/base/node.c         | 2 +-
> > >  drivers/base/power/domain.c | 2 +-
> > >  drivers/base/soc.c          | 2 +-
> > >  6 files changed, 6 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c
> > > index 4d4c2c8d26c4..d3a2c40c2f12 100644
> > > --- a/drivers/base/auxiliary.c
> > > +++ b/drivers/base/auxiliary.c
> > > @@ -244,7 +244,7 @@ static void auxiliary_bus_shutdown(struct device
> > > *dev)
> > >  		auxdrv->shutdown(auxdev);
> > >  }
> > >
> > > -static struct bus_type auxiliary_bus_type =3D {
> > > +static const struct bus_type auxiliary_bus_type =3D {
> > >  	.name =3D "auxiliary",
> > >  	.probe =3D auxiliary_bus_probe,
> > >  	.remove =3D auxiliary_bus_remove,
> > > diff --git a/drivers/base/isa.c b/drivers/base/isa.c
> > > index 675ad3139224..e23d0b49a793 100644
> > > --- a/drivers/base/isa.c
> > > +++ b/drivers/base/isa.c
> >
> > LGTM - ACK
>=20
> So, is that an "Acked-by:" type response?  We need something standard
> for our tools to pick up...
>=20
> thanks,
>=20
> greg k-h

Sorry about that :)

Acked-by: Dave Ertman <david.m.ertman@intel.com>