Received-SPF: pass (google.com: domain of linux-kernel+bounces-5827-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <a9cbebd8-dd6e-d81c-471f-f40dcc7196ea@linux.dev>
Date: Wed, 20 Dec 2023 02:47:29 +0800
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug()
Content-Language: en-US
To: Jonathan Corbet <corbet@lwn.net>, "JiaLong.Yang"
 <jialong.yang@shingroup.cn>, Alex Shi <alexs@kernel.org>,
 Yanteng Si <siyanteng@loongson.cn>
Cc: 2738078698@qq.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231219070813.29161-1-jialong.yang@shingroup.cn>
 <87wmtai77a.fsf@meer.lwn.net>
From: Zenghui Yu <zenghui.yu@linux.dev>
In-Reply-To: <87wmtai77a.fsf@meer.lwn.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 2023/12/19 22:43, Jonathan Corbet wrote:
> "JiaLong.Yang" <jialong.yang@shingroup.cn> writes:
> 
>> Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn>
>> ---
>>  Documentation/translations/zh_CN/core-api/printk-basics.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/translations/zh_CN/core-api/printk-basics.rst b/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> index 59c6efb3fc41..cafa01bccff2 100644
>> --- a/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> +++ b/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> @@ -100,7 +100,7 @@ printk()的用法通常是这样的::
>>  
>>  为了调试，还有两个有条件编译的宏：
>>  pr_debug()和pr_devel()，除非定义了 ``DEBUG`` (或者在pr_debug()的情况下定义了
>> -``CONFIG_DYNAMIC_DEBUG`` )，否则它们会被编译。
>> +``CONFIG_DYNAMIC_DEBUG`` )，否则它们不会被编译。
>>  
> 
> This patch needs an actual changelog.  Being illiterate in Chinese, I
> can't make any connection between the subject line and what has actually
> been done here.

Agreed. The change itself looks correct though, feel free to add my

Reviewed-by: Zenghui Yu <zenghui.yu@linux.dev>

in your next revision (with Jon's suggestion addressed).

Thanks,
Zenghui