Received-SPF: pass (google.com: domain of linux-kernel+bounces-5856-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <b5d4f9f5-e040-9668-fbbf-dd7b32da9fdb@intel.com>
Date: Tue, 19 Dec 2023 11:09:02 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH] dmaengine: idxd: Remove usage of the deprecated
 ida_simple_xx() API
Content-Language: en-US
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, Dave Jiang
	<dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>
CC: <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
	<dmaengine@vger.kernel.org>
References: <a899125f42c12fa782a881d341d147519cbb4a23.1702967302.git.christophe.jaillet@wanadoo.fr>
From: Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <a899125f42c12fa782a881d341d147519cbb4a23.1702967302.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGJKMmxjN1hUc0tHdzZMNGRYeGNncDkza0FGN3BHV1cyM0NHN0UvMUwvd1gv?=
 =?utf-8?B?VExoRmZJU2d4MU9udDM5VHp2YitPeWd6blZnSjVyb3NneXBteWhFR0FKQTI2?=
 =?utf-8?B?YVNtS29nMCtGWW5BWk1VQVZBRyttdmYrUEoxRXJQOUdIaWhlbjdSUnJNT05z?=
 =?utf-8?B?aTJQOVQzSGhkcGl6d3hrY2x5bmlJZDA1NHEzcGdCWGpvNU9raDZvUzA0YXBP?=
 =?utf-8?B?c1BpZVVieFF5UUVwVTdWa0lZeDZmeWgvTlFFYXFpT0ZoNjRXWFYxeVZhT0Nt?=
 =?utf-8?B?aTZSZzJQNjBQV0czdnFBdTgzQUtFSHdPQ1k5YWoxSysrMjc2QWRsZFc4YXhi?=
 =?utf-8?B?anFkWmpSYmpqSDRBbEt3eXEvQXBhVFVkYjduQ1dHQ2tLMEZpQ3ZmWEE1UW0y?=
 =?utf-8?B?eXg0dVg4N0xKR01ubWdVdGNxVVVYNkhVblZVMWFueG82S1pUSUlobmdBRjVi?=
 =?utf-8?B?R3o1T2hiaUY1TmY5elEvS0gvSGd3ZzhSSUgzTkpwcDFDT1JXdnp3b0EwUDJh?=
 =?utf-8?B?c0RNTzR1TnRBcldFMVFZbitCeEZQdkFMQ3hkTDhmREY5blNXa3oxTkJURTJs?=
 =?utf-8?B?Z2RpR2lueWpRM1ZNa1YwTURnbWVoZFVmVVRQeGY3Z3kvNTVmWTV6RzZmdlJZ?=
 =?utf-8?B?VTZjNmh6cHpDditVRXdrQlJOWGVpZENRSkhzR0V5SVRycGJHRVpSK0dOR0ZH?=
 =?utf-8?B?MG1iOWYza2hJSTB1S2lCU3pDOEMvdXhyNDkzNWpSTE9jZ3IwbDlmZm00Rjh5?=
 =?utf-8?B?QzVjQXJkdkp0eWVzMWJPV3UwWjlhYzlrSG5xUW55UXh5b2NzaTRUMyt6Tktj?=
 =?utf-8?B?NzVXS2ljdVZNbktOa3ZXU08vSjNpdjY5TFRuekpYaGxocUtsd0ZSM0xqMHRq?=
 =?utf-8?B?bUt4RFJ3S1pHTTc5U3pSVFRqOEVIS29OMVEyeUFLeVhrR1lORnBnZk1xRnFG?=
 =?utf-8?B?OXZGa3BkMU1XWXNDdGV5ZUxUMEpucjhkRFhiUkJsT3FHem1Ra0lrcE5ZNVRx?=
 =?utf-8?B?RUR6UjdEMHdZUEhrbWd4TG9EVnVmUXhnNnlWb2dhZitZaklXSzJUTmVTYVls?=
 =?utf-8?B?SUpvWnE3RzZ2UWFHaWdUcEFQdHVNdjkxbVpyUFZXakJOY0VXb0tzWTdzclNv?=
 =?utf-8?B?ZzFORlcvbXpiZUtleUNTdHlHV3hNa0tWRFJoY2MwT0ZLMEZpeWQ5RzZuTW1i?=
 =?utf-8?B?QnZJUm9pbXpTcFRCV1lNeVVnalVUWUttWHJWRGwyc1A3SFAzTEhpNkQ3Ujky?=
 =?utf-8?B?YnJIaTc2VitqbWE1OFliL2xRU3lDeW9qV09pQ3FjYVNxOVpkV05hRHhla3Fy?=
 =?utf-8?B?NzdzSUtUczNUcTlqd1I5RVdDR29MQlRkTXFqdDVzK3VxZVhlVTE1end5Znpy?=
 =?utf-8?B?WnBNT01OcmdTM0dwZ3JTSXJaNXBFZ2FBNHIxbkk1VkVKVFFhc0xrWC9HSmFM?=
 =?utf-8?B?dHBydHdFYXQ5RStoZjNobUthSHV3VDhEVmkxaEdkRE9VNmtReVMxZURnS0cx?=
 =?utf-8?B?bXlVaTFLS281OHRrUkFVRmZXV3RvWHBMMUhvWE5vRk1GcGppWm1PbzZrQ0lU?=
 =?utf-8?B?aDhOVlNRZ3I3c2RyU1JDS3VJQ1FuZ29mRTlyTU4wbXh4RXgrZ1FnZDZLSS9H?=
 =?utf-8?B?MG5TUUE2cENtM2tvRWVHeG5KdEY2Tm1MNVJ0N1RreGxiS1pBKytaNW1NOXo1?=
 =?utf-8?B?SW1wZnVMNFNCNE02MmhIYVovQUxiVnFYTEJOendza0N2R1Q1ZEczZjVmaE9H?=
 =?utf-8?B?d2Z5OE5lUjBONk9KSkRSeG5PZG5IRUNYTVNLUDZ6UVZXd0NvVitoKzdWNTNI?=
 =?utf-8?B?R2hWNk9Nbzk4MWNxUlBiSmY5aXJmUjZUdVlnUWZqc0FwT0xKRzk5Qms2TkZa?=
 =?utf-8?B?bC9XZmtWQTk1UGY5RjFCMVZwZW11QnZ3YUlQWjFaTmU2N3hhWXZRbGdKVU5I?=
 =?utf-8?B?TEovVFJTYXpVWmx1enp2eXU0a0poUmhTUlh3amJpK1RrenZZSUN0M2ZyMHZO?=
 =?utf-8?B?Nk04TGk4RzNjRjIzVWkrTXljdTdzQThSZitTSDA1Y05UYTExdWtVV2xLV3I5?=
 =?utf-8?B?cWV1bVZsL09xa3E1R3UzRXBHbHhnL3E4dFBFOWNZWU15RCtOdUJlWnd4RzA4?=
 =?utf-8?Q?YcJ96bCW3P7QcGxdbylT0uG6s?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a479fbde-55ff-4fd4-db9d-08dc00c5fd0a
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 19:09:13.5984
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +vn3vF84gK3YuL3ddwItUcc+GmQja2kzeU7D8fucMc/vDCQn6LNEwLxbz32F5EginpHWHvMPlt7kXKoGVoG49Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6065
X-OriginatorOrg: intel.com


On 12/18/23 22:28, Christophe JAILLET wrote:
> ida_alloc() and ida_free() should be preferred to the deprecated
> ida_simple_get() and ida_simple_remove().
> 
> This is less verbose.
> 
> Note that the upper limit of ida_simple_get() is exclusive, but the one of
> ida_alloc_range() is inclusive. So change this change allows one more

s/change this change/this change/

> device.
> 
> MINORMASK is	((1U << MINORBITS) - 1), so allowing MINORMASK as a maximum
Please remove the tab in "is	".

> value makes sense. It is also consistent with other "ida_.*MINORMASK" and
> "ida_*MINOR()" usages.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only, review with care for the upper bound change.

Tested on hw.

> ---
>   drivers/dma/idxd/cdev.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
> index 0423655f5a88..b00926abc69a 100644
> --- a/drivers/dma/idxd/cdev.c
> +++ b/drivers/dma/idxd/cdev.c
> @@ -165,7 +165,7 @@ static void idxd_cdev_dev_release(struct device *dev)
>   	struct idxd_wq *wq = idxd_cdev->wq;
>   
>   	cdev_ctx = &ictx[wq->idxd->data->type];
> -	ida_simple_remove(&cdev_ctx->minor_ida, idxd_cdev->minor);
> +	ida_free(&cdev_ctx->minor_ida, idxd_cdev->minor);
>   	kfree(idxd_cdev);
>   }
>   
> @@ -463,7 +463,7 @@ int idxd_wq_add_cdev(struct idxd_wq *wq)
>   	cdev = &idxd_cdev->cdev;
>   	dev = cdev_dev(idxd_cdev);
>   	cdev_ctx = &ictx[wq->idxd->data->type];
> -	minor = ida_simple_get(&cdev_ctx->minor_ida, 0, MINORMASK, GFP_KERNEL);
> +	minor = ida_alloc_max(&cdev_ctx->minor_ida, MINORMASK, GFP_KERNEL);
>   	if (minor < 0) {
>   		kfree(idxd_cdev);
>   		return minor;

Thanks.

-Fenghua