Received-SPF: pass (google.com: domain of linux-kernel+bounces-5901-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20231213102808.94695-1-yaozhenguo1@gmail.com>
In-Reply-To: <20231213102808.94695-1-yaozhenguo1@gmail.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Tue, 19 Dec 2023 21:22:35 +0100
Message-ID: <CAJZ5v0i4DAtzoJUyN0H-4rL=HR=cNntqrrJaDj12suF=7JiyeQ@mail.gmail.com>
Subject: Re: [PATCH] cpufreq: intel_pstate: Add Emerald Rapids support in
 no-HWP mode
To: Zhenguo Yao <yaozhenguo1@gmail.com>, srinivas.pandruvada@linux.intel.com
Cc: lenb@kernel.org, rafael@kernel.org, viresh.kumar@linaro.org, 
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, yaozhenguo@jd.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 13, 2023 at 11:28=E2=80=AFAM Zhenguo Yao <yaozhenguo1@gmail.com=
> wrote:
>
> Users may disable HWP in firmware, in which case intel_pstate wouldn't lo=
ad
> unless the CPU model is explicitly supported.
>
> See also the following past commits:
>
> commit df51f287b5de ("cpufreq: intel_pstate: Add Sapphire Rapids support
> in no-HWP mode")
> commit d8de7a44e11f ("cpufreq: intel_pstate: Add Skylake servers support"=
)
> commit 706c5328851d ("cpufreq: intel_pstate: Add Cometlake support in
> no-HWP mode")
> commit fbdc21e9b038 ("cpufreq: intel_pstate: Add Icelake servers support =
in
> no-HWP mode")
> commit 71bb5c82aaae ("cpufreq: intel_pstate: Add Tigerlake support in
> no-HWP mode")
>
> Signed-off-by: Zhenguo Yao <yaozhenguo1@gmail.com>

Srinivas, any objections?

> ---
>  drivers/cpufreq/intel_pstate.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstat=
e.c
> index a534a1f7f1ee..39e0a2cf7236 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -2406,6 +2406,7 @@ static const struct x86_cpu_id intel_pstate_cpu_ids=
[] =3D {
>         X86_MATCH(ICELAKE_X,            core_funcs),
>         X86_MATCH(TIGERLAKE,            core_funcs),
>         X86_MATCH(SAPPHIRERAPIDS_X,     core_funcs),
> +       X86_MATCH(EMERALDRAPIDS_X,      core_funcs),
>         {}
>  };
>  MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
> --
> 2.39.3
>