Received: by 2002:a05:7412:d008:b0:f9:6acb:47ec with SMTP id bd8csp173350rdb; Tue, 19 Dec 2023 12:52:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IEI/M+u28vjMDtEUThGnoBIbkuQ7HneEzYGehwgNOfbnmWQWjH36trvPFgchEnl6Z+BHBQ+ X-Received: by 2002:a17:906:58:b0:a23:c63:bf6f with SMTP id 24-20020a170906005800b00a230c63bf6fmr4994062ejg.87.1703019121403; Tue, 19 Dec 2023 12:52:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703019121; cv=none; d=google.com; s=arc-20160816; b=hfOlWx5WxQabjQRhY4DBILUuAD/uF7gQpX5121vSWi2k1w5HeBduAnxCnZlg9r9dEt zFdGVlDtXpflqKPKJOf4GZOLIJFxakZdq04bz3fZm1zY19DT1yiEE6ahZqjIuR2VF9I8 Re354FpTo9cs/1GRE0XDvJ6Ix3s5uVU6ej8FlOJ9IVxlrc+VrBE+5ZdaC5vNxRwefd3J 2g3AM9/CoBugHLssHd8HQVRlM5Wzg7WFOF33QiYgy2++PbLjsnBXSr2l7eXbi++ZR43l wlTeUqtgFpFlLNLbDObSgDGBVCnk/H0B4EEDrQ2BPh8km9sLKsrNT3HCHPkjxe8sMVut cMlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=BKBUXYIBYj+i0f0Vw2LEavJlPrlK8MtTyPPLU6pBIm8=; fh=BdakZqSjjEVIHjVP64OAm7ZWbdJWvwQUKGNPiAsGmHw=; b=z2+fuCVHbLyBaaArp42VOioV7J6/ewxQ4wJRWy8oDD2O95MrOjNTtu72x5aFWstZz4 iMno8nGsPv+ORK0SNYRWU1hSJ/OItpKvup3V0W+1/Vc4jFGIg6+ZQjyl7o0N3bNFmhqR J3Kj0bdf47XBXcNJAhNFAdZKeJmYD8LchZsFVtlvLknfnJLWT6vQceucGdHd3aIEjVGQ D9UyQlfl+WxPhQXSiTMbr6XIpDI4v6uXXozCnU+uKJt3fS2dKeO4XP6DHNP+ysrgNFwq 3cHfUc/ptNEiTl32lCpPhTH6BsH8ytFbTBh8Iae4RwyBmjEiDocGFa5qEw7v955AYH5t LgtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=FvCGhuOh; spf=pass (google.com: domain of linux-kernel+bounces-5938-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5938-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id k9-20020a170906158900b00a2312c0c314si4856093ejd.684.2023.12.19.12.52.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 12:52:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-5938-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=FvCGhuOh; spf=pass (google.com: domain of linux-kernel+bounces-5938-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5938-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2B5791F2358D for ; Tue, 19 Dec 2023 20:52:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B7D6939AF7; Tue, 19 Dec 2023 20:51:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="FvCGhuOh" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF34639ADE; Tue, 19 Dec 2023 20:51:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17AA6C433C8; Tue, 19 Dec 2023 20:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1703019112; bh=BKBUXYIBYj+i0f0Vw2LEavJlPrlK8MtTyPPLU6pBIm8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FvCGhuOhT1VaMyeTfhuDkqPJB7Ad4MWtQp0vOK/dJl783EUuK0cYVZkBHeaGfhtnK VMrTbERrRljzdgI578umcbKmjGCJ3ke42h8hFe9NFWx4505Z4nPt+eKh2SH7HvK2VL Hzt7gWOhcNcdR7NiluYs18/1aR0+wfhjtTwh1fTc= Date: Tue, 19 Dec 2023 12:51:51 -0800 From: Andrew Morton To: Changbin Du Cc: Luis Chamberlain , , , Hui Wang , Xiaoyi Su Subject: Re: [PATCH] modules: wait do_free_init correctly Message-Id: <20231219125151.4a042a259edf3c916580ccfe@linux-foundation.org> In-Reply-To: <20231219141231.2218215-1-changbin.du@huawei.com> References: <20231219141231.2218215-1-changbin.du@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 19 Dec 2023 22:12:31 +0800 Changbin Du wrote: > The commit 1a7b7d922081 ("modules: Use vmalloc special flag") moves > do_free_init() into a global workqueue instead of call_rcu(). So now > we should wait it via flush_work(). What are the runtime effects of this change?