Received: by 2002:a05:7412:d008:b0:f9:6acb:47ec with SMTP id bd8csp175294rdb; Tue, 19 Dec 2023 12:56:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IH/6avZGUqy2OAhQtgcz4ta8nGKxgFE3wq8JFInPe0fGFHluBH0E8JifmiXVhUIzf7GXvEl X-Received: by 2002:a25:25d1:0:b0:dbd:97c5:907d with SMTP id l200-20020a2525d1000000b00dbd97c5907dmr368949ybl.118.1703019417349; Tue, 19 Dec 2023 12:56:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703019417; cv=none; d=google.com; s=arc-20160816; b=Zvrs58tWtCI2ZZJ7vv8ubCgkyixKrbrZyyZibgoCAvaypXxylmj5TRaWV2vMSG/D6k NX9BgFNUs/oTum2jVeRwYgjuak5EdJATqykO3Btd4laHeq7OMaHG3+3uEJMRzF2Iu6uK icrpa0yZn80tHMzaKFxawhNEQNHx1PBHEPIzAGgXQnrbd5+0Ki0/lsX6mgQfDlxQgmdp EMhcJn7ZsNyUuJ//mCmQht2ZnDZvCT/cawCxRMrbiPtb1MMQrLQFrxHCYIDk/I5BuA4e /VNos5UovBlg8hOKlxS8huWEonQXiLParcGF9sUb6FSaSJu9mXV6jy1wwY2Nyotzj3Bk Otyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=bI7eRgyy5+ORKYRMoLdIMmfFqNe12oOLtPUfljOSAyw=; fh=ZWajsA46HF+MJAxpTBp4avaI07wURajbdYntPLPBxEY=; b=zGbLd6+pdkyeOT/w8AKyu66gCGG76kOG/9nre5a7O1zFkz9L5osFdDGUpE6aunfJsa XEYGaqKy5C57EvsUQw6WV+B16SGjflsW2tA8IigkeaG+mYQMh8OqP3FGugow7BWPucEB GKe/1vOrJtNuJSAnuVIcwKKU8MsX0G/elwa4DUOmVPfIqGIFwy+EkW5kFYNSAzOOfz15 MW/3QkErMkqtGtTLCDO8LLSIhYTj90E/SXNUdeAx4ioBFTgesz8gA6d/APBzrc0Cy4yj VJbyk/8bEcwHNZ5TXRv1PtgOY3zKjBm3AP/BkDS72xSTSMcu2BawNol7gkH4vcshtGRC dJBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NRTNu4af; spf=pass (google.com: domain of linux-kernel+bounces-5944-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5944-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id b12-20020ac87fcc000000b00425b265c0a5si25993346qtk.696.2023.12.19.12.56.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 12:56:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-5944-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NRTNu4af; spf=pass (google.com: domain of linux-kernel+bounces-5944-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5944-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1E20D1C25031 for ; Tue, 19 Dec 2023 20:56:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A7E413A292; Tue, 19 Dec 2023 20:56:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NRTNu4af" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5E5939AEA; Tue, 19 Dec 2023 20:56:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3859C433C7; Tue, 19 Dec 2023 20:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703019362; bh=bI7eRgyy5+ORKYRMoLdIMmfFqNe12oOLtPUfljOSAyw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NRTNu4afzfmyVVxHDtB7hzC5xvReRXGZC3oX6gzfNCDxJV9dmI0Qx+K0XKecETC6y 9maVdCXBahsp2UOvHWiQgrzHt+9fpBmshww7mD0gGSvxXCWp0Xv5XgCVzUsiX4unQb 2jBBsQt7f1jfU+bT93hf+je1VMnkQW0WB9vvhxYHmdvkEQi7T91f4xG3JHbB7j3nMb fJlzoDmOzMJaFsMA7u9vMZC04S37LRZKw9bf+rGzR/YkAYlPbVIuQ67tCmFSCE3yFp xuaoo0xRMCxtVl/p/82ntXh2VNF1URJ6GVGAvtqZiWPC/UOx1qq1dM+8LSEq5dGQbO HP0GDTKTyR+Qg== Date: Tue, 19 Dec 2023 21:55:58 +0100 From: Wolfram Sang To: Quan Nguyen Cc: Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Andi Shyti , Andrew Jeffery , Jae Hyun Yoo , Guenter Roeck , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, Cosmo Chou , Open Source Submission , Phong Vo , "Thang Q . Nguyen" Subject: Re: [PATCH v4 1/2] i2c: aspeed: Handle the coalesced stop conditions with the start conditions. Message-ID: Mail-Followup-To: Wolfram Sang , Quan Nguyen , Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Andi Shyti , Andrew Jeffery , Jae Hyun Yoo , Guenter Roeck , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, Cosmo Chou , Open Source Submission , Phong Vo , "Thang Q . Nguyen" References: <20231211102217.2436294-1-quan@os.amperecomputing.com> <20231211102217.2436294-2-quan@os.amperecomputing.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EnB+dRLs7i+8f3ip" Content-Disposition: inline In-Reply-To: <20231211102217.2436294-2-quan@os.amperecomputing.com> --EnB+dRLs7i+8f3ip Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 11, 2023 at 05:22:16PM +0700, Quan Nguyen wrote: > Some masters may drive the transfers with low enough latency between > the nak/stop phase of the current command and the start/address phase > of the following command that the interrupts are coalesced by the > time we process them. > Handle the stop conditions before processing SLAVE_MATCH to fix the > complaints that sometimes occur below. >=20 > "aspeed-i2c-bus 1e78a040.i2c-bus: irq handled !=3D irq. Expected > 0x00000086, but was 0x00000084" >=20 > Fixes: f9eb91350bb2 ("i2c: aspeed: added slave support for Aspeed I2C dri= ver") > Signed-off-by: Quan Nguyen > Reviewed-by: Andrew Jeffery > Reviewed-by: Andi Shyti Applied to for-current, thanks! I'll wait with patch 2. It seems there are issues to be solved before. --EnB+dRLs7i+8f3ip Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmWCA14ACgkQFA3kzBSg KbZyCA//ccM+CCktAPNx6R6VzRFUXc9PKW3sgI5UZ6kuiBU+ntqHpNArrKZRxWFj owkYvvBdo2tg1YZQWQOAEwdzOz3mEQ2py3faQRIEL08bihsZhgSR43jR/D2d9fpI tssJghX3Hu3VMt1m0O2PUqX+20IJhYxjuQIVB5VEm7gSvlRoDcl+nqps/xEyICv5 A+Uftt2ZWHRGVgQ+RZB98BSsfFbPIgw64BfG0iKUF2bVqjPBCAMfPs2bZUSoGdxl I9cSyIzWqKmQ3R2R84S+tJw6xCy1aENHHXAaXHDFLtiXieoZrcBSvs3U2YaBcFeA VvZNMxPnGETYPsn8Hze1En1wJFimMzxEcpRRu380W+GphZa38oJyfadRh38oh8yf pYgu9hsL4vAUefT28PvBTC75T9AabggQifj3KqdxAEWfolcsB219lDgsC8qPnOKI IhU4bbtgGNM2z8pUN8zvFxWx9oJGONR8yibrkWhpSAsM1Wi1JREvxfdhOhlJ+84Y 8j5AhARou0HEOb0mtaIBAT37UWyBX9/HlZatXFeSi4p9AktTpKS9A014Zw5rp3OS rZci0/iUupGoc7tg9KkbTQ0Oc4zMA9FhGKnWb+gXFw6lZPVs6w9O+EidfBCKG7iq mgpWX0bhPwIsr7IKgR29OeKEbWiD2Uye033m5dfBTQ8cnaL0yuc= =mbba -----END PGP SIGNATURE----- --EnB+dRLs7i+8f3ip--