Received-SPF: pass (google.com: domain of linux-kernel+bounces-6001-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 20 Dec 2023 00:58:16 +0300
From: Serge Semin <fancer.lancer@gmail.com>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>, 
	xiongxin <xiongxin@kylinos.cn>, Andy Shevchenko <andy@kernel.org>, hoan@os.amperecomputing.com, 
	linus.walleij@linaro.org, brgl@bgdev.pl, linux-gpio@vger.kernel.org, 
	linux-kernel@vger.kernel.org, stable@kernel.org, Riwen Lu <luriwen@kylinos.cn>
Subject: Re: [PATCH v3] gpio: dwapb: mask/unmask IRQ when disable/enale it
Message-ID: <yko4bwzrnlvncljpgyxlsvioqeyf3zxb255qexlawooqjxvedn@dkr7i7fame3n>
References: <20231219013751.20386-1-xiongxin@kylinos.cn>
 <7zdg5ujizncarxvdyahnusojiq44rzxx2zybqj4kzsonzr27gq@fm5wj7npqsk3>
 <CAHp75VceVAZYTNsJaYYRN+EMExFZSQARsJowd-CvDLRtuOPKSg@mail.gmail.com>
 <euhbczna4hk5sacb23i2xwqh2jewlek7cfceprfslpsiijhwk3@3d6vtybmgag5>
 <20231219-whispering-independent-bonobo-d14a04@lemur>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231219-whispering-independent-bonobo-d14a04@lemur>

Hi Konstantin

On Tue, Dec 19, 2023 at 01:56:47PM -0500, Konstantin Ryabitsev wrote:
> On Tue, Dec 19, 2023 at 05:31:38PM +0300, Serge Semin wrote:
> > > > Also note all the tags you've already got must be preserved on the
> > > > next patch revisions. One more time:
> > > 
> > > > Acked-by: Serge Semin <fancer.lancer@gmail.com>
> > > 
> > > I recommend using `b4` for that.
> > > 
> > > it harvests tags from the email thread, so no need to care about
> > > possible misses.
> > 
> > AFAICS it doesn't pick up the tags from the previous revisions at
> > least if the new patch wasn't submitted as in-reply-to the prev one.
> 

> It's a known limitation at this time, but it will be improved in the near
> future and we'll be able to grab trailers across revisions as long as the
> patch-id remains the same.

Ok. Thanks for the note.

I am sure you are well aware of that, but in some cases the tags are
intentionally omitted in the new patch revisions for instance due to
significant patch body change. How are you going to handle that? Just
make the tags picking up optional? Perhaps making the tags handling
interactive with printing a text/context around the tag?

-Serge(y)

> 
> -K