Received-SPF: pass (google.com: domain of linux-kernel+bounces-6033-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 19 Dec 2023 17:10:02 -0500
From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>, 
	xiongxin <xiongxin@kylinos.cn>, Andy Shevchenko <andy@kernel.org>, hoan@os.amperecomputing.com, 
	linus.walleij@linaro.org, brgl@bgdev.pl, linux-gpio@vger.kernel.org, 
	linux-kernel@vger.kernel.org, stable@kernel.org, Riwen Lu <luriwen@kylinos.cn>
Subject: Re: [PATCH v3] gpio: dwapb: mask/unmask IRQ when disable/enale it
Message-ID: <20231219-fluffy-labrador-of-inquire-fafb28@lemur>
References: <20231219013751.20386-1-xiongxin@kylinos.cn>
 <7zdg5ujizncarxvdyahnusojiq44rzxx2zybqj4kzsonzr27gq@fm5wj7npqsk3>
 <CAHp75VceVAZYTNsJaYYRN+EMExFZSQARsJowd-CvDLRtuOPKSg@mail.gmail.com>
 <euhbczna4hk5sacb23i2xwqh2jewlek7cfceprfslpsiijhwk3@3d6vtybmgag5>
 <20231219-whispering-independent-bonobo-d14a04@lemur>
 <yko4bwzrnlvncljpgyxlsvioqeyf3zxb255qexlawooqjxvedn@dkr7i7fame3n>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <yko4bwzrnlvncljpgyxlsvioqeyf3zxb255qexlawooqjxvedn@dkr7i7fame3n>

On Wed, Dec 20, 2023 at 12:58:16AM +0300, Serge Semin wrote:
> > It's a known limitation at this time, but it will be improved in the near
> > future and we'll be able to grab trailers across revisions as long as the
> > patch-id remains the same.
> 
> Ok. Thanks for the note.
> 
> I am sure you are well aware of that, but in some cases the tags are
> intentionally omitted in the new patch revisions for instance due to
> significant patch body change. How are you going to handle that?

The patch-id (generated with `git patch-id --stable`), would change if the
patch body is changed (except things like whitespace). This is exactly the
behaviour that we need -- if a tag was sent to a different version of the
patch, then we no longer want to retrieve it.

> Just make the tags picking up optional? Perhaps making the tags handling
> interactive with printing a text/context around the tag?

We may indeed be able to do --interactive for some of the commands in the
future, but the goal is to automate things away.

-K