Received: by 2002:a05:7412:d008:b0:f9:6acb:47ec with SMTP id bd8csp224348rdb; Tue, 19 Dec 2023 14:52:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IGDJ0shbJ8vsmvmHmm9VY/osHxWk8gFetRof5NuR08iJNbhuYPNP7vpY5Aw7rKnwnZemO+m X-Received: by 2002:a05:6870:c18e:b0:204:a85:2580 with SMTP id h14-20020a056870c18e00b002040a852580mr66404oad.34.1703026373789; Tue, 19 Dec 2023 14:52:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703026373; cv=none; d=google.com; s=arc-20160816; b=zgalRgY1JtznQJpkneJhupLUHpC2Cbajx4b85owOZ/AYstTE7V50y9VKpshmx3F+Pz xR4ddmfZzQACDk3m+rknZ3MmRJX9Nv8dPbJtByNn4JU+YMxuBi+rZeA37zts5E61e7AK L0RSqzBM+Lkbx4PesxqI3+xjSL0ffOVszY10DUxR/tURWZZykCH8/uUX5teSQr62aWLb ZTkWRdUBwUTJzwHC1vc3FtGacZ3ULf4BIi8lOQ23qqADK+9mHgh59tSNiHJ8p6LMebbP Ln2qaIU1tLnm9ELjLYvcdO9VnNeB5qqv48IObU6Q9CYMTepkHLXUPKgt6cF7st45D81l I58Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=MAwg2J+eab2tticeU56XVYHeeqgeTkCX8ApI/spLR+o=; fh=TA75Cdh4va7ST6k+VTr9BJ5Kl9bKZJj9tlVUAJvbumY=; b=RXj10//vb1fpbKUcXn19NZVbi6/FGA32EDlMpyrjU0vHowuJ6KTqk4Kwyei6mk5qsj ecJBphjUz4RmE4ZI4rip4DN5nM0v+naIgMiy+6o3VElS3FTix7jFiyr2lm4/atVVPQ/6 Oq9AccjPI+/TMiWaYDzKw8FoBg98UU6CkugqFpwMhUg7fa9NQ364CRKSHtKY67jK+Qe0 DoQsaJxC3UsMAyRF6Os8d+/fyt19SXKWSEuguxspTgGTrb5G7GR/JEVfu7BA6/vk7Ga+ 2jqxrxqv5X4uD7w0IsdTPc6VtdeZUUifeUQQ5vONhhMcYRy3Ik1wQhIeowwS9DO8Qo4b kWRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=YGxadkup; spf=pass (google.com: domain of linux-kernel+bounces-6071-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6071-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id n8-20020a654508000000b005c625d44bd5si20275781pgq.281.2023.12.19.14.52.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 14:52:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-6071-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=YGxadkup; spf=pass (google.com: domain of linux-kernel+bounces-6071-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6071-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 58E12287F2F for ; Tue, 19 Dec 2023 22:52:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BB15B40BF7; Tue, 19 Dec 2023 22:52:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="YGxadkup" X-Original-To: linux-kernel@vger.kernel.org Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC96940BEC; Tue, 19 Dec 2023 22:52:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MAwg2J+eab2tticeU56XVYHeeqgeTkCX8ApI/spLR+o=; b=YGxadkupXV7DDfETbrj9rF0W8B xk9uC8o7meOixhvXtiPgfToiDkMsrxYnvumZaKOaMMlTdHkmpxY5wy+3T8p7RyiaMdSeOd7mb/XrG kvzgjcXk+mq/O/37+rMOaA0w5+33KWR8zKxocebBVam6BGiTNaSq7mdMybPuPisZjx/8of9U+n4ZL VvE30UdYIyg+it8RYSrs2S5RW3TcJ35R0UvJsLnFnJ5KlSos2ZEcb5CcdzrAsla0X/l1B8KUQyrfz PtWohRH4+LskpvatCBt3SGEoBtPy0PT706QrtrOsK61pydy5vOP8nZN0puaoe6sej/cKQYIjxVLxH w2fechRA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rFiwz-003PwK-M6; Tue, 19 Dec 2023 22:52:33 +0000 Date: Tue, 19 Dec 2023 22:52:33 +0000 From: Matthew Wilcox To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Subject: Re: [PATCH 15/50] kernel/numa.c: Move logging out of numa.h Message-ID: References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216032651.3553101-1-kent.overstreet@linux.dev> <20231216032651.3553101-5-kent.overstreet@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231216032651.3553101-5-kent.overstreet@linux.dev> On Fri, Dec 15, 2023 at 10:26:14PM -0500, Kent Overstreet wrote: > diff --git a/kernel/numa.c b/kernel/numa.c > new file mode 100644 > index 000000000000..c24c72f45989 > --- /dev/null > +++ b/kernel/numa.c Should this be a new file or would these functions fit better in, eg, mempolicy.c which is already built only if CONFIG_NUMA?