Received-SPF: pass (google.com: domain of linux-kernel+bounces-6209-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <6a308db3-d487-413a-9ee9-9206463d6308@nvidia.com>
Date: Wed, 20 Dec 2023 02:50:34 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 01/16] nvmet: report ioccsz and iorcsz for disc ctrl
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>, Daniel Wagner <dwagner@suse.de>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
 Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
 James Smart <james.smart@broadcom.com>, Hannes Reinecke <hare@suse.de>
References: <20231218153105.12717-1-dwagner@suse.de>
 <20231218153105.12717-2-dwagner@suse.de> <20231219042717.GB30580@lst.de>
From: Max Gurtovoy <mgurtovoy@nvidia.com>
In-Reply-To: <20231219042717.GB30580@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Vk5PMUxwd0hDa3ZwcWx1OFh0WlBZQnR3VlpYMHY0R2YydFBHR3F4dWp3RzFm?=
 =?utf-8?B?UU8raXcyQUFyWHpVY1lLTWl5ekVlbGcvMzNtbk1UOGRWM29ncFY4UThLdEc1?=
 =?utf-8?B?Zk5MRXhqVHZtK1FuL3E0MTFRdlFxdU5nNTNwamV5UjMyNkUwZXRkeGNXNDBt?=
 =?utf-8?B?MEc3SjlKRWxpZlFyWVZkNHBRTmJKU3RjMzVjSEdJUndkeVhoSHdFZDd3NXpF?=
 =?utf-8?B?WlVVMVhOb3pvZng3UG50dFR5b0hxT0NnbDdrRUtBY1dwbVo1YTlJYlRNbmlS?=
 =?utf-8?B?VFA2Q3FzYXkyc1ppSHlVbExORDhjV0Q5TFFCMmp1cmtjUFZwanVNRTVKYUho?=
 =?utf-8?B?SEZnek9nMXRnK2tpbUpaQTYzSU41aGUzelc1Smc4WDQvQjh6V1dRemczVnQz?=
 =?utf-8?B?Q3EyYVJ4NTJUNTZIWW5hb205VDc0Wmx2QUE1elNuSC9ZNUpJYXlYbFhMV3dG?=
 =?utf-8?B?ejR0cjV0dVZCZVFNb3RydDZjVTRPcGlhSFoyWTYxdWxjYmVDRC9qY1pBQU9u?=
 =?utf-8?B?SGowSzJKZ2grUk5hY3MwNzN5aGdTV3ZIdWt4NVJ5RnVHdUFmRDFRTnVNU0hz?=
 =?utf-8?B?MHNOMG56bHRWTTk2OE93YUhDUUV4R1JiLzlyWnlqbnJhVUxhS08wRkNsbWNj?=
 =?utf-8?B?QkNlK29aNEQ1dnByOVk1UERuMmJhM2c2a1NqZ3gwTlFLbDhadFVESkpDbWs0?=
 =?utf-8?B?bTltSGU4bUpLbGN0eGtQZXBnbFJvbmEwc25rN2Ruc2Jrek5Ccmd1Q1JnTTBI?=
 =?utf-8?B?dW9NbHBWMWY5L1Q3MFVWVFkxejJXOGZBZkhISEN1aW90NWlVZjZYVGkzd1Qz?=
 =?utf-8?B?MEVNU2E0RlZSWUJqUGdONkdMSld3UW1JMSszMU5xQmh4aGFXY2VoQjRwaUpW?=
 =?utf-8?B?dFQ2NEc3czhiVjgzclVGRmM2ckU2TW9xVE9pRlZTamo1djlGdTB6cGZFdUpm?=
 =?utf-8?B?Wnd2WlRDN05JQ1NwRm9EbDQ1ZU5pYWsxYmtEVTRKekt2Mkx2cHF5QkVDOUl4?=
 =?utf-8?B?MFpYanNmSWRTZ2JUNGVvcnR0TjZQQjZ2S295Zk0rTzVueGVwK0l1YlBRcWcy?=
 =?utf-8?B?MXFJMlNGdVJPakZ6cHU1bzZ6NFMra1B1cm9ycTJoZEhwTURaTEhjYWxoeE5O?=
 =?utf-8?B?Z0FxNDdQZ3RIaUdnUUxCazFZTko5bnJQdHZZUEFSdSt4OWpXamdYUzJ2bVJB?=
 =?utf-8?B?S3pxcHYxL3h0cE1GQkRMc3NnbDB3SHFPVG9pZXBteTFsQmFwVVhPU3ZwcU9C?=
 =?utf-8?B?eFJjUEZQelRjajBoZnhJbG5oQnhYNGJoYVZlZkhvb1hHcng5UGx2VDRQZFgr?=
 =?utf-8?B?eFI3YkdPVmlKMERNRTh1WnpUSUxuQmZoTVlyR1R3TkFoL1RwOWhwRzNpVEJN?=
 =?utf-8?B?Tnc0NHVBdUxjSVFlbUU5UDZESjJkNXVaeDJGNE5JaEVvYlI5TDlRa2Q0STc0?=
 =?utf-8?B?andqdjZqMmhEYjFlTHdSMGxJOW5HRzVISzM3T0FJZFhlSXVHSVV3TGIzTEcr?=
 =?utf-8?B?NVhIOHBHWjhpTFowNmdsR1dteDNtanp1SmhkNHpYMm4vNWtXNkozZk4vV3di?=
 =?utf-8?B?b21ndVBGNkNQaDJRUnJBZzlFNE9KckF6R1lqMkVxWUFyb3ZZRHhUTnUxT1JZ?=
 =?utf-8?B?NHF4M3ZjdTV3Ri92MnJQL3NPb1dMdUFaOUZJTW9aZk5vellUSkdiYnBNeVhI?=
 =?utf-8?B?V3NpZEpYd3RMVUxMWDdlc0I5dEplZHVPRUNna2kyY3VWZkNmVUh0WTlvcTJT?=
 =?utf-8?B?MDVzUVZWUHNoRkgzdXhJVXB1NU1iaXh5N2JSNmU0UkN0TVFCbVJ1bjUzOFF5?=
 =?utf-8?B?a2IvYWlDYzZyNG54bS9rUFNyNnpxQ2ZPSDRQK2ZPRjIrS3F0YzFiS0hlV0Vx?=
 =?utf-8?B?Z1YyUWhCQnRlc1BnNndreWhDLzdSdklsUk0vd1JuVFQwVThVNHpwRTdmNUpu?=
 =?utf-8?B?elpLd3lHTVFlWE1HRnVaM21LYlI4OEkzVDRUL3Z4RjA2R2NTeXRWTU5iTndu?=
 =?utf-8?B?WjFKZVJja21GS0UwRWFsWHZhMWEvUmFTcTZlL3BYNU45MWJyVkpwaSt1MzlQ?=
 =?utf-8?B?K3dUMXl1Mi92bk9JZDJwaEI3eTJyZU5pejdZNWtsalcySDFXWW5ackRTS3B3?=
 =?utf-8?B?RTNOSFJUeDkxbXAybU1GajBoOStFRTZ6Q05Fc3VvNkdwT2lvZkxyYUcwVlBn?=
 =?utf-8?B?bGc9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3eeb3f2-73b0-41d1-4605-08dc00f5b090
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5040.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 00:50:41.1624
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9cikHssyZu7Mj8jQ9iugsnXRnlf6uNWKx/VXkSqr+mKtkGPDlUCHe1IYeaK0VX3PeHm4V+nuHHcl1i6OphOLCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7693


On 19/12/2023 6:27, Christoph Hellwig wrote:
> On Mon, Dec 18, 2023 at 04:30:49PM +0100, Daniel Wagner wrote:
>> +	/*
>> +	 * Max command capsule size is sqe + in-capsule data size.
>> +	 * Disable in-capsule data for Metadata capable controllers.
> 
> A why on the disable would be useful here - the fact that it is disabled
> is pretty obvious from the code.
> 

We have another thread on this patch that I think is wrong since the 
discovery controller shouldn't set these values according to the spec. 
It is explicitly say that ioccsz and iorcsz are reserved for discovery 
controllers.

I've sent a proposal to fix the initiator/host code.