Received-SPF: pass (google.com: domain of linux-kernel+bounces-6224-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <CAMQnb4O15c=JC-zkCJD0U9GWwWko+Hez1iU7+cc3vhNSG86p9w@mail.gmail.com>
 <20231218012746.24442-1-hongyu.jin.cn@gmail.com> <20231218012746.24442-5-hongyu.jin.cn@gmail.com>
 <20231219224821.GC38652@quark.localdomain>
In-Reply-To: <20231219224821.GC38652@quark.localdomain>
From: Hongyu Jin <hongyu.jin.cn@gmail.com>
Date: Wed, 20 Dec 2023 09:14:56 +0800
Message-ID: <CAMQnb4N=5jf5Hsq1Qtb-9dsPzB29-xEV3Wj_Fi1WgCuW_pv2pg@mail.gmail.com>
Subject: Re: [PATCH v5 RESEND 4/5] dm verity: Fix I/O priority lost when read
 FEC and hash
To: Eric Biggers <ebiggers@kernel.org>
Cc: agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com, axboe@kernel.dk, 
	zhiguo.niu@unisoc.com, ke.wang@unisoc.com, yibin.ding@unisoc.com, 
	hongyu.jin@unisoc.com, linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev, 
	linux-block@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Eric Biggers <ebiggers@kernel.org> =E4=BA=8E2023=E5=B9=B412=E6=9C=8820=E6=
=97=A5=E5=91=A8=E4=B8=89 06:48=E5=86=99=E9=81=93=EF=BC=9A
>
> On Mon, Dec 18, 2023 at 09:27:45AM +0800, Hongyu Jin wrote:
> > From: Hongyu Jin <hongyu.jin@unisoc.com>
> >
> > To fix this problem, when read FEC and hash from disk, I/O priority are
> > inconsistent with data block and blocked by other I/O with low I/O
> > priority.
> >
> > Make I/O for FEC and hash has same I/O priority with original data I/O.
>
> "To fix this problem" is supposed to be in the second paragraph, not the =
first,
> right?
Yes, The verification and error correction process takes effect after
obtaining the data.
>
> > @@ -728,6 +730,7 @@ static void verity_submit_prefetch(struct dm_verity=
 *v, struct dm_verity_io *io)
> >       sector_t block =3D io->block;
> >       unsigned int n_blocks =3D io->n_blocks;
> >       struct dm_verity_prefetch_work *pw;
> > +     struct bio *bio =3D dm_bio_from_per_bio_data(io, v->ti->per_io_da=
ta_size);
> >
> >       if (v->validated_blocks) {
> >               while (n_blocks && test_bit(block, v->validated_blocks)) =
{
>
> The caller has the bio pointer already, so maybe just add it as a paramet=
er to
> verity_submit_prefetch()?
>
> - Eric
ok, I will change it.