Received-SPF: pass (google.com: domain of linux-kernel+bounces-6232-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
To: <conor@kernel.org>
CC: <conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
	<jisheng.teoh@starfivetech.com>, <krzysztof.kozlowski+dt@linaro.org>,
	<krzysztof.kozlowski@linaro.org>, <leyfoon.tan@starfivetech.com>,
	<linux-kernel@vger.kernel.org>, <linux-watchdog@vger.kernel.org>,
	<linux@roeck-us.net>, <robh+dt@kernel.org>, <samin.guo@starfivetech.com>,
	<wim@linux-watchdog.org>, <xingyu.wu@starfivetech.com>
Subject: Re: [PATCH v4 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100
Date: Wed, 20 Dec 2023 09:23:45 +0800
Message-ID: <20231220012345.17791-1-jisheng.teoh@starfivetech.com>
In-Reply-To: <20231219-hankering-console-7de049490dab@spud>
References: <20231219-hankering-console-7de049490dab@spud>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Tue, 19 Dec 2023 15:43:07 +0000
Conor Dooley <conor@kernel.org> wrote:

> On Mon, Dec 18, 2023 at 11:37:38PM +0800, Ji Sheng Teoh wrote:
> > On Mon, 18 Dec 2023 15:41:37 +0100
> > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> >  =20
> > > On 18/12/2023 15:27, Ji Sheng Teoh wrote: =20
> > > >>
> > > >> I have real doubts that you ever tested your entire solution
> > > >> with this binding. Where is the DTS?
> > > >>   =20
> > > >=20
> > > > Currently, the DTS is still in internal and yet to upstream as
> > > > it depends on [1].   =20
> > >=20
> > > Yeah, so you send untested code which cannot work or pass tests.
> > > If you do not test your code, we need to be able to at least
> > > verify it, so send your DTS. Otherwise I cannot trust that this
> > > works at all.=20
> > Will submit it with DTS once things have cleared up.
> > Thanks for the comment.  =20
>=20
> [1] is not going to applied for a while since the SoC doesn't actually
> exist yet and is pre-tapeout on an FPGA. I would just send the dts
> patch adding the watchdog alongside the series, or else you'll be
> waiting for quite a while. Or even link to the node on github or
> whatever.
>=20

Ok, will add the watchdog dts alongside this series and mention its
dependency on [1]. Thanks.