Received-SPF: pass (google.com: domain of linux-kernel+bounces-6273-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Peng Fan <peng.fan@nxp.com>
To: Marco Felsch <m.felsch@pengutronix.de>, "Peng Fan (OSS)"
	<peng.fan@oss.nxp.com>
CC: Sudeep Holla <sudeep.holla@arm.com>, Cristian Marussi
	<cristian.marussi@arm.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
	<conor+dt@kernel.org>, Oleksii Moisieiev <oleksii_moisieiev@epam.com>, Linus
 Walleij <linus.walleij@linaro.org>, Shawn Guo <shawnguo@kernel.org>, Sascha
 Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team
	<kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, dl-linux-imx
	<linux-imx@nxp.com>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-gpio@vger.kernel.org"
	<linux-gpio@vger.kernel.org>
Subject: RE: [PATCH 4/7] dt-bindings: firmware: arm,scmi: support pinctrl
 protocol
Thread-Topic: [PATCH 4/7] dt-bindings: firmware: arm,scmi: support pinctrl
 protocol
Thread-Index: AQHaL00vUsuXdEJTYUWYoB3T3FLKXbCxBK8AgABsGdA=
Date: Wed, 20 Dec 2023 01:58:09 +0000
Message-ID:
 <DU0PR04MB94170BCA413C2FD48A397B538896A@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20231215-pinctrl-scmi-v1-0-0fe35e4611f7@nxp.com>
 <20231215-pinctrl-scmi-v1-4-0fe35e4611f7@nxp.com>
 <20231219192912.yulmczvqbuh4jizg@pengutronix.de>
In-Reply-To: <20231219192912.yulmczvqbuh4jizg@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?nYJRLd3phBkj0e0RGVdechtefdvmRCB3vqJbbwPdbGVpYrMOSsCw3iEOPMRX?=
 =?us-ascii?Q?0lmaiLwN+O7z3cwOWea0P5aRlrg+tvt77dupxUMBZvgPeI92T0BWenJzgucD?=
 =?us-ascii?Q?IMB9WZydv7+qVQO514NI7vINMCN2OsnjeKr6r99Ruz4RBUq1ct23mLPSOWnL?=
 =?us-ascii?Q?DOfdrndk7cNrKsagUdVQkeCA3qlFnaS4q8HYubBQG+ZyfHgSHWUFBJ4p+kRB?=
 =?us-ascii?Q?K7niBmtybVu0ZmXebhUbFEt7yr2NtakYjt3ppM2hIGsq1j3VPTLzI3oBCdPb?=
 =?us-ascii?Q?o+8SbYTinfN/YWcY/ENH59v1K5dsRkBH5BMLHpza74w7RUjFVjIWWzrc05RF?=
 =?us-ascii?Q?vpUPX2x5WhXAEdjiBzoUY44kkUEONMGCXvWyI/qIRYDe2z+p0l/eQGj19Hkk?=
 =?us-ascii?Q?1ZqnKObxs0fQCaksHIz9XvTAeWabwKpYKoQyEW33E5p0x4p7QMh6r1hsXajj?=
 =?us-ascii?Q?OqhdqQxvtFI2ovtykIfuUkTHknBdcWpYQgg5V+Vswx974QUKvVN4VLX7R4Cm?=
 =?us-ascii?Q?RoYz5mvd17uH3ydThXl6k9diQ4trnHN+Tcw6BdFDl1pWH046gozZFg5tQPwx?=
 =?us-ascii?Q?605wd6bsSnYNlSPRjdfB8ZsylOBuRVqZmiMUN2v7ZPkMm31MWdTHdtyyFsp5?=
 =?us-ascii?Q?rXtLdAlY1nz6q1v5Zng2N3/veEZMjBG9zX8tvhqpgJOsE/L3lthCpRynr3nX?=
 =?us-ascii?Q?zPG0ZSUSGs6WZtJT2QDYM1020YicMpf2WXrIAbpV2WZTK8rdWj6cVRSyROzA?=
 =?us-ascii?Q?HdiL78ftVPbmfMZkWt85Vr+afvnZ3i+eSAR2ddqPaX2MoMygNj+VxI/Z0cBn?=
 =?us-ascii?Q?hAPzSdNEf/ebitmtvxcsBZjv08NzNDRlQFezOZvGnk60FgOoPSOMB5kJZ0ZO?=
 =?us-ascii?Q?ZqsmhegvxPvyt7xF0WDE/OutO18mvdtxlGGYaa0GtZc/WJoj8HBpqbMeh3iW?=
 =?us-ascii?Q?9wOBYPizX6xuPY0xoTJjq/n87jOe8oGcyv3ut/5/b2sHh6x8a9rDLXY0fEIX?=
 =?us-ascii?Q?SU6DjQ6g342gONJ5VcIM29T7ESdELOAcpiuzeJk1qwt9PxXpxdzNxOYrjBkp?=
 =?us-ascii?Q?vfQuF75m58cgZ3a2Wp+qOKnpUev9VlBWHWACs+Eh1m4nz0GQX63nVSNyZQxl?=
 =?us-ascii?Q?rxL+oWvyf50bNFf4/Sq5KA18ggAT8bL90entRctQ9D9xYHrmrHgHj0t9tq6V?=
 =?us-ascii?Q?r8F4XqlCYyycH/MO1tE6aw7kwncU8AXb4ki+IpOXIOd+KXUouTSGY0XI4ey3?=
 =?us-ascii?Q?vSSDUVj/9A2iiqvf2MbfWtt/Le6N4xVjNU2ovHHHXCWvZOJiY9sg+RcPW2A2?=
 =?us-ascii?Q?SKPsLsvvu4innQdGhbSbFWh4AlULBPE6qOrnZv4RLvVNBv/Gc6iJBV2Jjnfg?=
 =?us-ascii?Q?fKq5oe111Gzsd0VZNXZdVjIM91jNXghdzcZh3K8EvYI+mBOQOAMxcYUUST64?=
 =?us-ascii?Q?41AFPC3vRe2af7TCarrWPE6tQb49hMHxBQbTESIXxWyx2KVGmyk4SFDmIkVm?=
 =?us-ascii?Q?QYED9jmdKgxs87uk6KUr3ZicsSB55FFcBpp8rl0fa6NtK/jgYPaLl96QnEp7?=
 =?us-ascii?Q?Wwccr8hWjrYuYjhTujU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2947aa0b-a5c9-4cab-ed24-08dc00ff1dda
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2023 01:58:09.7224
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SyzRSk05k0ZVK7rgteYnMV5ATTj2bF41Oj6zGJhz0HO6K/k7+0/MQjyZws3sfC6mzFHG2P2YiAk8ncLPfTflEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9298

> Subject: Re: [PATCH 4/7] dt-bindings: firmware: arm,scmi: support pinctrl
> protocol
>=20
> Hi Peng,
>=20
> On 23-12-15, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Add SCMI v3.2 pinctrl protocol bindings and example.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  .../devicetree/bindings/firmware/arm,scmi.yaml     | 99
> ++++++++++++++++++++++
> >  1 file changed, 99 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > index 4591523b51a0..bfd2b6a89979 100644
> > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > @@ -247,6 +247,85 @@ properties:
> >        reg:
> >          const: 0x18
> >
> > +  protocol@19:
>=20
> ...
>=20
> > @@ -401,6 +480,26 @@ examples:
> >              scmi_powercap: protocol@18 {
> >                  reg =3D <0x18>;
> >              };
> > +
> > +            scmi_pinctrl: protocol@19 {
> > +                reg =3D <0x19>;
> > +                #pinctrl-cells =3D <0>;
> > +
> > +                i2c2-pins {
> > +                    groups =3D "i2c2_a", "i2c2_b";
> > +                    function =3D "i2c2";
> > +                };
> > +
> > +                mdio-pins {
> > +                    groups =3D "avb_mdio";
> > +                    drive-strength =3D <24>;
> > +                };
> > +
> > +                keys_pins: keys-pins {
> > +                    pins =3D "GP_5_17", "GP_5_20", "GP_5_22", "GP_2_1"=
;
> > +                    bias-pull-up;
> > +                };
> > +            };
>=20
> This example is different to the one you mentioned within the cover-lette=
r. I
> didn't checked all patches just want to ask which API will be implemented=
 by
> this patchset?

I kept this change since it was tested by Oleksii, but anyway i.MX not use =
these.

The API, I suppose you are asking about this?
static const struct pinctrl_ops pinctrl_scmi_pinctrl_ops =3D {             =
                          =20
        .get_groups_count =3D pinctrl_scmi_get_groups_count,               =
                          =20
        .get_group_name =3D pinctrl_scmi_get_group_name,                   =
                          =20
        .get_group_pins =3D pinctrl_scmi_get_group_pins,                   =
                          =20
#ifdef CONFIG_OF                                                           =
                        =20
        .dt_node_to_map =3D pinconf_generic_dt_node_to_map_all,            =
                          =20
        .dt_free_map =3D pinconf_generic_dt_free_map,                      =
                          =20
#endif                                                                     =
                        =20
};

static const struct pinctrl_ops pinctrl_scmi_imx_pinctrl_ops =3D {         =
                          =20
        .get_groups_count =3D pinctrl_scmi_get_groups_count,               =
                          =20
        .get_group_name =3D pinctrl_scmi_get_group_name,                   =
                          =20
        .get_group_pins =3D pinctrl_scmi_get_group_pins,                   =
                          =20
#ifdef CONFIG_OF                                                           =
                        =20
        .dt_node_to_map =3D pinctrl_scmi_imx_dt_node_to_map,               =
                          =20
        .dt_free_map =3D pinconf_generic_dt_free_map,                      =
                          =20
#endif                                                                     =
                        =20
};

Thanks,
Peng.

>=20
> Regards,
>   Marco
>=20
> >          };
> >      };
> >
> >
> > --
> > 2.37.1
> >
> >
> >