Received-SPF: pass (google.com: domain of linux-kernel+bounces-6281-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20231129110853.94344-1-lukasz.luba@arm.com> <20231129110853.94344-24-lukasz.luba@arm.com>
 <CAB8ipk_Zx5NtSpNXHsAqpZSq2yVHGAni5sN=ot5Lkc0jGZxoxA@mail.gmail.com> <cbb2ae63-eb51-451a-b202-2a1c447a93e9@arm.com>
In-Reply-To: <cbb2ae63-eb51-451a-b202-2a1c447a93e9@arm.com>
From: Xuewen Yan <xuewen.yan94@gmail.com>
Date: Wed, 20 Dec 2023 10:08:20 +0800
Message-ID: <CAB8ipk8jsgUufoMB+z8=YQyOXyia91L-QGCTNuFeKngVBx5ZWA@mail.gmail.com>
Subject: Re: [PATCH v5 23/23] Documentation: EM: Update with runtime
 modification design
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rafael@kernel.org, 
	dietmar.eggemann@arm.com, rui.zhang@intel.com, amit.kucheria@verdurent.com, 
	amit.kachhap@gmail.com, daniel.lezcano@linaro.org, viresh.kumar@linaro.org, 
	len.brown@intel.com, pavel@ucw.cz, mhiramat@kernel.org, qyousef@layalina.io, 
	wvw@google.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 19, 2023 at 5:31=E2=80=AFPM Lukasz Luba <lukasz.luba@arm.com> w=
rote:
>
>
>
> On 12/19/23 06:22, Xuewen Yan wrote:
> > Hi Lukasz,
> >
> > On Wed, Nov 29, 2023 at 7:11=E2=80=AFPM Lukasz Luba <lukasz.luba@arm.co=
m> wrote:
>
> [snip]
>
> >> +
> >> +  -> drivers/soc/example/example_em_mod.c
> >> +
> >> +  01   static void foo_get_new_em(struct device *dev)
> >
> > Because now some drivers use the dev_pm_opp_of_register_em() to
> > register energy model,
> > and maybe we can add a new function to update the energy model using
> > "EM_SET_ACTIVE_POWER_CB(em_cb, cb)"
> > instead of letting users set power again?
> >
>
> There are different usage of this EM feature:
> 1. Adjust power values after boot is finish and e.g. ASV in Exynos
>     has adjusted new voltage values in the OPP framework. It's
>     due to chip binning. I have described that in conversation
>     below patch 22/23. I'm going to send a patch for that
>     platform and OPP fwk later as a follow up to this series.

I understand what you mean, what I mean is that if we can provide an
interface for changing EM of opp fwk, it will be more friendly for
those users who use opp, because then they don't have to calculate the
new EM by themselves, but only need After updating the voltage of opp,
just call this interface directly.

BR
---
xuewen

> 2. Change the EM power values after long gaming, when the GPU
>     heats up the SoC heavily and CPUs start increase the leakage
> 3. Change the EM for long running heavy apps, e.g. video conference app,
>     which is using camera w/ image AI and filters (so some heavy stuff)
> 4. any other optimization that vendor/OEM like to have for