Received-SPF: pass (google.com: domain of linux-kernel+bounces-6313-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 20 Dec 2023 14:05:29 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>, Jan Kara
 <jack@suse.cz>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: manual merge of the vfs tree with the f2fs tree
Message-ID: <20231220140529.3979085c@canb.auug.org.au>
In-Reply-To: <20231220013402.GW1674809@ZenIV>
References: <20231220104734.0979a9f8@canb.auug.org.au>
	<20231220111325.5dd55e47@canb.auug.org.au>
	<20231220013402.GW1674809@ZenIV>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/9WpnFLRRp/vj_YOIQc8WJSu";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/9WpnFLRRp/vj_YOIQc8WJSu
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Al,

On Wed, 20 Dec 2023 01:34:02 +0000 Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> My suggested resolution had been wrong, actually - the way it's written,
> link count drop should be conditional on old_is_dir, cross-directory or
> not.
>=20
> I think the right solution is
> 	if (old_dir_entry)
> 		f2fs_set_link(old_inode, old_dir_entry, old_dir_page, new_dir);
>         if (old_is_dir)
> 		f2fs_i_links_write(old_dir, false);

Ok, I will fix it up.

--=20
Cheers,
Stephen Rothwell

--Sig_/9WpnFLRRp/vj_YOIQc8WJSu
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmWCWfkACgkQAVBC80lX
0GxCcgf/THbisqsNRK587ORnaSG2shUwhcHuy9mujelIZUGF2GxQS+QFawAvpKOi
++IzRAZunWRNVn68nmLgPjIx22VfU2RpwlBIn62EVAG40JcVrUTEvoXXRycmoWl2
mSCHvikHQFvkbeIlS3s/60ashT0alDjlJpTeWWFBdzh2jzFynatZi9KF5sS2aAl0
NbIhPzs2Xa8y8Y0VvqLQ4AGhjoDWRpJVNHkxRRLPixH9k6wkp3QboNF2YcBhlbt+
qwYb8at3NWjGXl7oayxvFkKog/U6+L7OlwkW3MZyarH/RRfIHH6xkOgjLn1ajcSR
v3yr2PomZGCCOgjNsB3NNvRTrgxAdA==
=bnhO
-----END PGP SIGNATURE-----

--Sig_/9WpnFLRRp/vj_YOIQc8WJSu--