Received: by 2002:a05:7412:d008:b0:f9:6acb:47ec with SMTP id bd8csp329939rdb; Tue, 19 Dec 2023 19:49:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IElLQPp227cvZZedtbAqPGdjDAzv5qxqKlQ8126xIK9cxM+TeDzhiLEWUr8v5JwU0Kvlw4y X-Received: by 2002:a05:6e02:1bcb:b0:35d:61b4:e628 with SMTP id x11-20020a056e021bcb00b0035d61b4e628mr26649109ilv.60.1703044164601; Tue, 19 Dec 2023 19:49:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703044164; cv=none; d=google.com; s=arc-20160816; b=Jc+nLAorWUOyWDelteS9ETig4kKERNMhY7CG8q4XSjkj4GzyIWwil9Pvs4R+IuhRYz fdAFsLiKVUtpWXVu79br1Gr/fBx0gK8x29Lvg5hoR+ddWRAOjkv8IhuvrEnNAbFJS1Pw AfdZG5ess0rx+sRIEksne94nO1cl0jnxHmvN/I6UErV/onzZlrB6Sm0ZwHZrQB5G0Akr iCElNHWwLyATCG0MIa/PedLMQDpDBeO2+hzpfqmK/NN4U/G6I1EbTDOdlUA0TsK+5FCi WM6NSr2Srb2mV5QokUV9JjYrmB5Nty0Fzv7MMzQEqF2LuWc8x5w7KL34xWtEUX5Z2ULB ZqbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=jXT8y9tlblfV00CjChE7U+F283GXLav1fpyYasxi31k=; fh=uBBQxvr6uZhu0dMrEZcRojexdDFCB7vJ0ax5P/j8SQ4=; b=zTsEamjylmaCobWrQ1G8/2MP8mufYuXhSAk7uZj5KTJ9nivW6neQGi2hso9mwzS5Km CifEVkw/Yyty+P9T4jpt2ZTvQo64HJHqGMHV+hQ6xqW8nM3GjJE0XoakYAbWGa30fTNb yPhYS3ocKSV0Q0HbLg3N1dgmDKA2EKeVuhv4qXMsijYa3/BPXZfDWhRpDQ4arHtGmUg5 0+DpCFrGLw1yzcI0+Ct4uCAgKtcVrND1Wt/ArMNHYB3nchOj2YYenpqDJH7mpwi4AFca l2s6UQDEyfD5lmvUMNpFph6KPYqMCqJODxlWpEFQ0PGrYWJISWI886+dqqAdUyDOcD50 feEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=C155imKb; spf=pass (google.com: domain of linux-kernel+bounces-6331-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6331-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id k6-20020a170902760600b001d3a297f9e0si6288336pll.185.2023.12.19.19.49.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 19:49:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-6331-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=C155imKb; spf=pass (google.com: domain of linux-kernel+bounces-6331-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6331-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6AA38287F67 for ; Wed, 20 Dec 2023 03:49:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4164D1F92C; Wed, 20 Dec 2023 03:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="C155imKb" X-Original-To: linux-kernel@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ADD61EA78 for ; Wed, 20 Dec 2023 03:47:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703044041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jXT8y9tlblfV00CjChE7U+F283GXLav1fpyYasxi31k=; b=C155imKbgXEld49gV7jEG0Mhb17lCG8A+4+doNr8c5ceS/KVKyoFaNgJlJPx3ZjF5P6YmL zE4xUwx0RM5hZoObn0rlPZlsFtT63l8Y4itPauMTxGkD2l2BpvFEgslOMqICcE5gBmKCut wF/bOq9WkyjzydW4qPXFqUyGxOpijII= Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-497-uwevwIqlPKSNbPz5xE7ObA-1; Tue, 19 Dec 2023 22:47:19 -0500 X-MC-Unique: uwevwIqlPKSNbPz5xE7ObA-1 Received: by mail-oo1-f69.google.com with SMTP id 006d021491bc7-5909e52f0e6so5770113eaf.3 for ; Tue, 19 Dec 2023 19:47:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703044038; x=1703648838; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jXT8y9tlblfV00CjChE7U+F283GXLav1fpyYasxi31k=; b=l9ATo+yZyOk460FNPXZg/u81yNQjHS8CwTfjLCAcCs92zgDi+PXPmh7VqSrJ20ZIT1 0yy4fH5Llec58P81W7DQ6wfQVAv1tCCfQgstUpFa32kRfxEx6FPZKY3uxmE9hG+JyyWX p71MkcbAvtKLWGdOlMaOdwDeSAlaxgs/6vBYr7RqyG5zxeeMA6VmnHO854JWMR2DGVcu xXIQbfgHWWbzDU2QYrhYNpxcd+vJcYU4fk17H7tz3XNCWhb10nAI9O6jJWyr5jw1IWyM AL8NhlkyRMEMDxLhl5FdCzp2UBFEo9SfFasWLuKRtddhPZB2WBCo7IFdWb4MdPI5TJ3g 0YSA== X-Gm-Message-State: AOJu0Yw6QG3noVE/4SPtJi/ZFBeK5eol0aw3pciIVp25S5qfz5QlYlM7 5LNN0KIX5uJuRCrNTMDacvG5kfSJXhVK9vPz7UOYVuHZ3khJs9gwgvtwQjKZMWCR1FBJiQZwIXO 6UwWuT+HdGIbXM4WT2owRLdFMcDVJ/4q6Lqm7DIQD X-Received: by 2002:a05:6359:6a6:b0:170:406d:42e7 with SMTP id ei38-20020a05635906a600b00170406d42e7mr18126787rwb.39.1703044038229; Tue, 19 Dec 2023 19:47:18 -0800 (PST) X-Received: by 2002:a05:6359:6a6:b0:170:406d:42e7 with SMTP id ei38-20020a05635906a600b00170406d42e7mr18126783rwb.39.1703044037924; Tue, 19 Dec 2023 19:47:17 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231219180858.120898-1-dtatulea@nvidia.com> <20231219180858.120898-14-dtatulea@nvidia.com> In-Reply-To: <20231219180858.120898-14-dtatulea@nvidia.com> From: Jason Wang Date: Wed, 20 Dec 2023 11:47:05 +0800 Message-ID: Subject: Re: [PATCH vhost v4 13/15] vdpa/mlx5: Use vq suspend/resume during .set_map To: Dragos Tatulea Cc: "Michael S . Tsirkin" , Eugenio Perez Martin , Si-Wei Liu , Saeed Mahameed , Leon Romanovsky , virtualization@lists.linux-foundation.org, Gal Pressman , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Parav Pandit , Xuan Zhuo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Dec 20, 2023 at 2:10=E2=80=AFAM Dragos Tatulea wrote: > > Instead of tearing down and setting up vq resources, use vq > suspend/resume during .set_map to speed things up a bit. > > The vq mr is updated with the new mapping while the vqs are suspended. > > If the device doesn't support resumable vqs, do the old teardown and > setup dance. > > Reviewed-by: Gal Pressman > Acked-by: Eugenio P=C3=A9rez > Signed-off-by: Dragos Tatulea > --- Acked-by: Jason Wang Thanks