Received-SPF: pass (google.com: domain of linux-kernel+bounces-6338-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <000000000000e171200600d6d8bd@google.com> <000000000000847160060ce61580@google.com>
In-Reply-To: <000000000000847160060ce61580@google.com>
From: Amir Goldstein <amir73il@gmail.com>
Date: Wed, 20 Dec 2023 05:53:38 +0200
Message-ID: <CAOQ4uxiUoWO10a7UH5UweQ_1f+Fu+jSKPO66yAv80izyx9hBGg@mail.gmail.com>
Subject: Re: [syzbot] [overlayfs?] possible deadlock in seq_read_iter (2)
To: syzbot <syzbot+da4f9f61f96525c62cc7@syzkaller.appspotmail.com>
Cc: axboe@kernel.dk, hch@lst.de, linux-fsdevel@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-unionfs@vger.kernel.org, 
	miklos@szeredi.hu, rafael@kernel.org, syzkaller-bugs@googlegroups.com, 
	Christian Brauner <brauner@kernel.org>, David Howells <dhowells@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 20, 2023 at 2:30=E2=80=AFAM syzbot
<syzbot+da4f9f61f96525c62cc7@syzkaller.appspotmail.com> wrote:
>
> syzbot has bisected this issue to:
>
> commit 1e8c813b083c4122dfeaa5c3b11028331026e85d
> Author: Christoph Hellwig <hch@lst.de>
> Date:   Wed May 31 12:55:32 2023 +0000
>
>     PM: hibernate: don't use early_lookup_bdev in resume_store
>
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=3D14b15592e8=
0000
> start commit:   2cf4f94d8e86 Merge tag 'scsi-fixes' of git://git.kernel.o=
r..
> git tree:       upstream
> final oops:     https://syzkaller.appspot.com/x/report.txt?x=3D16b15592e8=
0000
> console output: https://syzkaller.appspot.com/x/log.txt?x=3D12b15592e8000=
0
> kernel config:  https://syzkaller.appspot.com/x/.config?x=3De5751b3a22261=
35d
> dashboard link: https://syzkaller.appspot.com/bug?extid=3Dda4f9f61f96525c=
62cc7
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=3D176a4f49e80=
000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=3D154aa8d6e8000=
0
>
> Reported-by: syzbot+da4f9f61f96525c62cc7@syzkaller.appspotmail.com
> Fixes: 1e8c813b083c ("PM: hibernate: don't use early_lookup_bdev in resum=
e_store")
>

I'm not sure this bisection is reliable, so I wouldn't use this Fixes tag.
The reproducer may be a little flakey.

Anyway, this is just one of many problems, real or false positives,
related to the unholy dependency which sendfile() creates between
locks on two different filesystems.

I think those changes that are queued for 6.8 are going so fix this class
of problems:

#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.=
rw

Thanks,
Amir.