Received-SPF: pass (google.com: domain of linux-kernel+bounces-6346-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <a7b0ef1eabd081f1c7c894e9b11de01678e85dee.1666293559.git.christophe.jaillet@wanadoo.fr>
 <72a89724-9dad-499a-a0ed-ad9d046d235d@wanadoo.fr>
In-Reply-To: <72a89724-9dad-499a-a0ed-ad9d046d235d@wanadoo.fr>
From: Jason Wang <jasowang@redhat.com>
Date: Wed, 20 Dec 2023 12:01:08 +0800
Message-ID: <CACGkMEtHy4GxGEQyL9EThK11wHTH=JS44gM+A41gsWSSg9e=QQ@mail.gmail.com>
Subject: Re: [PATCH] vdpa: Fix an error handling path in eni_vdpa_probe()
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Wu Zongyong <wuzongyong@linux.alibaba.com>, 
	Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org, 
	kernel-janitors@vger.kernel.org, virtualization@lists.linux-foundation.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 8, 2023 at 5:14=E2=80=AFAM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> Le 20/10/2022 =C3=A0 21:21, Christophe JAILLET a =C3=A9crit :
> > After a successful vp_legacy_probe() call, vp_legacy_remove() should be
> > called in the error handling path, as already done in the remove functi=
on.
> >
> > Add the missing call.
> >
> > Fixes: e85087beedca ("eni_vdpa: add vDPA driver for Alibaba ENI")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > ---
> >   drivers/vdpa/alibaba/eni_vdpa.c | 6 ++++--
> >   1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/vdpa/alibaba/eni_vdpa.c b/drivers/vdpa/alibaba/eni=
_vdpa.c
> > index 5a09a09cca70..cce3d1837104 100644
> > --- a/drivers/vdpa/alibaba/eni_vdpa.c
> > +++ b/drivers/vdpa/alibaba/eni_vdpa.c
> > @@ -497,7 +497,7 @@ static int eni_vdpa_probe(struct pci_dev *pdev, con=
st struct pci_device_id *id)
> >       if (!eni_vdpa->vring) {
> >               ret =3D -ENOMEM;
> >               ENI_ERR(pdev, "failed to allocate virtqueues\n");
> > -             goto err;
> > +             goto err_remove_vp_legacy;
> >       }
> >
> >       for (i =3D 0; i < eni_vdpa->queues; i++) {
> > @@ -509,11 +509,13 @@ static int eni_vdpa_probe(struct pci_dev *pdev, c=
onst struct pci_device_id *id)
> >       ret =3D vdpa_register_device(&eni_vdpa->vdpa, eni_vdpa->queues);
> >       if (ret) {
> >               ENI_ERR(pdev, "failed to register to vdpa bus\n");
> > -             goto err;
> > +             goto err_remove_vp_legacy;
> >       }
> >
> >       return 0;
> >
> > +err_remove_vp_legacy:
> > +     vp_legacy_remove(&eni_vdpa->ldev);
> >   err:
> >       put_device(&eni_vdpa->vdpa.dev);
> >       return ret;
>
> Polite reminder on a (very) old patch.

Acked-by: Jason Wang <jasowang@redhat.com>

Thanks

>
> CJ
>