Date: Sat, 08 Dec 2007 12:36:26 -0600
From: Robert Hancock <hancockr@shaw.ca>
Subject: Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)
In-reply-to: <4755D1E4.3020601@garzik.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
       ide <linux-ide@vger.kernel.org>, Tejun Heo <htejun@gmail.com>
Message-id: <475AE42A.9040400@shaw.ca>
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8; format=flowed
Content-transfer-encoding: 7bit
References: <47463534.9010100@shaw.ca> <4755D1E4.3020601@garzik.org>
User-Agent: Thunderbird 2.0.0.9 (Windows/20071031)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1195
Lines: 37

Jeff Garzik wrote:
> Robert Hancock wrote:
>> This fixes some problems with ATAPI devices on nForce4 controllers in 
>> ADMA mode
>> on systems with memory located above 4GB. We need to delay setting the 
>> 64-bit
>> DMA mask until the PRD table and padding buffer are allocated so that 
>> they don't
>> get allocated above 4GB and break legacy mode (which is needed for ATAPI
>> devices).
>>
>> Signed-off-by: Robert Hancock <hancockr@shaw.ca>
> 
> This is a bit nasty :/
> 
> I would consider setting the consistent DMA mask to 32-bit, and setting 
> the overall mask to 64-bit.
> 
> Seems like that would solve the problem?
> 
> Also, does this need to be rebased on top of what I just pushed upstream?
> 
>     Jeff

Jeff, ping on this one? This (or, one like it) really should make it 
into 2.6.24..

-- 
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/