Received: by 2002:a05:7412:d008:b0:f9:6acb:47ec with SMTP id bd8csp375886rdb; Tue, 19 Dec 2023 22:25:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IGaxjOy8OS6yiTZ/+Ek3ThnvuNFaSzwSlqKDQk2hlQbWYSywZwiV8PlrTfSysyvoH1bvaI9 X-Received: by 2002:a17:902:c952:b0:1d3:c58f:20b with SMTP id i18-20020a170902c95200b001d3c58f020bmr4431415pla.63.1703053510175; Tue, 19 Dec 2023 22:25:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703053510; cv=none; d=google.com; s=arc-20160816; b=iz6pF7orI4ahCK3Mn8xppKkoYKCl0s1KCVJ9BPJj0VSkrPIpT20nZuAviTSR3N/vwo lrKjqWA7ReTB8jtgPqenozm8kBejtSMwEy6zhiIjxtCBrMcHQFo/S1eYk7w1RmvaPiQx hEL1Rb0etm7X8OZM0a1UE/V7WaB/ZdR9yarheGUd9xv6aBnXAopbDT91dBmO6VA5GrbD 77iJbSAmq2dpODjdYszKr3vasmeuyBh9SYouuZszfeCvICoemUAoE+2kAJkvDo76oUNT dhBaAv/SaTACN3wM/z7X5g5BUhlIzutZl/pwN4lW7gSdqK0ZHY6uoLH65I9bMzSFGnlu 6eBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=IuiAEmcGJmfSWWjpjboMTQFiRf6jwqaKO2zb5j+l1M8=; fh=G/nmvQRHS+jNflUrY3HFjwqU6tmHX9TfV4HctXJtAy0=; b=H8ydlafhyj666dkYN5QwGqhqEyQOfHu/MBcNTu0Ww25GRuGgxqLQ05i3vklRzTPRa4 YzVVqcEIeoHsMvzaardnaDEKQguwkfdcw7kvNtHU9FsluoxrR+d5kleWPzv2quWPJpJb TYySvV/Mxhj9fy2GgvoGT9Ev8VPhDlCplS8ZD0H3z9DjCQQ+C0rKmn7HCcFnYTo9SnnH KDMoOsMmEILGvKnwA46vx80u2hfffweHlYiXVpEg4TrqnpLmraJUd4e0V0w6fjNgJqCD 78geKXtDBmtGkPx325U5H6h+j924NYdPDY+ZdQz3pK4AwO+8CMvb/WpXrLQi07kFl1zJ vijw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-6417-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6417-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=easystack.cn Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id i5-20020a170902c94500b001d352a49698si9888589pla.397.2023.12.19.22.25.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 22:25:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-6417-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-6417-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6417-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=easystack.cn Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 75318B25255 for ; Wed, 20 Dec 2023 06:25:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 992CD11C90; Wed, 20 Dec 2023 06:24:56 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from mail-m118196.ym.163.com (mail-m118196.ym.163.com [115.236.118.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D21BA11715 for ; Wed, 20 Dec 2023 06:24:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=easystack.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=easystack.cn Received: from fedora.. (unknown [211.103.144.18]) by smtp.qiye.163.com (Hmail) with ESMTPA id 7353926010E; Wed, 20 Dec 2023 13:57:40 +0800 (CST) From: fuqiang wang To: Baoquan He , Vivek Goyal , Dave Young , Yuntao Wang Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/2] kexec: fix potential cmem->ranges out of bounds Date: Wed, 20 Dec 2023 13:57:30 +0800 Message-ID: <20231220055733.100325-1-fuqiang.wang@easystack.cn> X-Mailer: git-send-email 2.42.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJQjdXWS1ZQUlXWQ8JGhUIEh9ZQVkaSxgfVkhLShoZSRkZTR1IGlUZERMWGhIXJBQOD1 lXWRgSC1lBWUlKSlVKS0hVSk9PVUpDWVdZFhoPEhUdFFlBWU9LSFVKSktISkNVSktLVUtZBg++ X-HM-Tid: 0a8c85cd1f610276kunm7353926010e X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6NBw6Qgw4VjE*SlEcDAwDCw4M MRYwC0NVSlVKTEtIS05KQ01JTEtCVTMWGhIXVR0OChIaFRxVDBoVHDseGggCCA8aGBBVGBVFWVdZ EgtZQVlJSkpVSktIVUpPT1VKQ1lXWQgBWUFJSk1ONwY+ This series tries to fix the potential cmem->ranges out of bounds. On the v1 version, there are still some issues that need to be discussed, as follows: 1) Whether we need have the cmem->ranges[] partly changed, or keep it unchanged when OOB happened. Previously discussed link:[1]. 2) Set cmem->max_nr_ranges in crash_setup_memmap_entries() to 1 or 2. Previously discussed link:[2]. 3) To enhance crash_setup_memmap_entries() readability, how to move code. Previously discussed link:[2]. v2: - Fix potential out of bounds in crash_setup_memmap_entries(). - Add a comment in fill_up_crash_elf_data() to explain why the array size do not need to be changed. v1: Link: https://lore.kernel.org/all/20231127025641.62210-1-fuqiang.wang@easystack.cn/ [1]: https://lore.kernel.org/all/ZXrY7QbXAlxydsSC@MiWiFi-R3L-srv/ [2]: https://lore.kernel.org/all/273284e8-7680-4f5f-8065-c5d780987e59@easystack.cn/ fuqiang wang (2): x86/kexec: Fix potential out of bounds in crash_setup_memmap_entries() kexec: Fix potential out of bounds in crash_exclude_mem_range() arch/x86/kernel/crash.c | 20 ++++++++++++++------ kernel/crash_core.c | 7 +++---- 2 files changed, 17 insertions(+), 10 deletions(-) -- 2.42.0