Received-SPF: pass (google.com: domain of linux-kernel+bounces-6423-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <9c955128-6867-4d0a-b2f1-eab692748315@infradead.org>
Date: Tue, 19 Dec 2023 22:32:48 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] soc/tegra: fuse: Define tegra194_soc_attr_group for
 Tegra241
Content-Language: en-US
To: Kartik <kkartik@nvidia.com>, sfr@canb.auug.org.au,
 thierry.reding@gmail.com, jonathanh@nvidia.com, frank.li@vivo.com,
 linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231220061013.120173-1-kkartik@nvidia.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20231220061013.120173-1-kkartik@nvidia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 12/19/23 22:10, Kartik wrote:
> Tegra241 SoC data uses tegra194_soc_attr_group, which is only defined
> if config CONFIG_ARCH_TEGRA_194_SOC or CONFIG_ARCH_TEGRA_234_SOC or
> both are enabled. This causes a build failure if both of these configs
> are disabled and CONFIG_ARCH_TEGRA_241_SOC is enabled.
> 
> Define tegra194_soc_attr_group if CONFIG_ARCH_TEGRA_241_SOC is enabled.
> 
> Signed-off-by: Kartik <kkartik@nvidia.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Thanks.

> ---
>  drivers/soc/tegra/fuse/fuse-tegra.c | 3 ++-
>  drivers/soc/tegra/fuse/fuse.h       | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c
> index 233b8e7bb41b..c34efa5bf44c 100644
> --- a/drivers/soc/tegra/fuse/fuse-tegra.c
> +++ b/drivers/soc/tegra/fuse/fuse-tegra.c
> @@ -407,7 +407,8 @@ const struct attribute_group tegra_soc_attr_group = {
>  };
>  
>  #if IS_ENABLED(CONFIG_ARCH_TEGRA_194_SOC) || \
> -    IS_ENABLED(CONFIG_ARCH_TEGRA_234_SOC)
> +    IS_ENABLED(CONFIG_ARCH_TEGRA_234_SOC) || \
> +    IS_ENABLED(CONFIG_ARCH_TEGRA_241_SOC)
>  static ssize_t platform_show(struct device *dev, struct device_attribute *attr,
>  			     char *buf)
>  {
> diff --git a/drivers/soc/tegra/fuse/fuse.h b/drivers/soc/tegra/fuse/fuse.h
> index f3b705327c20..9fee6ad6ad9e 100644
> --- a/drivers/soc/tegra/fuse/fuse.h
> +++ b/drivers/soc/tegra/fuse/fuse.h
> @@ -124,7 +124,8 @@ extern const struct tegra_fuse_soc tegra186_fuse_soc;
>  #endif
>  
>  #if IS_ENABLED(CONFIG_ARCH_TEGRA_194_SOC) || \
> -    IS_ENABLED(CONFIG_ARCH_TEGRA_234_SOC)
> +    IS_ENABLED(CONFIG_ARCH_TEGRA_234_SOC) || \
> +    IS_ENABLED(CONFIG_ARCH_TEGRA_241_SOC)
>  extern const struct attribute_group tegra194_soc_attr_group;
>  #endif
>  

-- 
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html