Received: by 2002:a05:7412:d008:b0:f9:6acb:47ec with SMTP id bd8csp379576rdb; Tue, 19 Dec 2023 22:36:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IEwXg9/eSmZd24g3p4B3vLZZCl3QSO54qJFGkjGoqNS4eUp/ZAUio4hkankiOa2+fJOCylp X-Received: by 2002:a17:907:e8b:b0:a23:59e0:5340 with SMTP id ho11-20020a1709070e8b00b00a2359e05340mr2845750ejc.54.1703054218120; Tue, 19 Dec 2023 22:36:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703054218; cv=none; d=google.com; s=arc-20160816; b=DVefzKgQG6WzKHFqDmxWbHO43qIWq1T3QOHbOQDVzYTvri7GWpNeFodV+RWZ8c6Xgb tId84rty8e5dr9wLyzw1+N9i+DF8PaI8nhI/bT0g+Bdkd+EX4vp2ExOkb2axesAjam+n iJbHx/k8eNgCb37BSdKcVYaQdt4Bh5YxV8aPzrsypNLtP8N0TRTVIqFvaWnaRa0adelv FuTBsmFz2QBuwmC8aDWPYMYW49GhubEfOtZP2N7r1VpucpAGvMssDxWyN8SE00Xlrkew RaSzsSHcM74sB4wTx6DIGDLeopSfZk6E9VvpxmFJBQZkznrmKF1T/stD7YQhhVbajdFv fk0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=1OcH1SEGjUWHte191Mv4FdEKFU9tG59CWlmtsHB9pQE=; fh=sZiEiD2fSHk+vUFwkUJd9PbdBDETSDhzPH1FyEFE5Xg=; b=qwcUesaOEYrmej8IcXXbjMO/z/kMH15c0sT9Ey//sNPJIJfiuSFaDtk2Y0Ut7WywBE n2Gfle4SXfLiVDGITWXcbk72qDMjoBT7Gm4EBY+KN6voDwr0lmh6jFq09K6/I2SHWyM+ kCT3yFLx09Ycjms4NGHFCKWJSfePFfbuKv0avG5GVMQ353L+G3f1UtmPeCBgdyBeOM7N HzTpUrea/mSnBEMUhwb569OtP29N3AHkE8gEXO3LWcOR3tZMW7oeNimyL+5jlPZIVGPo EbUYjhJVzAXKO6l+cHqUqDTbUdDa9zLmOuMngeldw2HWuM2660JOvDBM9VexJwjoy35b MJXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-6429-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6429-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id t15-20020a17090616cf00b00a25f5dba096si1047104ejd.478.2023.12.19.22.36.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 22:36:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-6429-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-6429-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6429-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id DBC5B1F22B46 for ; Wed, 20 Dec 2023 06:36:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E53E419BCD; Wed, 20 Dec 2023 06:36:45 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C51C1863B; Wed, 20 Dec 2023 06:36:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 2EA3268BFE; Wed, 20 Dec 2023 07:36:33 +0100 (CET) Date: Wed, 20 Dec 2023 07:36:33 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 14/14] fs: Remove the bh_end_io argument from __block_write_full_folio Message-ID: <20231220063633.GA1421@lst.de> References: <20231215200245.748418-1-willy@infradead.org> <20231215200245.748418-15-willy@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231215200245.748418-15-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) On Fri, Dec 15, 2023 at 08:02:45PM +0000, Matthew Wilcox (Oracle) wrote: > All callers are passing end_buffer_async_write as this argument, so we > can hardcode references to it within __block_write_full_folio(). > That lets us make end_buffer_async_write() static. Looks good: Reviewed-by: Christoph Hellwig