Received-SPF: pass (google.com: domain of linux-kernel+bounces-6434-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 20 Dec 2023 14:42:35 +0800
From: Yujie Liu <yujie.liu@intel.com>
To: Kees Cook <keescook@chromium.org>
CC: kernel test robot <lkp@intel.com>, <oe-kbuild-all@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>
Subject: Re: include/linux/fortify-string.h:52:29: warning:
 '__builtin_strcpy' source argument is the same as destination
Message-ID: <ZYKM2+WNOhY54bQS@yujie-X299>
References: <202311301039.7i51bZCz-lkp@intel.com>
 <202311301409.F2AFF5DA1@keescook>
 <ZYKHxJPcAZ+rGPeb@yujie-X299>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZYKHxJPcAZ+rGPeb@yujie-X299>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?c8DY1HQn71l3qe1FzX3qzSVIXuLY7XNs0ez1e7xD3y7Xi6lUZanp+9aceK1h?=
 =?us-ascii?Q?Bh95SNz7Muds/HhW3qtxgG5rIi6RdCaPRdJ9vofmqeiVs24rjF/ciBmLDkTq?=
 =?us-ascii?Q?BpVerjuB0c2rYhjJwwn45Ay4i2LYEz/qC2Tws4Th9OZonjDq6vhsp1H1cXKs?=
 =?us-ascii?Q?ielzksUunJBeMOb0KSHBsjZ+4tmyvUv7agIiL+zQ++5WWn2S7NyiXfOkl5W1?=
 =?us-ascii?Q?AyOWgWtB9IPVhRxCblk4b6EbOB1BiBhxV69DGZRCeA7pmbYFNC/pExlP7J8Q?=
 =?us-ascii?Q?PNWdDXgi+ejSRTW7hsVJtASLTk21xmnKJo7iAFygq6w5/7hesmev1dC4pjFK?=
 =?us-ascii?Q?uIa+y994romBh3ABJ3af2IHxBEVxwfaGp1kL2JGBk9EMc17bq3qRNCN+ZMbt?=
 =?us-ascii?Q?negteFu7bF9+hfwbMKg5gF/7DeXVRZuLGhl2WqgXELCVUs/OoQuiPlJnZgsh?=
 =?us-ascii?Q?dFklNeQybkBohQi5j+KyZdlAMl6IBhzpSYtnyAa8xudYPx/0Zx9PxaYLL9Lv?=
 =?us-ascii?Q?2HBbKKteUW8pfOSqEnEavGA6LJc6AA6LR5L0eJK0l9qggWadHptLpIINLAGT?=
 =?us-ascii?Q?l00h4bED6cVS2cPhfKa1EatwOGGXqG+sEcL3TH+30H2PUmsRTeqprV04OeBh?=
 =?us-ascii?Q?YnXVJtl82W81t2nUYEIZSKS92ZTTa/+JZiRIQXqJ2AXH1mnQz1+xrrv/BeYF?=
 =?us-ascii?Q?2NidnGi7SiYHYoUaUznFMbH6mULUxOJJmTLKFnqHaib3yif5NcOMR3Z0q1zD?=
 =?us-ascii?Q?tJnxItOnnx6re5JgwW3TigFwg5qpVnaCcKPmdKu2haLYFZDB13j/N0MTmgkQ?=
 =?us-ascii?Q?1xV2tiAc3zIe3oocr1vxCM2aafRDOt9ZqNEyoGaQNh/x6rM7fuDPy/AEbpJX?=
 =?us-ascii?Q?u3yU1TbDieLAFRAYWrjsJva6h9/flaYc6x5/PatStqGQJ1WjpAh4kh8ecrPY?=
 =?us-ascii?Q?Fkus8ejAMja/eyK99RWI+SGr2dmlE8tLTqIKCplVuoZVmwIAGlqHZs/aEQih?=
 =?us-ascii?Q?TBrutb0krNZz0xKXkl5TgTWaWNp6nPM+YfzO2eVf5Y3VyTBgTV3Yh+K5N1uM?=
 =?us-ascii?Q?60LYEHhC7OF4grJ+D8iVmLnuoFAK5q4F36R+pgch2GiF09k9ario34h5MuTD?=
 =?us-ascii?Q?GJrMQzOnsC0Zy8XEYjZ/OREA7pOCPm6Ci/QamHTEn5oT8KkXaFyEfLdr4RtJ?=
 =?us-ascii?Q?WHrWk01+gKzozEXW2Wqng9cmaTdsWpNS5w56wxWuVq+99DAieW2jN+x9sfeQ?=
 =?us-ascii?Q?D27zDtX+fWUZ0Sies9dKLv1oTuxqyhIA4OK8NbMO4WI40jYQ+XuYiER+QHRv?=
 =?us-ascii?Q?P11e3bHQ7PjzM03MHJikW2dcmCwe8sSwlstHhETdIW6LSkeoR0xf7WidsBql?=
 =?us-ascii?Q?o9vj8UKyh94vLFCehdmW4zEsHIIsp1FS5aF5bBEFi6VnjDS32txY+T5VUhvZ?=
 =?us-ascii?Q?rGlOhZrPGDzTc6wB4lHGoXoIrBFuBgd05LVrzd4D9m5QV7YIjCAxpiL4IX4j?=
 =?us-ascii?Q?riVxUtw8V2QmBHaQxUDziuhNxxaRqjTBsse5OOV2yF7fL/FuC+75bIJvUjz7?=
 =?us-ascii?Q?1w2kk1cd1KaXmtj8HNa2SkIVkzMfldibJw1Io8s0?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a82f9a76-f671-4155-026b-08dc01277874
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 06:47:01.6696
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UXN14X4Z0sMn12fUstJO7hwBZcdgijbxaFh0Yst5WNfnbynMWXG3dAYuXZz8/Xc/MIE/3jTu9vKQqtVN/AhF7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4815
X-OriginatorOrg: intel.com

On Wed, Dec 20, 2023 at 02:20:52PM +0800, Yujie Liu wrote:
> Hi Kees,
> 
> On Thu, Nov 30, 2023 at 02:11:54PM -0800, Kees Cook wrote:
> > On Thu, Nov 30, 2023 at 12:02:50PM +0800, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head:   3b47bc037bd44f142ac09848e8d3ecccc726be99
> > > commit: ba38961a069b0d8d03b53218a6c29d737577d448 um: Enable FORTIFY_SOURCE
> > > date:   1 year, 3 months ago
> > > config: um-randconfig-r034-20230830 (https://download.01.org/0day-ci/archive/20231130/202311301039.7i51bZCz-lkp@intel.com/config)
> > > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231130/202311301039.7i51bZCz-lkp@intel.com/reproduce)
> > > 
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202311301039.7i51bZCz-lkp@intel.com/
> > > 
> > > [...]
> > >    kernel/kallsyms.c: In function '__sprint_symbol.isra.0':
> > > >> include/linux/fortify-string.h:52:29: warning: '__builtin_strcpy' source argument is the same as destination [-Wrestrict]
> > >       52 | #define __underlying_strcpy __builtin_strcpy
> > >          |                             ^
> > >    include/linux/fortify-string.h:567:10: note: in expansion of macro '__underlying_strcpy'
> > >      567 |   return __underlying_strcpy(p, q);
> > >          |          ^~~~~~~~~~~~~~~~~~~
> > 
> > The only strcpy() in __sprint_symbol() is:
> > 
> > 	if (name != buffer)
> > 		strcpy(buffer, name);
> > 
> > Which is explicitly not the same address...
> > 
> > This appears to be a GCC 9 false positive, maybe?
> 
> Sorry for our late reply. We tested this with various versions of gcc,
> and this error disappeared when building with GCC 10 and 11, so it is
> very likely to be a GCC 9 false positive. We will configure the bot to
> use compilers newer than GCC 9 to test um arch.

Sorry, we will keep testing um with GCC 9 and configure the bot to
ignore this specific warning.