Received-SPF: pass (google.com: domain of linux-kernel+bounces-6437-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <ddd30bb6-20d1-4b7f-bcee-6b204d0858fb@infradead.org>
Date: Tue, 19 Dec 2023 22:49:54 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] scripts: kernel-doc: Bug fixed for erroneous warning
Content-Language: en-US
To: Muhammad Muzammil <m.muzzammilashraf@gmail.com>
Cc: corbet@lwn.net, gustavoars@kernel.org, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
References: <20231220062446.14511-1-muzammil@dreambigsemi.com>
 <4155c90e-cdb1-4645-8bcc-fed4ea01ac83@infradead.org>
 <CAJHePoabyUCxwS_hTjhR+MEJ+JBm+kr2MdbP4zP_54t_geRqwQ@mail.gmail.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <CAJHePoabyUCxwS_hTjhR+MEJ+JBm+kr2MdbP4zP_54t_geRqwQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


On 12/19/23 22:35, Muhammad Muzammil wrote:
> HI,
> 
> 1) I already have the below patch but it does not work.
> https://lore.kernel.org/linux-doc/20231215001347.work.151-kees@kernel.org/
> 
> 2) When I applied the below patch. It works.
> https://lore.kernel.org/linux-doc/87le9rjb4y.fsf@meer.lwn.net/

Thanks!


> On Wed, Dec 20, 2023 at 11:29 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> Hi,
>>
>> On 12/19/23 22:24, Muhammad Muzammil wrote:
>>> From: Muzammil Ashraf <m.muzzammilashraf@gmail.com>
>>>
>>> kernel-doc: fixed erroneous warning generated by '__counted_by'
>>>
>>> Signed-off-by: Muzammil Ashraf <m.muzzammilashraf@gmail.com>
>>> ---
>>>  scripts/kernel-doc | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/scripts/kernel-doc b/scripts/kernel-doc
>>> index 1484127db104..ea9688df0e93 100755
>>> --- a/scripts/kernel-doc
>>> +++ b/scripts/kernel-doc
>>> @@ -1661,6 +1661,7 @@ sub check_sections($$$$$) {
>>>                       }
>>>                       elsif (($decl_type eq "struct") or
>>>                              ($decl_type eq "union")) {
>>> +                next if (index("@_", "__counted_by") != -1);
>>>                               emit_warning("${file}:$.",
>>>                                       "Excess $decl_type member " .
>>>                                       "'$sects[$sx]' " .
>>
>> One of both of these patches should be enough. Can you test these
>> instead of your patch, please?
>>
>> https://lore.kernel.org/linux-doc/20231215001347.work.151-kees@kernel.org/
>>
>> https://lore.kernel.org/linux-doc/87le9rjb4y.fsf@meer.lwn.net/
>>
>> Thanks.
>>
>> --
>> #Randy
>> https://people.kernel.org/tglx/notes-about-netiquette
>> https://subspace.kernel.org/etiquette.html

-- 
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html