Received: by 2002:a05:7412:d008:b0:f9:6acb:47ec with SMTP id bd8csp401301rdb; Tue, 19 Dec 2023 23:43:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IGxLeoHvBxSaCSGIfcOzwJeiLFoOor1RszQvVnMkmGEq7U9diQ/5gDg0zkcvhE1vU9/g5DD X-Received: by 2002:a17:906:344f:b0:a23:5753:7ba5 with SMTP id d15-20020a170906344f00b00a2357537ba5mr2406319ejb.47.1703058185915; Tue, 19 Dec 2023 23:43:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703058185; cv=none; d=google.com; s=arc-20160816; b=WwK9RJ+wD5r4qCf04uQiB3QUVqt0V7BoWTGxuhzdHJSOtSb2s6psxl+2CvFesONfsY w4eZIFElARZ3KTBT6AAm6D0D+Wi2lTDnnO/qstHVAu0Spb19EK4/Gi8WR5DcSt+k+VhW QHxg7tAVlLPbfim2L5ZPqLKXMYcqRjspO/j4wqLMEM4IoesFikEqAB3A84vo8PxYcRSL qQdc97iWZ9e3E9wiOCf2fX7CH0nD33M+0vPwgMXmxWunaXV25N68KRHYwVCZbMiHyaz6 cI+ckoTJoeZPqd5+Kfj0NJy4ksM0YRiVnCrSmZsZNQqM3ekx6VGnLRpqeIUzwmE3o4hJ /R7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:dkim-signature:date; bh=iQBELqlRsaiuDO7WNvWnS3EgMMQXCEUjbipogtos9JM=; fh=q9dxsFxKQDnCwZv0eZKWkQzlpkA+xF2FAn1F38DfPG0=; b=m8n5Is1A3mlFP1MuMXt4uHBL4EyDcFYyEGCCwHEsGQLGZQScfEhsGIfpq13vcepSTw FnupyLPHrGNP5BZhn1yau87LADSujW04bCVBtu/Cb6oZUan8HcF6M0/ShOWOnga5h97t 2bP4SONlyUBq+nbOJywrcGrjEc9XWG7d5WIY5VontJpc5C6wlnSNCiTu2GcknRUEBo1E qvfhytCtkwPsYw6EUrancZ2pkE7GULwbAVVp9dSS5xCfrxL38w1o2JO2ve5Iq6Jd67Nq 7wnCKf53scoXnO6SDK64b1OqcVV9j5Oo6ZPgqOdSCRG7ki3lzehxE3qmTjRaCSNL6GAZ +d7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=W2JmRzd7; spf=pass (google.com: domain of linux-kernel+bounces-6509-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6509-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id lt26-20020a170906fa9a00b00a235bb042e6si2380468ejb.1038.2023.12.19.23.43.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 23:43:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-6509-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=W2JmRzd7; spf=pass (google.com: domain of linux-kernel+bounces-6509-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6509-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A805C1F21F58 for ; Wed, 20 Dec 2023 07:43:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E78E0171CA; Wed, 20 Dec 2023 07:42:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="W2JmRzd7" X-Original-To: linux-kernel@vger.kernel.org Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [91.218.175.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B2A4168A5 for ; Wed, 20 Dec 2023 07:42:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Date: Wed, 20 Dec 2023 02:42:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1703058171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iQBELqlRsaiuDO7WNvWnS3EgMMQXCEUjbipogtos9JM=; b=W2JmRzd7ETY6BtCd0OUqR6aiwK23nQNYxdAkU2E7uvLBo9loAxJWiftgJOCT71hdSImj5N b0rXcJf3jYA7C42txv0T5y4SdmyfrDeEPI2LeSDIaL4KCtFYacD/cz2JJKRxCulKpzEe0l 6U20Xu3P5FdHTLV1rurkwviogAlss1k= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Brian Foster , linux-bcachefs@vger.kernel.org Subject: Re: [PATCH] bcachefs: mean and variance: fix kernel-doc for function params Message-ID: <20231220074248.u4b6y73cyo7whucz@moria.home.lan> References: <20231220064409.12161-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231220064409.12161-1-rdunlap@infradead.org> X-Migadu-Flow: FLOW_OUT On Tue, Dec 19, 2023 at 10:44:09PM -0800, Randy Dunlap wrote: > Add missing function parameter descriptions in mean_and_variance.c. > The also eliminates the "Excess function parameter" warnings. > > Prevents these kernel-doc warnings: > > mean_and_variance.c:67: warning: Function parameter or member 's' not described in 'mean_and_variance_get_mean' > mean_and_variance.c:78: warning: Function parameter or member 's1' not described in 'mean_and_variance_get_variance' > mean_and_variance.c:94: warning: Function parameter or member 's' not described in 'mean_and_variance_get_stddev' > mean_and_variance.c:108: warning: Function parameter or member 's' not described in 'mean_and_variance_weighted_update' > mean_and_variance.c:108: warning: Function parameter or member 'x' not described in 'mean_and_variance_weighted_update' > mean_and_variance.c:108: warning: Excess function parameter 's1' description in 'mean_and_variance_weighted_update' > mean_and_variance.c:108: warning: Excess function parameter 's2' description in 'mean_and_variance_weighted_update' > mean_and_variance.c:134: warning: Function parameter or member 's' not described in 'mean_and_variance_weighted_get_mean' > mean_and_variance.c:143: warning: Function parameter or member 's' not described in 'mean_and_variance_weighted_get_variance' > mean_and_variance.c:153: warning: Function parameter or member 's' not described in 'mean_and_variance_weighted_get_stddev' > > Signed-off-by: Randy Dunlap > Cc: Kent Overstreet > Cc: Brian Foster > Cc: linux-bcachefs@vger.kernel.org Thanks, applied