Received: by 2002:a05:7412:d008:b0:f9:6acb:47ec with SMTP id bd8csp412314rdb; Wed, 20 Dec 2023 00:12:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IEi2/+D/61oMZBGbgz9j5r7prjJwZcXd4kdBx340G3Xr1CP6PsFTdlE/ibh0F4cib+Yyexs X-Received: by 2002:ac8:5d01:0:b0:427:81cd:aedd with SMTP id f1-20020ac85d01000000b0042781cdaeddmr1817919qtx.25.1703059978725; Wed, 20 Dec 2023 00:12:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703059978; cv=none; d=google.com; s=arc-20160816; b=MZrnD8npIu8cqB4kTfEZZ+Kg0NepIRVaNLAOnlvVxIbT4t9AJBki+vC6KhXW9bNnTd Y4ZrijqTmYKjqBXXl29RF/fNhPCJpOTyculLobsoqfY1aZItR4/wwbHRkIjkRvttJlHA hcHmddN/YBJ6LXX4fap+e91gxYIOr1hfWxfpJeurP3L9KfBAz/jdjBe53xtFeJm35LQu lGCcAmjl2ig8EXV7KOoPHtXx5noBQxoYgravJ4QREW86XTqzCB10CpqA1d3u+jd4cawQ K6qOtsVKPnlHHA68aPzrQ+Ow3qPh5P2ZLkV4qTOZCYx2iAW1/uDWdKuw1jgPl7kEQp7R D32g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=q/IQ2iG8Fb/GZ6k+LUyy0ARTedsdljjinroXky0cMwM=; fh=Aw0BmAzKIuOwc/9SdgyuiObGN/XxKsPeRkQDNZZd1qM=; b=vQmcuLYeJkyrGMvWy3SEj+AjqspowtAiXxQyUGiN8P3dvx3I5T4Kb+fPNbxKpR4T0Z wHqh4BXs2rvu9y68IAyzzRFzwCZEIhqCqnLSmO0psocYdgYYZVEkK/h24NEVZ85hSs31 cK4G7blHosPidWNr+reM8ZSYnPW+MIDReg0IK1j7KnFe6ZtiSyjzOqhP8fFgwj4akHRc lIAdoskBHF80kyGkUsD7mbZIjfxcu9yT/e8Yjxyd5Iy8kNoxRhgwMXLHgvCFBz8aG/DP DIrbJJMP7cudkrfdQO/xtk5Iou7/hoYovylIFU/gjNfiFefsAqQNKwuoB2B0m+v8fsoh 6hHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=unId8uUO; spf=pass (google.com: domain of linux-kernel+bounces-6547-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6547-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id t14-20020a05622a180e00b0042784aa55d0si1448387qtc.86.2023.12.20.00.12.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 00:12:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-6547-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=unId8uUO; spf=pass (google.com: domain of linux-kernel+bounces-6547-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6547-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7DA6F1C24D03 for ; Wed, 20 Dec 2023 08:12:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DC13D1944F; Wed, 20 Dec 2023 08:12:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="unId8uUO" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 159661CA8E; Wed, 20 Dec 2023 08:12:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A21BC433C7; Wed, 20 Dec 2023 08:12:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703059962; bh=BHRiKQEvoPIgw/Ei788HQtUg9h30YDWszt+pYb2kLqk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=unId8uUOjR9Qvz0tGmgTzCv8tRcQNsP1sTPJ6jq8l85UCjPAkC59QC1JqJNyf5xEr FWoJceorXNGzjFDeGhSoMdJEFoL9YddSutqAMNTobs7zH7Q/RR9aE2fhCQQL+rl/ag IUMvq7dO7VLLHLXoE0568+k3Uc/1XW8BLmNpMK2j9c7VR3EM/WJEuyK4XiFht0O7d+ yDGLhwoeBhinZG+5c6IWIBW44YPfVFp9bP8VwlKkXq3VnB9SgvVr5KuBIiap02Sicy egd36i3OHruOWZlTK3bBgSVKFf8IU1Ew0kLrq9LDCnCTvWPyXiO7dK2Eix9juwvYVD nn+xTYZKR/cig== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rFrh2-0000pH-1C; Wed, 20 Dec 2023 09:12:40 +0100 Date: Wed, 20 Dec 2023 09:12:40 +0100 From: Johan Hovold To: Marijn Suijten Cc: phone-devel@vger.kernel.org, Pavel Machek , Bjorn Andersson , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , linux-arm-msm@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH] leds: ledtrig-pattern: Use last_repeat when applying hw pattern Message-ID: References: <20220719213034.1664056-1-marijn.suijten@somainline.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220719213034.1664056-1-marijn.suijten@somainline.org> On Tue, Jul 19, 2022 at 11:30:33PM +0200, Marijn Suijten wrote: > `last_repeat` holds the actual value requested by the user whereas > `repeat` is a software iteration variable that is unused in hardware > patterns. > > Furthermore `last_repeat` is the field returned to the user when reading > the `repeat` sysfs property. This field is initialized to `-1` which is > - together with `1` - the only valid value in the upcoming Qualcomm LPG > driver. It is thus unexpected when `repeat` with an initialization > value of `0` is passed into the the driver, when the sysfs property > clearly presents a value of `-1`. > > Signed-off-by: Marijn Suijten > Reviewed-by: Bjorn Andersson > Tested-by: Bjorn Andersson Looks correct to me: Reviewed-by: Johan Hovold