Received-SPF: pass (google.com: domain of linux-kernel+bounces-6652-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date: Wed, 20 Dec 2023 10:51:11 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Vegard Nossum <vegard.nossum@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org,
	Brian Gerst <brgerst@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Linus Torvalds <torvalds@linuxfoundation.org>
Subject: Re: [PATCH 1/5] x86: provide new infrastructure for GDT descriptors
Message-ID: <ZYK5D/KfzpEjQr+8@gmail.com>
References: <20231219151200.2878271-1-vegard.nossum@oracle.com>
 <20231219151200.2878271-2-vegard.nossum@oracle.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231219151200.2878271-2-vegard.nossum@oracle.com>


* Vegard Nossum <vegard.nossum@oracle.com> wrote:

> @@ -27,14 +77,14 @@ struct desc_struct {
>  		.base0		= (u16) (base),			\
>  		.base1		= ((base) >> 16) & 0xFF,	\
>  		.base2		= ((base) >> 24) & 0xFF,	\
> -		.type		= (flags & 0x0f),		\
> -		.s		= (flags >> 4) & 0x01,		\
> -		.dpl		= (flags >> 5) & 0x03,		\
> -		.p		= (flags >> 7) & 0x01,		\
> -		.avl		= (flags >> 12) & 0x01,		\
> -		.l		= (flags >> 13) & 0x01,		\
> -		.d		= (flags >> 14) & 0x01,		\
> -		.g		= (flags >> 15) & 0x01,		\
> +		.type		= ((flags) & 0x0f),		\
> +		.s		= ((flags) >> 4) & 0x01,	\
> +		.dpl		= ((flags) >> 5) & 0x03,	\
> +		.p		= ((flags) >> 7) & 0x01,	\
> +		.avl		= ((flags) >> 12) & 0x01,	\
> +		.l		= ((flags) >> 13) & 0x01,	\
> +		.d		= ((flags) >> 14) & 0x01,	\
> +		.g		= ((flags) >> 15) & 0x01,	\

Yeah, so how about writing it like this:

 #define GDT_ENTRY_INIT(flags, base, limit)			\
	{							\
		.limit0		= ((limit) >>  0) & 0xFFFF,	\
		.limit1		= ((limit) >> 16) & 0x000F,	\
		.base0		= ((base)  >>  0) & 0xFFFF,	\
		.base1		= ((base)  >> 16) & 0x00FF,	\
		.base2		= ((base)  >> 24) & 0x00FF,	\
		.type		= ((flags) >>  0) & 0x000F,	\
		.s		= ((flags) >>  4) & 0x0001,	\
		.dpl		= ((flags) >>  5) & 0x0003,	\
		.p		= ((flags) >>  7) & 0x0001,	\
		.avl		= ((flags) >> 12) & 0x0001,	\
		.l		= ((flags) >> 13) & 0x0001,	\
		.d		= ((flags) >> 14) & 0x0001,	\
		.g		= ((flags) >> 15) & 0x0001,	\
	}

This encodes it all in a very simple format, without C syntactic
variations: bit position and mask.

Thanks,

	Ingo