Received: by 2002:a05:7412:d008:b0:f9:6acb:47ec with SMTP id bd8csp450902rdb; Wed, 20 Dec 2023 01:53:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IFwyspwY5if0vFCsJzKJ3ljWcuU/DybGT/VPWHp2CeU5C4rAe9qK6lG9f3vcqftOqAy4sYF X-Received: by 2002:a50:aa97:0:b0:553:57e0:3e20 with SMTP id q23-20020a50aa97000000b0055357e03e20mr2668777edc.32.1703066031966; Wed, 20 Dec 2023 01:53:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703066031; cv=none; d=google.com; s=arc-20160816; b=rTpxPygkmp/nM4PJO52XPI/GMZAVNjj0iTdbW1KHJcKpEjdniWAIVpsXCBqN/i+Jhw goVjUAhxbkafXLBW/cf/5VyifExGxg6T8aRTIQ3PSgvHe1AD1M/BICqYk/q0beAbBNLp jhFJS9nDVN7hiSigiHsU3L7BlAY2A6yJbAA0lWsEre2GACBr/rMfScL0CRKf2HlIzRCT zQueF1bLrxZfIZZTOHqqa7F6aSo4r6Ur8iR/lJ0W18OpDi+X/D7wYJpt1JbAdCLah1bp y+9TWGrb/x43B22jev3hHpSjHmTmO6II/DnsvS2FpL/52UZSthLmx5z+mgkH3tTYqdD8 rGKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature:dkim-filter; bh=fkPlk9QOXBUg/k3FjQRsnSKdPa0KJL00WGVvsE/i3dA=; fh=MhKulj+h1e4ILrEQT6PQkV8hDF+8vZAoQPhRucf9y7o=; b=gHBgeTR30QkGBgxzlsyWF+iT+5kAdNnRnknUmp4Hre4HafwwCByZwGM498pXT4eSOx burG5xJcvKgq1hg6k+lC60wpuM8F8nJJpSutN/2U9TpSLm+gaKY6ycivgy9Lh2DCp2uE Var/9KQDYixK1Zssv5c9Lbq6ly8aiyhjzUuHtFzwA6DsqHzj9bTwl6P/e/2UWBO5a7Ry 6eO+/JG0979EWMf6baNCp+4+8Fdcc3rS84L5DTF8ZkvSSjruxaC8ApvsL8C6ySiOOb+H 3cXbVIm9GLpagLk4oqAyuU5gEc9pMVijvxycZzS2CBoHbGHuqTaZwPpp7VyjHnjVMADk 04cQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=Trv9tXZv; spf=pass (google.com: domain of linux-kernel+bounces-6659-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6659-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id v20-20020a509554000000b0055343d3be78si2765062eda.239.2023.12.20.01.53.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 01:53:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-6659-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=Trv9tXZv; spf=pass (google.com: domain of linux-kernel+bounces-6659-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6659-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B4DE41F249C0 for ; Wed, 20 Dec 2023 09:53:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0A5C2200AB; Wed, 20 Dec 2023 09:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b="Trv9tXZv" X-Original-To: linux-kernel@vger.kernel.org Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49B251F61C; Wed, 20 Dec 2023 09:53:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ispras.ru Received: from localhost.ispras.ru (unknown [10.10.165.4]) by mail.ispras.ru (Postfix) with ESMTPSA id 497C140F1DC3; Wed, 20 Dec 2023 09:53:31 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 497C140F1DC3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1703066011; bh=fkPlk9QOXBUg/k3FjQRsnSKdPa0KJL00WGVvsE/i3dA=; h=From:To:Cc:Subject:Date:From; b=Trv9tXZvm1wV7BQ/LrnJvbCYWoYO0k0HXzowr4ubM0O8M5L8LT4Ev/elpRfApKN1m 78ovhPmblZ/1x0Q3PfftlloLqq9yUHBqoiIaQr3Lg7f4op3EQj8kHfJAcATotP4Fey C4HbYjfVMw6ywINCYilDngwxaX8BXMaD8OzCOpeY= From: Fedor Pchelkin To: Inki Dae Cc: Fedor Pchelkin , Seung-Woo Kim , Kyungmin Park , David Airlie , Daniel Vetter , Krzysztof Kozlowski , Alim Akhtar , Marek Szyprowski , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org Subject: [PATCH] drm/exynos: gsc: minor fix for loop iteration in gsc_runtime_resume Date: Wed, 20 Dec 2023 12:53:15 +0300 Message-ID: <20231220095316.23098-1-pchelkin@ispras.ru> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Do not forget to call clk_disable_unprepare() on the first element of ctx->clocks array. Found by Linux Verification Center (linuxtesting.org). Fixes: 8b7d3ec83aba ("drm/exynos: gsc: Convert driver to IPP v2 core API") Signed-off-by: Fedor Pchelkin --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c index 34cdabc30b4f..5302bebbe38c 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c @@ -1342,7 +1342,7 @@ static int __maybe_unused gsc_runtime_resume(struct device *dev) for (i = 0; i < ctx->num_clocks; i++) { ret = clk_prepare_enable(ctx->clocks[i]); if (ret) { - while (--i > 0) + while (--i >= 0) clk_disable_unprepare(ctx->clocks[i]); return ret; } -- 2.43.0