Received-SPF: pass (google.com: domain of linux-kernel+bounces-6666-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date: Wed, 20 Dec 2023 10:59:05 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linuxfoundation.org>
Cc: Vegard Nossum <vegard.nossum@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org,
	Brian Gerst <brgerst@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 0/5] replace magic numbers in GDT descriptors
Message-ID: <ZYK66eEcRgdPOeWa@gmail.com>
References: <20231219151200.2878271-1-vegard.nossum@oracle.com>
 <CAHk-=wgSjQvgXbYkqJuOhL337cESfb-z65889D+-Rc6o5euYwQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHk-=wgSjQvgXbYkqJuOhL337cESfb-z65889D+-Rc6o5euYwQ@mail.gmail.com>


* Linus Torvalds <torvalds@linuxfoundation.org> wrote:

> On Tue, 19 Dec 2023 at 07:12, Vegard Nossum <vegard.nossum@oracle.com> wrote:
> >
> > Vegard Nossum (5):
> >   x86: provide new infrastructure for GDT descriptors
> >   x86: replace magic numbers in GDT descriptors, part 1
> >   x86: replace magic numbers in GDT descriptors, part 2
> >   x86: always set A (accessed) flag in GDT descriptors
> >   x86: add DB flag to 32-bit percpu GDT entry
> 
> All these patches look fine to me, but I will again leave it to the
> x86 maintainers whether they want to apply them. But feel free to add
> my Ack if y ou do.

Thanks - I've applied your acks. These are obviously useful cleanups,
so no objections whatsoever.

> The end result does look a *lot* more legible, with something like
> 
>    DESC_DATA64 | DESC_USER
> 
> instead of just a raw number like 0xc0f3.
>
> So while this is unlikely to be a maintenance burden (since we look at
> these things so seldom, and they never really change), I think it's a
> nice readability improvement.

Yeah, absolutely.

> The fact that Vegard found two oddities while doing this series just
> reinforces that readability issue. Neither of them were bugs, but they
> were odd inconsistencies.

Indeed ...

Thanks,

	Ingo