Received-SPF: pass (google.com: domain of linux-kernel+bounces-6737-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <6d7163bc-db76-42f9-8c5e-f9b855b233fc@amd.com>
Date: Wed, 20 Dec 2023 17:23:48 +0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] iommu: amd: NULL value may be dereferenced
Content-Language: en-US
To: Alexander Sapozhnikov <alsp705@gmail.com>, Joerg Roedel
 <joro@8bytes.org>, ToWill Deacon <will@kernel.org>
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
 lvc-project@linuxtesting.org
References: <20231219100219.17332-1-alsp705@gmail.com>
From: "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
In-Reply-To: <20231219100219.17332-1-alsp705@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q3ZIajNqck9DY1pYK1MyN29ZZWpTUTNGc2pIb29FT0RqaENsaGZzQzM4NjBn?=
 =?utf-8?B?ekswdVRUWEk0K0NQTmV5dTNocTBGOUxoaE9aZW1DWFF2QlUwT2lwWXk5Mm1o?=
 =?utf-8?B?VFNRdDdTMFNHSUpkRWdUaS80Q0RJdENLWkhPWWpOT25IcmNIbVdVMlU4Y0xh?=
 =?utf-8?B?cDlMYnJCcnlnbjh0NWFHWHdFUDE4WlhqU0FKS0ZpakZzSjBEZ0c3RTh1YlJI?=
 =?utf-8?B?K3M5QUk0MllOTzVmT09uM0ZobkRHSDdLN0xLVHdFQmVQNWlMaEYyZ2NxUVFi?=
 =?utf-8?B?akJYRGo0TUpvK3laY1hCWjdDU3ZCbmJwL2FZQnU3UHRldi9KMWRDYmszOVZ2?=
 =?utf-8?B?SWlaYnJxQ3R0Q1RmMFF2K2R4MzlVb3dMZVhvZU54Y3Rnbi9nQmFpTzJsT1Fn?=
 =?utf-8?B?cGx2TjUzT3FlVXZ2czJmdFd6WjdtSDNmRXBvYVhJZGU5MFNScUFWZWc0T0Nu?=
 =?utf-8?B?REFTbmlKbjFHT2VQVTJZYzlHMEs3UktFeVlmcVgybHRsVnEwWDlJemU4YUVt?=
 =?utf-8?B?bzFUOGcyOTUyTS94eG1ha3U1M2NPOWQzcDhBaTNObG1GM1M1Z0ZCek8zSGhm?=
 =?utf-8?B?NTFCb1JaSWYwTFFqVGFrb2ZLcmxOa1hVMnJKKzFUL25peW1XRzVsQ0hCbUNJ?=
 =?utf-8?B?L1drNGVOYnY0azR1SHI2QzlwelNZMTJqNk9iRlJLMjVzK0ZRUlJQMElTWXhN?=
 =?utf-8?B?M1c1RlBnOTJxWDJWT3BaNlV3MFZyUStPQVZVd1R6K2ZnQ0NraFZwSHd1cmVo?=
 =?utf-8?B?eUFTYnRoUDRma243VmdtcGJTaDQwU3NWR2ZKdFl4YjBKY1BzMzZSSDJDWFpl?=
 =?utf-8?B?U2hDUzVJYWRCNkxKOThSWVVxWko0dUFWZWM3dnVYOWpVSHNMZWJjMGNFMDJD?=
 =?utf-8?B?T1JxZDBtQjYzNDlwelUxYVA1ekdhaUNDRytHbGFJTXVZVUZrYjJ1RXdwc1lk?=
 =?utf-8?B?NjhPbjZvUUx5ZXJ5ZWdYR1JIN1Y5OFdReENDK3RHZkJRaktuMTBLa3lhYXpP?=
 =?utf-8?B?TXVMNUVoYnBwMWlYU01rdDB5d2JwK0k0VlVTOFNKc0dFVjh4RndpNzFNZ053?=
 =?utf-8?B?NkNnT3dkWkk1UGFoT3J0WVJLN1ExUUt5Mno3UStaWGlOWmtmbldCc1kzd1Rz?=
 =?utf-8?B?OFFORnN3VEswTWk5cjY3dUFQcXRqT3ZxZ2ROMDAycVZsdHZxRTBDRnNVVWE2?=
 =?utf-8?B?RGZWSEd0NnF2QTBuS2FsdzRtY21WaFdkMGl6WUFXYlJXY29UaUVYVkd0cnl5?=
 =?utf-8?B?eE5GdURIOWZ5TGNOUFFDQ0RMZXlxL0llOTJQOW52bFM4NzNMNmJjd0dQS3cy?=
 =?utf-8?B?ZklhQ3hrUkhLc2lKWGx2Y0hpVjJxdWtpbFA4clByT2lvVjhZaktUcWRRYVBW?=
 =?utf-8?B?NFlGUGt4TGF3bUpkTWJxWlc1bHVJZEg5N1Rjci9aQ0lQWnR5eGJqMHdnNkNB?=
 =?utf-8?B?azRoNVdOdGdhM0JTYWg4bFRaSldBRFkrd2pmZUU1SEllSXk0TmlteFpGSW1n?=
 =?utf-8?B?dGVHb0hFcTJvbHpLV2xyMFY2WTN1cmowL1hvWi9rUTQvWDY1NURoS0gzSDJC?=
 =?utf-8?B?dDBsMWI0aDRsb2RFVEN1R05FaWlJMTFJSGY5MWNNVFYrM3dpUFd3cFhuYzJ3?=
 =?utf-8?B?NGg3QTNHZzJFbVRQOXpJY1hTWWtzbHRuTjhobDBTV3ZkVHdjSVNUUDdKN3JR?=
 =?utf-8?B?VkZieHpsL0t3cDB1SElpMUUrZWV2M01GamYrelNKMGF5RERoU2dKd2p2azQ4?=
 =?utf-8?B?UDJqSXltem5MS1lrQjVNVnFsVkhyMzlvL25kMmtGVzFRQkVHdHMwc1VOaXFP?=
 =?utf-8?B?czY3NFVsbks2YmtodTE4QmgxOHFPVXNzR29xYVNqOHVZOUVBdVlQTE94QW94?=
 =?utf-8?B?Vjl0TEdySXBEMVhNSXBZa21PV0QzTzFnWjNtSTdja3pGSXBZMXdZSlBWUmVH?=
 =?utf-8?B?cGhHMlZrUnRGZnMwT2h5ZjhiSDNvU0J3aTZjWko2N1BEYmtYME9zZUtlVFZy?=
 =?utf-8?B?Mjk1ZUhXRnVvd0xxUFJDVnpndnkybFgvcVQ0amYrZzlLL0RZMkRtbEhRVVZr?=
 =?utf-8?B?TGpxa0ptcEdUSU1uMVlLU3c5clNRT1ZFaUxBVHBGMDJEMjBvZmtJY0JzMDhu?=
 =?utf-8?Q?jlzxvzOj4mHjqnxmlKdMHJSiV?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b78e7a82-7b0d-4dbd-e595-08dc0145c5e3
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 10:23:56.5607
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HwODwT3TMN2yQ/o2+kOl2+fib7Couc9kyZil8t+1YcUXAOlC79edwc8Y4XVMTgjjS99QqZFNsGMTbcdJGASQZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5801


On 12/19/2023 5:02 PM, Alexander Sapozhnikov wrote:
> Pointer 'dom' which was dereferenced at iommu.c:1993
> is compared to NULL value at iommu.c:1998.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Alexander Sapozhnikov <alsp705@gmail.com>
> ---
>   drivers/iommu/amd/iommu.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
> index a0924144bac8..64a88e67be9c 100644
> --- a/drivers/iommu/amd/iommu.c
> +++ b/drivers/iommu/amd/iommu.c
> @@ -1985,6 +1985,9 @@ static void amd_iommu_domain_free(struct iommu_domain *dom)
>   {
>   	struct protection_domain *domain;
>   
> +	if (!dom)
> +		return;
> +
>   	domain = to_pdomain(dom);
>   
>   	if (domain->dev_cnt > 0)

This check is already added in the following commit in the next branch 
of the iommu.git repo.

3f4b87b959ea "iommu/amd: Make use of domain_alloc and domain_free"
(https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git/commit/?h=next&id=3f4b87b959eab362b89fce6ceb9d1badd102e5ea)

Thanks,
Suravee