Received: by 2002:a05:7412:d002:b0:f9:9049:d2ea with SMTP id bd2csp18605rdb; Wed, 20 Dec 2023 02:39:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IGh+E5bpiOxycms/0jze9gAwUrVK3APr78PHoR7FZMTa2TMIlbt1BkFi4EvOJg9ge4zr/R+ X-Received: by 2002:a17:90a:de01:b0:286:c00f:b622 with SMTP id m1-20020a17090ade0100b00286c00fb622mr12536802pjv.41.1703068775398; Wed, 20 Dec 2023 02:39:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703068775; cv=none; d=google.com; s=arc-20160816; b=Vble20CEyfgjZl8Mk4iz1LTgG0qeFgYOgM3xOr+oLNjobdBhpMCWiy47mbQEF8va2t Bv1ZEqmkz20mVgygYluOAIQuXUYzKLQMZvagiJU3karMgoAVLRys9y2y2I/p94tlOmGB uArXrPH878PADKoGspJtzmHshjUTXpqUGc/RLv5ULJEiAACVuCqa1SVvcXi+QIAyEJvp cF+COaQAhmJ2tgUBx6lM3QYNRDfysqwNxH6fXGVqGHFS2Xe+CW4C7aNwwCtndfYymKtJ EDrULPJM7mAkdJEi/6upDSruiKNJuVANiReBzuiF4pVBDwarqTR81YKov5EFUjr5128X FNyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=oZuX6j3cdxIhMhThZF4SA/JP650rHG1NpIR8AQERkuI=; fh=gNaIl6zqDV+ztfgoVOEzNZ0kGwaE0bvzC4ov1dLN7GQ=; b=EtYXDa7E1CLRPJnW31qPWp+LiZ0l4rfjPzih4Wl5KeiXbEnYqY6cAcyoIc9LWBMDyg BmSqwpIeHfusCXxipJ5ITNn+8umt5uwwZ4TPH83DLg7JhFgjgRYWs3uBBdXmRKd02k/j G3xdt8Fx0PPxFH42wivNLS5RZqIz1kTMk6YXJUA4Ff3bVAFrTlm44YvsoN1FVxlaugXt BNlbg4SeI5XzHhfgpGO/8p8gqmfFmjXHZ2JfV9KacTwp0AHxaYzH6kh7pPhpOJEtAgtt a+6vOfveJkfd4lA5E2BdgE4V88UY9OJzCEP8TuZ8CAsF0Kjxz0x7dCRqU45jcU1+0O25 RfCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=iutGlf2J; spf=pass (google.com: domain of linux-kernel+bounces-6745-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6745-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id x14-20020a17090a8a8e00b0028bd4a3d4c1si945039pjn.158.2023.12.20.02.39.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 02:39:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-6745-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=iutGlf2J; spf=pass (google.com: domain of linux-kernel+bounces-6745-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6745-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A24F3B26946 for ; Wed, 20 Dec 2023 10:31:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1657720DF4; Wed, 20 Dec 2023 10:30:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="iutGlf2J" X-Original-To: linux-kernel@vger.kernel.org Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6C0420B11; Wed, 20 Dec 2023 10:30:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1703068242; bh=YVVXuKIyCnfmhYXofbFSKAEHH88LRfArJsiXeVCEWNg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iutGlf2JvAvI5tVVVndsYew77bFzOFFdE/2AR6qxWDoYBTasTm6YgFnIt47BQjVyb VRw33XHBUX0FpfjdeFfOONOHc46/R2nVBaqTHOwxLh/sSjNX8jJFo6LOE5fQmaiM1j qE0QYB36fk5x1SP8y90AmXkhUiP2y4wIUV4cJT4w+86RzLYQuDF2WM7P5GHvHu2Ypm vmxlcXzlQbZdLh+aNs3Sxccc9+8+EAeeLSPjHEmeBt+vImHjYkURfH2y+Po0ZzuTbS V4Fi6eFt/Phin10GrvHur3UJ7n768NcKuXsm81bnRKYyX1ZpN8IuHKZ2A+woDU46jI DUu5pK6SPjsiw== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 0906B3781FC9; Wed, 20 Dec 2023 10:30:40 +0000 (UTC) Message-ID: <9ebfe163-c86a-4aca-8f60-179a218821b4@collabora.com> Date: Wed, 20 Dec 2023 11:30:40 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] usb: xhci-mtk: fix a short packet issue of gen1 isoc-in transfer Content-Language: en-US To: Chunfeng Yun , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski Cc: Conor Dooley , Matthias Brugger , Mathias Nyman , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Eddie Hung , Macpaul Lin , stable@vger.kernel.org References: <20231220025842.7082-1-chunfeng.yun@mediatek.com> <20231220025842.7082-2-chunfeng.yun@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20231220025842.7082-2-chunfeng.yun@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 20/12/23 03:58, Chunfeng Yun ha scritto: > For Gen1 isoc-in transfer, host still send out unexpected ACK after device > finish the burst with a short packet, this will cause an exception on the > connected device, such as, a usb 4k camera. > It can be fixed by setting rxfifo depth less than 4k bytes, prefer to use > 3k here, the side-effect is that may cause performance drop about 10%, > including bulk transfer. > > Fixes: 926d60ae64a6 ("usb: xhci-mtk: modify the SOF/ITP interval for mt8195") > Cc: stable@vger.kernel.org > Signed-off-by: Chunfeng Yun Reviewed-by: AngeloGioacchino Del Regno