Received-SPF: pass (google.com: domain of linux-kernel+bounces-6780-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Received-SPF: Pass (protection.outlook.com: domain of topic.nl designates
 20.93.157.195 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.93.157.195; helo=westeu11-emailsignatures-cloud.codetwo.com;
 pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=topic.nl;
Message-ID: <02cbc31e-ec6e-4b3b-940d-da51567c197b@topic.nl>
Date: Wed, 20 Dec 2023 11:58:00 +0100
User-Agent: Mozilla Thunderbird
From: Mike Looijmans <mike.looijmans@topic.nl>
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: ti-ads1298: Add driver
Content-Language: nl, en-US
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
CC: devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
 Conor Dooley <conor+dt@kernel.org>, Jonathan Cameron <jic23@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Lars-Peter Clausen <lars@metafoo.de>, Rob Herring <robh+dt@kernel.org>,
 linux-kernel@vger.kernel.org
References: <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.618139b3-8cb2-4e4c-9283-9e3787c70105@emailsignatures365.codetwo.com>
 <20231213094722.31547-1-mike.looijmans@topic.nl>
 <20231214111107.00002fd8@Huawei.com>
Organization: TOPIC
In-Reply-To: <20231214111107.00002fd8@Huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original:
 vKjsXgyrJPGS29S9RltwJSa4X9VzjiPojw8VTae16KZTZ83djfUtpB43hfGzm8cLpSLYd4hvy6S9CLqJ2gv6rYWqhyTyY+Wa2/MudsIw8yx8KKohZDLKnrb/ShrF2XVfTAnlVnX9FFxkRNvM0st3nURHvHMAJoK3MLwLOvIMqtZxIRVrhu7roFKAINxsncMTJBfTUT/JAgD1jKv/Si7sRRMInEtlM7psMdVScWUowOU5h5KYIbBANUrVFZe1rCKdKQVL+TlHRZafAQf9KSumy4/cMWyF76zzY95odLkf2KoZBopzKMY5o4SCUPiklTyefVWNX2LO4CuheEIm8zwYXnwApDN9yh/+Hy4tZEgC3rhzMx4QiuON1qVVsNf2UG6hkOJgurzIAtKqoK06+AAtZyLWi50LpGEwA/I0+NrK6Kw7+vkFK9lbi8sAI8t5E17aWYHrOjGORbfnr20TCczCNrq29eiAkEtD3U3su5zVlCE688XOpV2APhtUaDjY9+a4jil+r+b7PGBjhn2YXeHfQabRW35XCU7tIWgp9TTUfz/f4NWO7V3oYaIZFziSFzd8agqX7s77lhWx8LR/f3K7DEMiWJbcNBA5GOqdFND7u4IMcWR1KLZP8t+O5KhSZBtvQFt3ukHR4crC/cAc5zOQBO0hhAewcd8Le87iXCSit+w=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB7471.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(396003)(39840400004)(376002)(366004)(230273577357003)(230173577357003)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(83380400001)(316002)(6916009)(66476007)(66946007)(5660300002)(54906003)(66556008)(44832011)(8676002)(8936002)(4326008)(53546011)(36916002)(6512007)(6506007)(2906002)(26005)(6486002)(966005)(478600001)(31686004)(2616005)(31696002)(86362001)(41300700001)(36756003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9566
X-CodeTwo-MessageID: e107655c-4b32-4455-8c17-63897b753d9f.20231220105806@westeu11-emailsignatures-cloud.codetwo.com
X-CodeTwoProcessed: true
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5PEPF00014B8D.eurprd02.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	2a6d51a1-c9db-44e4-6377-08dc014a893b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jvHCiOFwAtnsD7GlcOsyRL3yP3KRUrd0AehqqRCV4JhP99ViIPXFdXObZW4zbvMdkVQ/Ba9SgbK+xU1R3OgaiCTEAboZZS3lS5tGUlxakIYfzwd9GazD9Im6SAuXZz7YUvUjEl3UKJ1mPd3y8pwahSFbopBVPgOv6lbIGJYssBx8mN4bbQha8rlmJvJUCxJ93PWwT21/r976m/w6pDyzw2o/B0g7AXqx2dmLnhFIuECKsKOXwPug+gUC1Y1HZit1VJ1NCYscQwyZtElh6Ju72TleUfbJMhLC/tQh1rV+ygrlh0cfNm7hiS+iWpRY8wEHKxopiV+6BP6F6QyklCCyuov6sT7Y4Se6gLj9lT3Sfg8RW0lfZa9WRPf2Ddnh+/PNZW0ogBRUyo1IrKiu/HcAfTMP8PKOsGHph6ng5ZSVZ1XLB8zxB6EmcUL7YZsRDK+dU38eXJgerXTVwSr3qRxbfPqZRCfvmsrjCOW1jW/252QgDcpUR2+mtw4v7rvDCu0DuG7k5Az/WgCea7bKu4Dc1Gvxd1qaWnVnI0i/eYwGhGqhUmhfB2FE4DeHsJO0afXMPEMDhoB3Fk/4A6TocOFTbHqWeBwjwt+pqGvF0qeJC/90vOhLsZrONGV73uHtEaD2AxB4RzQWauqT6xHqgnMIG3nXV8fppw3MzDVqdq2LiU0bU5M8p4Ah8VjMejrj3wz8DcNIw9LeHfjzEqXGEoxN2aqMrmlV04hs19fqTJgu1xIyDpg+FpOFzXyzFnHeVHZlcNG80yLie4iQuPUYnhX6Lg==
X-Forefront-Antispam-Report:
	CIP:20.93.157.195;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:westeu11-emailsignatures-cloud.codetwo.com;PTR:westeu11-emailsignatures-cloud.codetwo.com;CAT:NONE;SFS:(13230031)(4636009)(136003)(346002)(376002)(39830400003)(396003)(230273577357003)(230173577357003)(230922051799003)(1800799012)(186009)(82310400011)(451199024)(64100799003)(36840700001)(46966006)(36860700001)(7636003)(7596003)(356005)(36756003)(86362001)(40480700001)(31686004)(31696002)(6512007)(53546011)(6506007)(26005)(47076005)(2616005)(41300700001)(336012)(478600001)(966005)(4326008)(8676002)(8936002)(36916002)(6486002)(6916009)(83380400001)(70206006)(316002)(54906003)(70586007)(15974865002)(2906002)(5660300002)(44832011)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: topic.nl
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 10:58:07.9831
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c4334100-65d8-4ed6-19f8-08dc014a8ce5
X-MS-Exchange-CrossTenant-Id: 449607a5-3517-482d-8d16-41dd868cbda3
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=449607a5-3517-482d-8d16-41dd868cbda3;Ip=[20.93.157.195];Helo=[westeu11-emailsignatures-cloud.codetwo.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5PEPF00014B8D.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7334


Met vriendelijke groet / kind regards,=0A=
=0A=
Mike Looijmans=0A=
System Expert=0A=
=0A=
=0A=
TOPIC Embedded Products B.V.=0A=
Materiaalweg 4, 5681 RJ Best=0A=
The Netherlands=0A=
=0A=
T: +31 (0) 499 33 69 69=0A=
E: mike.looijmans@topic.nl=0A=
W: www.topic.nl=0A=
=0A=
Please consider the environment before printing this e-mail=0A=
On 14-12-2023 12:11, Jonathan Cameron wrote:
> On Wed, 13 Dec 2023 10:47:21 +0100
> Mike Looijmans <mike.looijmans@topic.nl> wrote:
>=20
>> Skeleton driver for the TI ADS1298 medical ADC. This device is
>> typically used for ECG and similar measurements. Supports data
>> acquisition at configurable scale and sampling frequency.
>>
>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>>
>> ---
>>
>>   .../bindings/iio/adc/ti,ads1298.yaml          | 80 +++++++++++++++++++
>>   1 file changed, 80 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads129=
8.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml b=
/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml
>> new file mode 100644
>> index 000000000000..7a160ba721eb
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml
>> @@ -0,0 +1,80 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/iio/adc/ti,ads1298.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Texas Instruments' ads1298 medical ADC chips
>> +
>> +maintainers:
>> +  - Mike Looijmans <mike.looijmans@topic.nl>
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - ti,ads1298
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  spi-cpha: true
>> +
>> +  reset-gpios:
>> +    maxItems: 1
>> +
>> +  avdd-supply:
>> +    description:
>> +      Analog power supply, voltage between AVDD and AVSS. When providin=
g a
>> +      symmetric +/- 2.5V, the regulator should report 5V.
> Commented on in other thread.
>> +
>> +  vref-supply:
>> +    description:
>> +      Optional reference voltage. If omitted, internal reference is use=
d,
>> +      depending on analog supply this is 2.4 or 4V.
>> +
> There is a dvdd-supply as well.  Might be others. Makes sure to document =
them all.

Extra supplies make sense, I'll add them.

>=20
> Should probably also document the gpios as the binding should attempt to =
be as complete
> as possible independent of what the driver currently supports.
>=20
> Lots of complex options for this device and the use of those pins, so may=
be something
> that can be left for now - but the patch description should then mention =
that is intentional.

The device has so many options for connecting stuff... It's indeed possible=
 to=20
(also) use it as a GPIO expander and as a clock source and more...

I'll put it in the patch description that the definition is incomplete by d=
esign.

The main reason I'm submitting is that this is about the third time I've=20
written a driver for this chip, and I'm sure that other companies are writi=
ng=20
their own as well. I'm hoping this will result in some joint effort to=20
properly support it...


>=20
> Jonathan
>=20
>> +  clocks:
>> +    description: Optional 2.048 MHz external source clock on CLK pin
>> +    maxItems: 1
>> +
>> +  clock-names:
>> +    const: clk
>> +
>> +  interrupts:
>> +    description: Interrupt on DRDY pin, triggers on falling edge
>> +    maxItems: 1
>> +
>> +  label: true
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - avdd-supply
>> +  - interrupts
>> +
>> +allOf:
>> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/gpio/gpio.h>
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +    spi {
>> +        #address-cells =3D <1>;
>> +        #size-cells =3D <0>;
>> +
>> +        adc@1 {
>> +          reg =3D <1>;
>> +          compatible =3D "ti,ads1298";
>> +          label =3D "ads1298-1-ecg";
>> +          avdd-supply =3D <&reg_iso_5v_a>;
>> +          clock-names =3D "clk";
>> +          clocks =3D <&clk_ads1298>;
>> +          interrupt-parent =3D <&gpio0>;
>> +          interrupts =3D <78 IRQ_TYPE_EDGE_FALLING>;
>> +          spi-max-frequency =3D <20000000>;
>> +          spi-cpha;
>> +        };
>> +    };
>> +...
>=20