Received: by 2002:a05:7412:d002:b0:f9:9049:d2ea with SMTP id bd2csp37274rdb; Wed, 20 Dec 2023 03:18:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IHikABTGP146KQLM/Mk/uIJaV3XT/UMoGRPGlx8od0rx6v0RtLakizUMAVf2lyo94CN051s X-Received: by 2002:a05:6214:4109:b0:67a:afde:823 with SMTP id kc9-20020a056214410900b0067aafde0823mr17104991qvb.41.1703071087853; Wed, 20 Dec 2023 03:18:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703071087; cv=none; d=google.com; s=arc-20160816; b=k9yltcTpnCfC3ddsNKr6RQEHDt3llp1F+OI4nabIVDq3hX0K3QtKrpSYPTXgbdYxPy gKJksfp5A5Iu1eeM1xonE47xEIej26jgkd+j3+qZtlJgWV3LmoYC4rTWBFlvFA6Ex3Qb Z4QEEBB1Vp5nNW6QZ301anfsKM3EhIxiVtXR1rpIkvIoNwG3sq8+kHGe8NqekUdOGHRG 5r3MVTGj+/cncwGSw1z1e3nP2ED2hUNHtC1PGhxAnHzx1f3QVB5u3KlJtjX+GhvGdHoj wgiZ4E8lQ026aUrYiSeS8Gz+Devyuhx0qugLuuqRMVfVHJPCM9Ni0tvnHY2BKxGOiBRT 2ZxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=7nJTG0ksd0dIqzS4wveRxbem6Vl/tCOC3BG2PhGa4/s=; fh=io6VJuNrc9fIDhLXdVzSvtdNVOhxmUrv8yUeXx2PatA=; b=yVsl7Knj6lXvTsi5849a+pXFSW0CsOu+OZTgG0vf4YyURigbQPqwG45a8PCHOCmV4s aFSGYN47jflBtLqUUjjnuTVCVnuZmfsTAAft5RwbD7aD+J7PQPXj5RPO9kFMt1nu3aVA AJBhqaYLjOwLQVXhVCSuSxjj1n8Pb6aIDBEICJgX8DvX4uAwNz2m2v8S3Yb8vZsE+jbS N7OUNewV56tlXYdGfMKaVMhCJqAZ60xw/wyfFEf564YYhZIN/437gfNfyi9t5n31cNSg qGsqyrHyUOnVddWAgxKIi7WO2WtlnT6Lfe8vqC2Of99iYXSHXARLmgMsJotbo6ID6XjL PTvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Xcw6Ze/2"; spf=pass (google.com: domain of linux-kernel+bounces-6807-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6807-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id p6-20020a0c8c86000000b0067a219b9bdesi13389814qvb.511.2023.12.20.03.18.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 03:18:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-6807-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Xcw6Ze/2"; spf=pass (google.com: domain of linux-kernel+bounces-6807-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6807-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 986C21C210E0 for ; Wed, 20 Dec 2023 11:18:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2D9B521352; Wed, 20 Dec 2023 11:18:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Xcw6Ze/2" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2CB92110F for ; Wed, 20 Dec 2023 11:17:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yb1-f170.google.com with SMTP id 3f1490d57ef6-db3a09e96daso3822804276.3 for ; Wed, 20 Dec 2023 03:17:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703071078; x=1703675878; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7nJTG0ksd0dIqzS4wveRxbem6Vl/tCOC3BG2PhGa4/s=; b=Xcw6Ze/2f0ywoX9xSjDFQHMN7AVqn+C0yf7Tk0sGcxOxmfb9MU9Nl6oBCaojgujn9X abKeHjzgQSVwykKaYRT6W1vlzAN9NFdZ3kmFGVyZ7ivkO36aeu3T1GRQ24ai0eaA7qGb kbXWqCKpzpPSx8Q63v+Ys0wzrcWANBsrqz7+2YuPk1qK5qBAvLfKZI/KT77EbwWf5DDH gorw9XyB4Y9oOZB9K7TMYrt79Uns2lX4NXfbU07lT1djZ36fq5s5ZH2Zj0s9d1Hf8Pf2 43fjkxSz+wEZuRd8HVkXEs00mnqKaWlGGvqFdAtZPAZRKb0PCJFDlD/54lzH0vOsmYQv N5pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703071078; x=1703675878; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7nJTG0ksd0dIqzS4wveRxbem6Vl/tCOC3BG2PhGa4/s=; b=r15y6CZCU3ilQ1fNvqGEfZ6HeDs/klLDxLP5/np8Tgkmh2y/fsKsiRhh9ZIVwzuLb6 mFUMhfQCusNXR3tAe5KR9OxPkTQG3COvIYhGFEgFd+8WCoQ94b8l2zmqQWJrOQkc3pmJ 6ZRYW2FQ+F+V1CW/sM18QyPUeZcNhM98NWSugGSJ2UM0o6UZDoyoPGdqRsOABAJFeqPX at82xPgo44dHRiJDhYtRfxt+W9RN2BzA/Y8ed8K4Q4EJdiu7RWlh0j99Fk6qPvTZaA29 hjFgVPMa40hT7SWmaKQQrRkVKNvQMs71og0WWhPkAPrvDQCBqzix2iUdfCIOOwYq2cwe GpAw== X-Gm-Message-State: AOJu0YwC5KHHohyyCCa3a/i2yHsWjsIHGnEXUClzfDoGjIou3KEyuNQG SKP7z46NvyG2LPxrKs2ha0ZHPtyMoeYzAqcABCAwrg== X-Received: by 2002:a0d:dd4a:0:b0:5e7:7a39:6977 with SMTP id g71-20020a0ddd4a000000b005e77a396977mr2290216ywe.53.1703071077953; Wed, 20 Dec 2023 03:17:57 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231215155300.21186-1-brgl@bgdev.pl> <20231215155300.21186-2-brgl@bgdev.pl> In-Reply-To: <20231215155300.21186-2-brgl@bgdev.pl> From: Linus Walleij Date: Wed, 20 Dec 2023 12:17:46 +0100 Message-ID: Subject: Re: [PATCH v3 1/2] gpiolib: rename static functions that are called with the lock taken To: Bartosz Golaszewski Cc: Andy Shevchenko , Kent Gibson , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Dec 15, 2023 at 4:53=E2=80=AFPM Bartosz Golaszewski = wrote: > From: Bartosz Golaszewski > > Rename two functions that read or modify the global GPIO device list but > don't take the lock themselves (and need to be called with it already > acquired). Use the _unlocked() suffix which seems to be used quite > consistently across the kernel despite there also existing the _locked() > suffix for the same purpose. > > Signed-off-by: Bartosz Golaszewski > Reviewed-by: Andy Shevchenko Reviewed-by: Linus Walleij Yours, Linus Walleij