Received-SPF: pass (google.com: domain of linux-kernel+bounces-6827-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <5a7cdb47541e357629437e0b482a1ca506c3b9f7.camel@suse.com>
Subject: Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a
 heavily called syscall
From: Marcos Paulo de Souza <mpdesouza@suse.com>
To: Shuah Khan <skhan@linuxfoundation.org>, Joe Lawrence
	 <joe.lawrence@redhat.com>
Cc: Marcos Paulo de Souza <mpdesouza@suse.de>, Shuah Khan
 <shuah@kernel.org>,  Jonathan Corbet <corbet@lwn.net>, Heiko Carstens
 <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, Alexander Gordeev
 <agordeev@linux.ibm.com>, Christian Borntraeger
 <borntraeger@linux.ibm.com>, Sven Schnelle <svens@linux.ibm.com>, Josh
 Poimboeuf <jpoimboe@kernel.org>, Jiri Kosina <jikos@kernel.org>, Petr
 Mladek <pmladek@suse.com>, linux-kselftest@vger.kernel.org,
 linux-doc@vger.kernel.org,  linux-kernel@vger.kernel.org,
 linux-s390@vger.kernel.org,  live-patching@vger.kernel.org, Miroslav Benes
 <mbenes@suse.cz>
Date: Wed, 20 Dec 2023 08:33:42 -0300
In-Reply-To: <3a6b1886-c133-4893-8113-73f290b97390@linuxfoundation.org>
References: <20231031-send-lp-kselftests-v3-0-2b1655c2605f@suse.com>
	 <20231031-send-lp-kselftests-v3-3-2b1655c2605f@suse.com>
	 <f9d82fa6-08d7-4ab6-badc-691987b37a82@linuxfoundation.org>
	 <unpg4z7eig6qbudgulnr6sog65fq7s2dy4u2vp2dgkdrq5csdw@dltnxuw6kw5b>
	 <8b95b96c-6aeb-4bf0-8ee9-2ba62330c672@linuxfoundation.org>
	 <12a9ec1bc84dc6d4b461e5c780ba7d3c3aa91740.camel@suse.com>
	 <76c4b967-1cb6-4f77-9402-f835b15adb10@linuxfoundation.org>
	 <alpine.LSU.2.21.2312061530470.13051@pobox.suse.cz>
	 <2498bf91-8057-43e8-98f2-4ed93c53ce9f@linuxfoundation.org>
	 <8a433f12-b930-6095-9a49-db5f1d2836b5@redhat.com>
	 <3a6b1886-c133-4893-8113-73f290b97390@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.1 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2023-12-18 at 13:47 -0700, Shuah Khan wrote:
> On 12/15/23 13:36, Joe Lawrence wrote:
> > On 12/11/23 16:53, Shuah Khan wrote:
> > > On 12/6/23 07:39, Miroslav Benes wrote:
> > > > Hi,
> > > >=20
> > > > On Tue, 5 Dec 2023, Shuah Khan wrote:
> > > >=20
> > > > > On 12/5/23 05:52, mpdesouza@suse.com=C2=A0wrote:
> > > > > > On Fri, 2023-12-01 at 16:38 +0000, Shuah Khan wrote:
> > > > >=20
> > > > > > 0003-selftests-livepatch-Test-livepatching-a-heavily-
> > > > > > call.patch has
> > > > > > style problems, please review.
> > > > > >=20
> > > > > > NOTE: If any of the errors are false positives, please
> > > > > > report
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 them to the ma=
intainer, see CHECKPATCH in
> > > > > > MAINTAINERS.
> > > > > >=20
> > > > > > I couldn't find any mention about "missing module name". Is
> > > > > > your script
> > > > > > showing more warnings than these ones? Can you please share
> > > > > > your
> > > > > > output?
> > > > > >=20
> > > > > > I'll fix MAINTAINERS file but I'll wait until I understand
> > > > > > what's
> > > > > > missing in your checkpatch script to resend the patchset.
> > > > > >=20
> > > > >=20
> > > > > Looks like it is coming a script - still my question stands
> > > > > on
> > > > > whether or not you would need a module name for this module?
> > > >=20
> > > > I admit I am also clueless here. The module name is given in
> > > > Makefile. In
> > > > this case in test_modules/Makefile. I do not know of anything
> > > > else. There
> > > > is no MODULE_NAME macro. Could you elaborate, please?
> > > >=20
> > >=20
> > > I see that now.
> > >=20
> >=20
> > Hi Shuah,
> >=20
> > In the other replies to this thread, Marcos noted that he would add
> > some
> > text to the commit / documentation on running and building the
> > selftests
> > directly in the kernel tree (that would get my Ack) ... is there
> > anything else to be updated for a hopefully final v4 (for your
> > Ack)?
> >=20
>=20
>=20
> I am waiting for v4 with your comments are addressed. I can take
> this through kselftest tree.

Ok. I'm already preparing the v4. The plan is to send in the next few
days.

Thanks,
  Marcos

>=20
> thanks,
> -- Shuah
>=20