Received-SPF: pass (google.com: domain of linux-kernel+bounces-6852-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 20 Dec 2023 11:54:12 +0000
From: Andre Przywara <andre.przywara@arm.com>
To: fuyao <fuyao1697@cyg.com>
Cc: Lee Jones <lee@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec
 <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>,
 linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
 linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
 maijianzhang <maijianzhang@allwinnertech.com>
Subject: Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt
 number
Message-ID: <20231220115412.65bbc8c7@donnerap.manchester.arm.com>
In-Reply-To: <YwdhTlk+9h+9Mrwm@scg>
References: <YxmR5SPPY18O7LaG@google.com>
	<YwdhTlk+9h+9Mrwm@scg>
Organization: ARM
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 20 Dec 2023 15:23:17 +0800
fuyao <fuyao1697@cyg.com> wrote:

Hi,

> __platform_get_irq_byname determinies whether the interrupt
> number is 0 and returns EINVAL.

can you please say what this fixes, exactly? Is something not working at
the moment? Can you please provide parts of the error message?

And maybe expand the explanation a bit more? For instance mention that the
identifiers are used as IRQ resource numbers, where 0 is treated specially.

Cheers,
Andre

> 
> Signed-off-by: fuyao <fuyao1697@cyg.com>
> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> ---
>  include/linux/mfd/sun4i-gpadc.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h
> index ea0ccf33a459..021f820f9d52 100644
> --- a/include/linux/mfd/sun4i-gpadc.h
> +++ b/include/linux/mfd/sun4i-gpadc.h
> @@ -81,8 +81,8 @@
>  #define SUN4I_GPADC_TEMP_DATA				0x20
>  #define SUN4I_GPADC_DATA				0x24
>  
> -#define SUN4I_GPADC_IRQ_FIFO_DATA			0
> -#define SUN4I_GPADC_IRQ_TEMP_DATA			1
> +#define SUN4I_GPADC_IRQ_FIFO_DATA			1
> +#define SUN4I_GPADC_IRQ_TEMP_DATA			2
>  
>  /* 10s delay before suspending the IP */
>  #define SUN4I_GPADC_AUTOSUSPEND_DELAY			10000