Received-SPF: pass (google.com: domain of linux-kernel+bounces-6897-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Peng Fan <peng.fan@nxp.com>
To: Marco Felsch <m.felsch@pengutronix.de>
CC: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, Conor Dooley <conor+dt@kernel.org>, Pengutronix
 Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "linux-gpio@vger.kernel.org"
	<linux-gpio@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Oleksii
 Moisieiev <oleksii_moisieiev@epam.com>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, Sudeep Holla <sudeep.holla@arm.com>,
	Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>,
	Cristian Marussi <cristian.marussi@arm.com>, dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 4/7] dt-bindings: firmware: arm,scmi: support pinctrl
 protocol
Thread-Topic: [PATCH 4/7] dt-bindings: firmware: arm,scmi: support pinctrl
 protocol
Thread-Index: AQHaL00vUsuXdEJTYUWYoB3T3FLKXbCxBK8AgABsGdCAALFEgIAAAH0g
Date: Wed, 20 Dec 2023 12:33:57 +0000
Message-ID:
 <DU0PR04MB9417E926CBD95BD7298B64D28896A@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20231215-pinctrl-scmi-v1-0-0fe35e4611f7@nxp.com>
 <20231215-pinctrl-scmi-v1-4-0fe35e4611f7@nxp.com>
 <20231219192912.yulmczvqbuh4jizg@pengutronix.de>
 <DU0PR04MB94170BCA413C2FD48A397B538896A@DU0PR04MB9417.eurprd04.prod.outlook.com>
 <20231220123033.nrbperhbr4jifuvh@pengutronix.de>
In-Reply-To: <20231220123033.nrbperhbr4jifuvh@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?ELUq2M3qLZrYMYdxOyeeUEHz1L/n/TSIwOwbq8Mq6j4f2DVCKATVyfSNaMrY?=
 =?us-ascii?Q?TvkGn2sssd1sGNHFJjeW7zfOHjQFtm3+QOoRlxLgGHLzEy8GZWa47KfntKhk?=
 =?us-ascii?Q?pO+5X4T/SFMh+VtYF3bZZvti44A/nnh22mihxXDvRB2pzPjB6/bHLRrSObhv?=
 =?us-ascii?Q?74l9ZNVtRSYtApX6lzy+TJmwrwBYPnIQrOrFVXRrAv0DkHuW9TMP29Fh1AZz?=
 =?us-ascii?Q?Dhkvow8VJtJctRq+NN94ZfAmDbBSCSqgOvMv+ttbB4nmH4nggosIPsp5kvmZ?=
 =?us-ascii?Q?TZDzomJGAK6sxb4wvE5AzWSaS4PVXBSmc3+3MsUIQBUbztq4oaWlQkWjHioA?=
 =?us-ascii?Q?ydcIPtwq/cLXfbMrwiqFM/TJC4SyxaUFB2K1EPUnVRt1IQ6pb+nTuzscJK0L?=
 =?us-ascii?Q?6TxVThy+9nls06niFJ4Epm8KEtSBis729KNNFZx7wXSlpWCY4KWBNdnkP7Fg?=
 =?us-ascii?Q?4daGGZqNasuA6evlPk4DL6iwAXRbSWls/A5+xdalIhxXE7S9+cuWgvNTTnEj?=
 =?us-ascii?Q?qncx0zCK1CjlALFzIMxp8rLxapZm2Our4nmptrVhs7XOhs7vFjA6scPq/5Li?=
 =?us-ascii?Q?a2DUPJ6tb96UhGekWEF+2mEyYSikAcuE9vknn3UfEVsGA2y0+bvohXCrZv9a?=
 =?us-ascii?Q?78FHCSlYLWe9MrhGUiO34S96eBstFgOAJqYNbhexK3PHKz75OTqkhfGq4npk?=
 =?us-ascii?Q?6+PqKBt3crloOv+TALNfNTGmQ4RjmLxZlX4VLKLYeLg6D9TTlQB5975UGgbW?=
 =?us-ascii?Q?3Ud61eyH5eH6yDRk7PTlvCREr+D3gKEcJS1frhnsZDSTidIG4olSc+b7CReX?=
 =?us-ascii?Q?S3bfS5czu2jEvaaFETcyCISzkZAhd4uQCD3HlBGLbkhkGJWFfku7b2odczzL?=
 =?us-ascii?Q?zAmCh2Jli7Pud8onWBU6CPFcVyyZ3aGSsjRv3yRubgnKFcH08y6WKfML62Tm?=
 =?us-ascii?Q?0i7iSwiHfRnCXqhW+5CdGpU9JZtOyiB1bpfi616GV6Ufxz5X/Uo0pmlkiqpL?=
 =?us-ascii?Q?XYjaczJ9kOzX4SNOOpKt4OTqcpWBxiaBALUAgc2Li4UMwpwKZOYBMl6KWdNL?=
 =?us-ascii?Q?PLiwKmnYkuioda13AFDI0WQ8+GQBxCu3QHGtRTkDm8Xef9PBpDsC4nUxHCyJ?=
 =?us-ascii?Q?tVoEc3M7a4491elTyJAbgBvINBb4b4yS+hSkDGhmwCBvY40uSaXHhkvj73AX?=
 =?us-ascii?Q?SvWGVN78OOyVInZW5EUZM0dB2oTFsHbIGB9u1ICBoYWqL2Obq2F44HQQuwsn?=
 =?us-ascii?Q?4pfHA3rEYi/g8A2+d8W7bJh+Oh3RixtInNU+PnrGF3Le7tyoXE6HdxILvSVv?=
 =?us-ascii?Q?eOgKqXlhCuwwX8iqK0olmDuMPHhM4MjmlBxPCS/jh0E30J+wS7JGEHYq5S5m?=
 =?us-ascii?Q?rrqegvWCaXOpEJIQVtuNACotMS2VhKEpLdAYqaC8guTGmpaOLR35YLc+pYS+?=
 =?us-ascii?Q?6zthL8heM8LNslfiRQZ5tG5ZXi+XFPihLFtATbqjX+Od92R2+WED+vMAX8qr?=
 =?us-ascii?Q?GGd+owtIkY7mUkyGpeVEuR6Pl4DcZ3MB38fFEtOHwfHDw9YTEkeWpcN9HOWF?=
 =?us-ascii?Q?RjDqe3MSHJUmmHo37AU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d376f6b4-5580-4176-450e-08dc0157efa4
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2023 12:33:57.3453
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 97/VuPBAyi/3Dz81JsgRFDLvUhZdj1TGKS7w0rXZL7+d3PP6KgMAJtcfjUjlGvV76N94Cr99qBXwn3dE+wXjfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9452

> Subject: Re: [PATCH 4/7] dt-bindings: firmware: arm,scmi: support pinctrl
> protocol
>=20
> On 23-12-20, Peng Fan wrote:
> > > Subject: Re: [PATCH 4/7] dt-bindings: firmware: arm,scmi: support
> > > pinctrl protocol
> > >
> > > Hi Peng,
> > >
> > > On 23-12-15, Peng Fan (OSS) wrote:
> > > > From: Peng Fan <peng.fan@nxp.com>
> > > >
> > > > Add SCMI v3.2 pinctrl protocol bindings and example.
> > > >
> > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > > ---
> > > >  .../devicetree/bindings/firmware/arm,scmi.yaml     | 99
> > > ++++++++++++++++++++++
> > > >  1 file changed, 99 insertions(+)
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > > b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > > index 4591523b51a0..bfd2b6a89979 100644
> > > > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > > @@ -247,6 +247,85 @@ properties:
> > > >        reg:
> > > >          const: 0x18
> > > >
> > > > +  protocol@19:
> > >
> > > ...
> > >
> > > > @@ -401,6 +480,26 @@ examples:
> > > >              scmi_powercap: protocol@18 {
> > > >                  reg =3D <0x18>;
> > > >              };
> > > > +
> > > > +            scmi_pinctrl: protocol@19 {
> > > > +                reg =3D <0x19>;
> > > > +                #pinctrl-cells =3D <0>;
> > > > +
> > > > +                i2c2-pins {
> > > > +                    groups =3D "i2c2_a", "i2c2_b";
> > > > +                    function =3D "i2c2";
> > > > +                };
> > > > +
> > > > +                mdio-pins {
> > > > +                    groups =3D "avb_mdio";
> > > > +                    drive-strength =3D <24>;
> > > > +                };
> > > > +
> > > > +                keys_pins: keys-pins {
> > > > +                    pins =3D "GP_5_17", "GP_5_20", "GP_5_22", "GP_=
2_1";
> > > > +                    bias-pull-up;
> > > > +                };
> > > > +            };
> > >
> > > This example is different to the one you mentioned within the
> > > cover-letter. I didn't checked all patches just want to ask which
> > > API will be implemented by this patchset?
> >
> > I kept this change since it was tested by Oleksii, but anyway i.MX not =
use
> these.
> >
> > The API, I suppose you are asking about this?
> > static const struct pinctrl_ops pinctrl_scmi_pinctrl_ops =3D {
> >         .get_groups_count =3D pinctrl_scmi_get_groups_count,
> >         .get_group_name =3D pinctrl_scmi_get_group_name,
> >         .get_group_pins =3D pinctrl_scmi_get_group_pins,
> > #ifdef CONFIG_OF
> >         .dt_node_to_map =3D pinconf_generic_dt_node_to_map_all,
> >         .dt_free_map =3D pinconf_generic_dt_free_map,
> > #endif
> > };
> >
> > static const struct pinctrl_ops pinctrl_scmi_imx_pinctrl_ops =3D {
> >         .get_groups_count =3D pinctrl_scmi_get_groups_count,
> >         .get_group_name =3D pinctrl_scmi_get_group_name,
> >         .get_group_pins =3D pinctrl_scmi_get_group_pins,
> > #ifdef CONFIG_OF
> >         .dt_node_to_map =3D pinctrl_scmi_imx_dt_node_to_map,
> >         .dt_free_map =3D pinconf_generic_dt_free_map,
> > #endif
> > };
>=20
> I see, thanks for the clarification. In short: the i.MX SMCI pinctrl DT-A=
PI is the
> same as the non-SCMI pinctrl API since the dt_node_to_map will convert it=
.

Yes, the fsl,pins format is same whether SCMI or non-SCMI. But we need
to pack the data to a format that matches the i.MX OEM SCMI PINCTRL
protocol, so we need to dedicated dt_node_to_map here.

Thanks,
Peng.

>=20
> Regards,
>   Marco