Received: by 2002:ac8:5349:0:b0:427:7d78:cd45 with SMTP id d9csp807903qto; Wed, 20 Dec 2023 04:40:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IG3+/vdLMuzjqTgs/nSIC9oSGMrULkxwiuFyYQo2426Mhc+Mn+62x6n+znQOxObhJOP0tVm X-Received: by 2002:a05:6214:1d0a:b0:67f:4c93:6f16 with SMTP id e10-20020a0562141d0a00b0067f4c936f16mr4267133qvd.27.1703076044167; Wed, 20 Dec 2023 04:40:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703076044; cv=none; d=google.com; s=arc-20160816; b=itFYWET2uGS03PW7KisV5NnmY25VBjPkbNkIJOfxY3PKD5Kwha+NqffFRyA0V0bTcv JzQ24BjbxveweBnRgHd5+YtXEMvskFg+Rxyi9+DOUXCbhqlY2O+N3A4b8c4HTjDx5HJP itR3b4nqP/xdibh9NHnR+j3SyDrOoVDqMs0BPhnuzfikANK+OrKJAE5roSGeGOoIYMrc BDh0egZ7Pr97IyeMfTMO26KEuV8KNdczto6cPbIT3axm/qzze5LKrcqh5SYkZp+4e62y TlM7u3aoD8sBXuWMUo9yTg1A0duYVG1VUp8PfF0AFa4dGeOkDg8E4/vGzI8ukYSMTfgK a5JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=RFE/yGX6ddk4R8C/xVxy0rmkW8Dm5I69nCzOfe6bhaw=; fh=jb+7rTYkMj9ZgSFm5ZOJgzMjcYIVcCqE1iPAFB8zntM=; b=r4t7g3XE3UI5FqSnwUXZ4/OWONj/1Lr50rQyEcRtoQkZlwhKrYJCzefpRS2U2tyo/x Ge2/dom2pH3Sq1vWDRbIZ3JSjtpUsjx2eXQu4nDTgZlWRYpVBji1HU5hQMS1UGI6Ze/v mn6CuR8tjIOGrJluTxp0qCPLIRPVsU7iXOfZw7LO6EJDNiMrxQ7QMlkxeyl2mtQ5Qi9G E+uarwvjJw7sFVooAzCQeObOjhUxgZSzZGVHi3LxdX/cug+wXh0x/F7M2JayX8CWhaR5 638RsZZSyFlVPNcf9qXZy2vPOnBKFrLNF0c14MLbSJ8N3eEIMI11fKx4MCe1h4CVoj3z 7F/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-6905-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6905-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id h2-20020a0cf442000000b0067f12a60100si1926983qvm.560.2023.12.20.04.40.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 04:40:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-6905-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-6905-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6905-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id EAB241C22CE1 for ; Wed, 20 Dec 2023 12:40:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 902CE25543; Wed, 20 Dec 2023 12:40:28 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3945F2230D; Wed, 20 Dec 2023 12:40:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=alibuda@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0VyuTPGv_1703076019; Received: from 30.221.149.0(mailfrom:alibuda@linux.alibaba.com fp:SMTPD_---0VyuTPGv_1703076019) by smtp.aliyun-inc.com; Wed, 20 Dec 2023 20:40:21 +0800 Message-ID: Date: Wed, 20 Dec 2023 20:40:19 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RFC nf-next v2 1/2] netfilter: bpf: support prog update Content-Language: en-US To: Florian Westphal Cc: Simon Horman , pablo@netfilter.org, kadlec@netfilter.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, coreteam@netfilter.org, netfilter-devel@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ast@kernel.org References: <1702873101-77522-1-git-send-email-alibuda@linux.alibaba.com> <1702873101-77522-2-git-send-email-alibuda@linux.alibaba.com> <20231218190640.GJ6288@kernel.org> <2fd4fb88-8aaa-b22d-d048-776a6c19d9a6@linux.alibaba.com> <20231219145813.GA28704@breakpoint.cc> From: "D. Wythe" In-Reply-To: <20231219145813.GA28704@breakpoint.cc> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/19/23 10:58 PM, Florian Westphal wrote: > D. Wythe wrote: >> net/netfilter/nf_bpf_link.c:31:22: note: in expansion of macro >> ‘rcu_dereference’ >>    31 |  return bpf_prog_run(rcu_dereference((const struct bpf_prog __rcu >> *)nf_link->link.prog), &ctx); >>       |                      ^~~~~~~~~~~~~~~ >> >> So, I think we might need to go back to version 1. >> >> @ Florian , what do you think ? > Use rcu_dereference_raw(). Got it. I'm also good with that. D. Wythe