Received-SPF: pass (google.com: domain of linux-kernel+bounces-6935-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <439916dc-8f71-4998-b145-1d183d9e68f5@quicinc.com>
Date: Wed, 20 Dec 2023 21:07:27 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64: dts: qcom: Add coresight nodes for sm8450
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross
	<agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio
	<konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        "Krzysztof
 Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley
	<conor+dt@kernel.org>
CC: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Tingwei Zhang <quic_tingweiz@quicinc.com>,
        Yuanfang Zhang <quic_yuanfang@quicinc.com>,
        Tao Zhang
	<quic_taozha@quicinc.com>, <coresight@lists.linaro.org>
References: <20231220124009.16816-1-quic_jinlmao@quicinc.com>
 <dfc7fe85-7418-410c-bd82-6e08799e6417@linaro.org>
From: Jinlong Mao <quic_jinlmao@quicinc.com>
In-Reply-To: <dfc7fe85-7418-410c-bd82-6e08799e6417@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 12/20/2023 8:46 PM, Krzysztof Kozlowski wrote:
> On 20/12/2023 13:40, Mao Jinlong wrote:
>> Add coresight components on Qualcomm SM8450 Soc. The components include
>> TMC ETF/ETR, ETE, STM, TPDM, CTI.
>>
>> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8450.dtsi | 742 +++++++++++++++++++++++++++
>>   1 file changed, 742 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> index 1783fa78bdbc..112b5a069c94 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> @@ -285,6 +285,192 @@ CLUSTER_SLEEP_1: cluster-sleep-1 {
>>   		};
>>   	};
>>   
>> +	ete0 {
> 
> ete-0
Thanks for the review.

In arm,embedded-trace-extension.yaml, the node name pattern is 
"^ete([0-9a-f]+)$".

examples:

# An ETE node without legacy CoreSight connections
   - |
     ete0 {
       compatible = "arm,embedded-trace-extension";
       cpu = <&cpu_0>;
     };
# An ETE node with legacy CoreSight connections
   - |
    ete1 {
       compatible = "arm,embedded-trace-extension";
       cpu = <&cpu_1>;

       out-ports {        /* legacy coresight connection */
          port {
              ete1_out_port: endpoint {
                 remote-endpoint = <&funnel_in_port0>;
              };
          };
       };
    };
> 
>> +		compatible = "arm,embedded-trace-extension";
>> +		cpu = <&CPU0>;
>> +
>> +		out-ports {
>> +			port {
>> +				ete0_out_funnel_ete: endpoint {
>> +				remote-endpoint = <&funnel_ete_in_ete0>;
> 
> Missing indentation.
> 
> ...
> 
>> +	funnel_ete {
> 
> funnel
> Anyway underscores are not allowed
> 
>> +		compatible = "arm,coresight-static-funnel";
>> +
>> +		out-ports {
>> +			port {
>> +				funnel_ete_out_funnel_apss: endpoint {
>> +					remote-endpoint =
>> +					<&funnel_apss_in_funnel_ete>;
> 
> Messed indentation
> 
> Errors above look all over this patch, so fix all instances in this patch.
> 
> Best regards,
> Krzysztof
>